Function ideas

[TomWerner]

I'm a big fan of the civ_prog_objects.csv file and have used it as a reference in the past. I'm opening this bug as a place to drop some notes on functions I've identified that aren't in the spreadsheet yet.

I think 0x4BB2A0(GOG version) is City_num_resisting_citizens or something similar. I don't fully understand the function body yet, since it doesn't seem to be accessing the relevant field of Citizen_Body, but based on the usages of the function it seems plausible. For example:

... City_add_or_remove_improvement(...)
...
      popSize = this->Body.Population.Size;
      FoodConsumedPerCitizen = g_FoodConsumedPerCitizen;
      this->Body.FoodRequired = FoodConsumedPerCitizen * (popSize - ((_DWORD (__stdcall *)(int))sub_4BB2A0)(-1));

Since resistors don't consume food this seems like a pretty reasonable guess, and a debugger step through confirmed the function returns 2 on a city with 2 resistors.

[TomWerner]

Also the Rioting_Change_Value field in the city struct I'm fairly sure is the number of unhappy face turns due to pop rushing.

[TomWerner]

• 0x4B4F70 is probably City_draft_unit
• 0x4B5CA0 is probably City_hurry_production.
• 0x4BD780 is another City method and may be war weariness
• 0x4BD9B0 is `City_calculate_unhappy_faces_due_to_aggression
• 0x55C890 is Leader_is_science_age_active
• 0x4AC9E0 is something like City_get_specialist_income_component (science or luxury).
• 0x4ACAE0is something likeCity_get_economy_component` (science or luxury)

[maxpetul]

Hello and welcome! civ_prog_objects.csv has grown to the point that it's a nice reference but it could be even better. I've only been adding to it objects that are needed by C3X. There are many more functions I've decoded over the years that I could add, although I only have GOG addresses for them. If you'd like, I could try to assemble a more thorough list of all the GOG addresses I've identified so far. In fact, I could just send you my entire Ghidra project if that would be helpful.

Confirmed 0x4BB2A0 is City::count_resisting_citizens. Some strong evidence is the call at 0x4AC0F7, which pops up the RESISTANCEENDS map message if that function returns zero. By the way, for cases like this, I find it's easier to insert a bit of code using C3X to inspect the game at runtime instead of using a debugger. To test, I dropped the following:

int (__fastcall * City_count_citizens_field_20_not_zero) (City * this, int edx, int race_id) = (void *)0x4bb2a0;
char ss[200];
snprintf (ss, sizeof ss, "City_count_citizens_field_20_not_zero: %d", City_count_citizens_field_20_not_zero (this->CurrentCity, __, -1));
pop_up_in_game_error (ss);

into patch_City_Form_m82_handle_key_event in the VK_Z branch for toggling zoom. Then just load up the game and press Z when viewing a city to see what the function returns for that city. (count_citizens_field_20_not_zero is the name I'd given it before now.)

0x4B4F70 is probably City_draft_unit

Agreed

0x4B5CA0 is probably City_hurry_production.

Agreed, though I called this do_hurry_production since it's the method that actually does the hurrying. There's also 0x4B6010, which is what's called when you click the hurry button and 0x472270 which triggers a hurrying of production with synchronization for online multiplayer.

0x4BD780 is another City method and may be war weariness

Yes, I called this one City::include_war_weariness, it appears to add unhappiness from war weariness to the count of unhappy faces.

0x4BD9B0 is City_calculate_unhappy_faces_due_to_aggression

Thanks, I hadn't decoded this one.

0x55C890 is Leader_is_science_age_active

Agreed

0x4AC9E0 is something like City_get_specialist_income_component (science or luxury).

Yeah, I had this one named maybe_get_specialist_yield. I'm pretty sure what Antal named AddScience/AddLuxury/AddTaxes are the sum of what the specialists contribute. The first parameter is the yield kind: 0 for luxury, 1 for science, 2 for taxes

0x4ACAE0 is something like City_get_economy_component (science or luxury)

You mean the yields excluding specialists? That would be my guess, I haven't investigated this one.

[TomWerner]

I'm pretty sure what Antal named AddScience/AddLuxury/AddTaxes are the sum of what the specialists contribute

Yeah, agreed. The C7 interpretation of that structure has slightly clearer names (https://github.com/C7-Game/Prototype/blob/Development/QueryCiv3/SavSections/City.cs#L96-L101) though <specialist>Count isn't accurate if specialist yields are something other than 1.

If you'd like, I could try to assemble a more thorough list of all the GOG addresses I've identified so far. In fact, I could just send you my entire Ghidra project if that would be helpful.

That'd be fantastic! Are you on the C7 discord? I could DM you my email address so I'm not sticking it out on a GitHub post. I'm Tom over there, I have lots of recent posts in the #technical channel.

[maxpetul]

I joined the C7 Discord a few years ago but haven't been around since then. I just dusted off my Discord account, my username is flintlock0247.

[TomWerner]

Perfect, I sent you a message. Thanks!