Skip to content

Commit 7a7a3df

Browse files
oschwaldclaude
andcommitted
Fix PHPStan errors in ReportTransactionTest
Remove assertEmpty() wrappers around void report() calls. Since report() returns void, asserting on its return value is meaningless and the @phpstan-ignore-next-line comments targeted the wrong lines. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 54f405d commit 7a7a3df

1 file changed

Lines changed: 11 additions & 23 deletions

File tree

tests/MaxMind/Test/MinFraud/ReportTransaction/ReportTransactionTest.php

Lines changed: 11 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -18,26 +18,18 @@ class ReportTransactionTest extends ServiceClientTester
1818
{
1919
public function testMinimalRequest(): void
2020
{
21-
$this->assertEmpty(
22-
// @phpstan-ignore-next-line
23-
$this->createReportTransactionRequest(
24-
Data::minimalRequest(),
25-
1
26-
)->report(Data::minimalRequest()),
27-
'response for minimal request'
28-
);
21+
$this->createReportTransactionRequest(
22+
Data::minimalRequest(),
23+
1
24+
)->report(Data::minimalRequest());
2925
}
3026

3127
public function testFullRequest(): void
3228
{
3329
$req = Data::fullRequest();
34-
$this->assertEmpty(
35-
// @phpstan-ignore-next-line
36-
$this->createReportTransactionRequest(
37-
$req
38-
)->report($req),
39-
'response for full request'
40-
);
30+
$this->createReportTransactionRequest(
31+
$req
32+
)->report($req);
4133
}
4234

4335
public function testRequestsWithNulls(): void
@@ -52,14 +44,10 @@ public function testRequestsWithNulls(): void
5244
'transaction_id' => null,
5345
]
5446
);
55-
$this->assertEmpty(
56-
// @phpstan-ignore-next-line
57-
$this->createReportTransactionRequest(
58-
Data::minimalRequest(),
59-
1
60-
)->report($req),
61-
'response from request including nulls'
62-
);
47+
$this->createReportTransactionRequest(
48+
Data::minimalRequest(),
49+
1
50+
)->report($req);
6351
}
6452

6553
public function testRequiredFields(): void

0 commit comments

Comments
 (0)