Skip to content

Commit c10c49c

Browse files
oschwaldclaude
oschwald
and
claude
committed
Migrate tests from obsolete constructors to object initializer syntax
Convert all request test files to use `new Foo { Prop = value }` instead of `new Foo(prop: value)`, exercising the recommended API surface. This removes the file-wide `#pragma warning disable CS0618` from 12 test files and the localized pragma around TestFullReportRequest. The cross-property validation test (TestRequired) in TransactionReportTest is replaced by TestReportRequiresIdentifier in WebServiceClientTest, since that validation now lives only in ReportAsync. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 2162954 commit c10c49c

13 files changed

Lines changed: 224 additions & 271 deletions

‎MaxMind.MinFraud.UnitTest/Request/AccountTest.cs‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,28 @@
1-
using MaxMind.MinFraud.Request;
1+
using MaxMind.MinFraud.Request;
22
using Xunit;
33

4-
#pragma warning disable CS0618 // Type or member is obsolete
5-
64
namespace MaxMind.MinFraud.UnitTest.Request
75
{
86
public class AccountTest
97
{
108
[Fact]
119
public void TestUserId()
1210
{
13-
var account = new Account(
14-
userId: "usr"
15-
);
11+
var account = new Account
12+
{
13+
UserId = "usr"
14+
};
1615

1716
Assert.Equal("usr", account.UserId);
1817
}
1918

2019
[Fact]
2120
public void TestUsername()
2221
{
23-
var account = new Account(
24-
username: "username"
25-
);
22+
var account = new Account
23+
{
24+
Username = "username"
25+
};
2626
Assert.Equal("14c4b06b824ec593239362517f538b29", account.UsernameMD5);
2727
}
2828

@@ -32,8 +32,8 @@ public void TestUsername()
3232
[Fact]
3333
public void TestNullUsername()
3434
{
35-
var account = new Account(username: null);
35+
var account = new Account { Username = null };
3636
Assert.Null(account.UsernameMD5);
3737
}
3838
}
39-
}
39+
}

‎MaxMind.MinFraud.UnitTest/Request/BillingTest.cs‎

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
1-
using MaxMind.MinFraud.Request;
1+
using MaxMind.MinFraud.Request;
22
using System;
33
using Xunit;
44

5-
#pragma warning disable CS0618 // Type or member is obsolete
6-
75
namespace MaxMind.MinFraud.UnitTest.Request
86
{
97
// This code is identical to code in ShippingTest. I couldn't
@@ -15,99 +13,100 @@ public class BillingTest
1513
[Fact]
1614
public void TestFirstName()
1715
{
18-
var loc = new Billing(
19-
firstName: "frst"
20-
);
16+
var loc = new Billing
17+
{
18+
FirstName = "frst"
19+
};
2120
Assert.Equal("frst", loc.FirstName);
2221
}
2322

2423
[Fact]
2524
public void TestLastName()
2625
{
27-
var loc = new Billing(lastName: "last");
26+
var loc = new Billing { LastName = "last" };
2827
Assert.Equal("last", loc.LastName);
2928
}
3029

3130
[Fact]
3231
public void TestCompany()
3332
{
34-
var loc = new Billing(company: "company");
33+
var loc = new Billing { Company = "company" };
3534
Assert.Equal("company", loc.Company);
3635
}
3736

3837
[Fact]
3938
public void TestAddress()
4039
{
41-
var loc = new Billing(address: "addr");
40+
var loc = new Billing { Address = "addr" };
4241
Assert.Equal("addr", loc.Address);
4342
}
4443

4544
[Fact]
4645
public void TestAddress2()
4746
{
48-
var loc = new Billing(address2: "addr2");
47+
var loc = new Billing { Address2 = "addr2" };
4948
Assert.Equal("addr2", loc.Address2);
5049
}
5150

5251
[Fact]
5352
public void TestCity()
5453
{
55-
var loc = new Billing(city: "Pdx");
54+
var loc = new Billing { City = "Pdx" };
5655
Assert.Equal("Pdx", loc.City);
5756
}
5857

5958
[Fact]
6059
public void TestRegion()
6160
{
62-
var loc = new Billing(region: "MN");
61+
var loc = new Billing { Region = "MN" };
6362
Assert.Equal("MN", loc.Region);
6463
}
6564

6665
[Fact]
6766
public void TestCountry()
6867
{
69-
var loc = new Billing(country: "US");
68+
var loc = new Billing { Country = "US" };
7069
Assert.Equal("US", loc.Country);
7170
}
7271

7372
[Fact]
7473
public void TestCountryThatIsTooLong()
7574
{
76-
Assert.Throws<ArgumentException>(() => new Billing(country: "USA"));
75+
Assert.Throws<ArgumentException>(() => new Billing { Country = "USA" });
7776
}
7877

7978
[Fact]
8079
public void TestCountryWithNumbers()
8180
{
82-
Assert.Throws<ArgumentException>(() => new Billing(country: "U1"));
81+
Assert.Throws<ArgumentException>(() => new Billing { Country = "U1" });
8382
}
8483

8584
[Fact]
8685
public void TestCountryInWrongCase()
8786
{
88-
Assert.Throws<ArgumentException>(() => new Billing(country: "us"));
87+
Assert.Throws<ArgumentException>(() => new Billing { Country = "us" });
8988
}
9089

9190
[Fact]
9291
public void TestPostal()
9392
{
94-
var loc = new Billing(postal: "03231");
93+
var loc = new Billing { Postal = "03231" };
9594
Assert.Equal("03231", loc.Postal);
9695
}
9796

9897
[Fact]
9998
public void TestPhoneNumber()
10099
{
101100
var phone = "321-321-3213";
102-
var loc = new Billing(phoneNumber: phone);
101+
var loc = new Billing { PhoneNumber = phone };
103102
Assert.Equal(phone, loc.PhoneNumber);
104103
}
105104

106105
[Fact]
107106
public void TestPhoneCountryCode()
108107
{
109-
var loc = new Billing(phoneCountryCode: "1");
108+
var loc = new Billing { PhoneCountryCode = "1" };
110109
Assert.Equal("1", loc.PhoneCountryCode);
111110
}
112111
}
113-
}
112+
}

‎MaxMind.MinFraud.UnitTest/Request/CreditCardTest.cs‎

Lines changed: 25 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,143 +1,131 @@
1-
using MaxMind.MinFraud.Request;
1+
using MaxMind.MinFraud.Request;
22
using System;
33
using Xunit;
44

5-
#pragma warning disable CS0618 // Type or member is obsolete
6-
75
namespace MaxMind.MinFraud.UnitTest.Request
86
{
97
public class CreditCardTest
108
{
119
[Fact]
1210
public void TestCountry()
1311
{
14-
var cc = new CreditCard(country: "US");
15-
Assert.Equal("US", cc.Country);
16-
}
17-
18-
[Fact]
19-
public void TestCountryInit()
20-
{
21-
var cc = new CreditCard
22-
{
23-
Country = "US"
24-
};
12+
var cc = new CreditCard { Country = "US" };
2513
Assert.Equal("US", cc.Country);
2614
}
2715

2816
[Fact]
2917
public void TestCountryThatIsTooLong()
3018
{
31-
Assert.Throws<ArgumentException>(() => new CreditCard(country: "USA"));
19+
Assert.Throws<ArgumentException>(() => new CreditCard { Country = "USA" });
3220
}
3321

3422
[Fact]
3523
public void TestCountryWithNumbers()
3624
{
37-
Assert.Throws<ArgumentException>(() => new CreditCard(country: "U1"));
25+
Assert.Throws<ArgumentException>(() => new CreditCard { Country = "U1" });
3826
}
3927

4028
[Fact]
4129
public void TestCountryInWrongCase()
4230
{
43-
Assert.Throws<ArgumentException>(() => new CreditCard(country: "us"));
31+
Assert.Throws<ArgumentException>(() => new CreditCard { Country = "us" });
4432
}
4533

4634
[Fact]
4735
public void TestIssuerIdNumber()
4836
{
49-
var cc6 = new CreditCard(issuerIdNumber: "123456");
37+
var cc6 = new CreditCard { IssuerIdNumber = "123456" };
5038
Assert.Equal("123456", cc6.IssuerIdNumber);
5139

52-
var cc8 = new CreditCard(issuerIdNumber: "12345678");
40+
var cc8 = new CreditCard { IssuerIdNumber = "12345678" };
5341
Assert.Equal("12345678", cc8.IssuerIdNumber);
5442
}
5543

5644
[Fact]
5745
public void TestIssuerIdNumberThatIsInvalidLength()
5846
{
59-
Assert.Throws<ArgumentException>(() => new CreditCard(issuerIdNumber: "1234567"));
47+
Assert.Throws<ArgumentException>(() => new CreditCard { IssuerIdNumber = "1234567" });
6048
}
6149

6250
[Fact]
6351
public void TestIssuerIdNumberThatIsTooLong()
6452
{
65-
Assert.Throws<ArgumentException>(() => new CreditCard(issuerIdNumber: "123456789"));
53+
Assert.Throws<ArgumentException>(() => new CreditCard { IssuerIdNumber = "123456789" });
6654
}
6755

6856
[Fact]
6957
public void TestIssuerIdNumberThatIsTooShort()
7058
{
71-
Assert.Throws<ArgumentException>(() => new CreditCard(issuerIdNumber: "12345"));
59+
Assert.Throws<ArgumentException>(() => new CreditCard { IssuerIdNumber = "12345" });
7260
}
7361

7462
[Fact]
7563
public void TestIssuerIdNumberThatHasLetters()
7664
{
77-
Assert.Throws<ArgumentException>(() => new CreditCard(issuerIdNumber: "12345a"));
65+
Assert.Throws<ArgumentException>(() => new CreditCard { IssuerIdNumber = "12345a" });
7866
}
7967

8068
[Fact]
8169
public void TestLastDigits()
8270
{
83-
var cc2 = new CreditCard(lastDigits: "12");
71+
var cc2 = new CreditCard { LastDigits = "12" };
8472
Assert.Equal("12", cc2.LastDigits);
8573

86-
var cc4 = new CreditCard(lastDigits: "1234");
74+
var cc4 = new CreditCard { LastDigits = "1234" };
8775
Assert.Equal("1234", cc4.LastDigits);
8876
}
8977

9078
[Fact]
9179
public void TestLastDigitsThatIsTooLong()
9280
{
93-
Assert.Throws<ArgumentException>(() => new CreditCard(lastDigits: "12345"));
81+
Assert.Throws<ArgumentException>(() => new CreditCard { LastDigits = "12345" });
9482
}
9583

9684
[Fact]
9785
public void TestLastDigitsThatIsTooShort()
9886
{
99-
Assert.Throws<ArgumentException>(() => new CreditCard(lastDigits: "1"));
87+
Assert.Throws<ArgumentException>(() => new CreditCard { LastDigits = "1" });
10088
}
10189

10290
[Fact]
10391
public void TestLastDigitsThatHasLetters()
10492
{
105-
Assert.Throws<ArgumentException>(() => new CreditCard(lastDigits: "123a"));
93+
Assert.Throws<ArgumentException>(() => new CreditCard { LastDigits = "123a" });
10694
}
10795

10896
[Fact]
10997
public void TestBankName()
11098
{
111-
var cc = new CreditCard(bankName: "Bank");
99+
var cc = new CreditCard { BankName = "Bank" };
112100
Assert.Equal("Bank", cc.BankName);
113101
}
114102

115103
[Fact]
116104
public void TestBankPhoneCountryCode()
117105
{
118-
var cc = new CreditCard(bankPhoneCountryCode: "1");
106+
var cc = new CreditCard { BankPhoneCountryCode = "1" };
119107
Assert.Equal("1", cc.BankPhoneCountryCode);
120108
}
121109

122110
[Fact]
123111
public void TestBankPhoneNumber()
124112
{
125113
var phone = "231-323-3123";
126-
var cc = new CreditCard(bankPhoneNumber: phone);
114+
var cc = new CreditCard { BankPhoneNumber = phone };
127115
Assert.Equal(phone, cc.BankPhoneNumber);
128116
}
129117

130118
[Fact]
131119
public void TestAvsResult()
132120
{
133-
var cc = new CreditCard(avsResult: 'Y');
121+
var cc = new CreditCard { AvsResult = 'Y' };
134122
Assert.Equal('Y', cc.AvsResult);
135123
}
136124

137125
[Fact]
138126
public void TestCvvResult()
139127
{
140-
var cc = new CreditCard(cvvResult: 'N');
128+
var cc = new CreditCard { CvvResult = 'N' };
141129
Assert.Equal('N', cc.CvvResult);
142130
}
143131

@@ -150,7 +138,7 @@ public void TestCvvResult()
150138
"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx")]
151139
public void TestInvalidToken(string token)
152140
{
153-
Assert.Throws<ArgumentException>(() => new CreditCard(token: token));
141+
Assert.Throws<ArgumentException>(() => new CreditCard { Token = token });
154142
}
155143

156144
[Theory]
@@ -159,15 +147,15 @@ public void TestInvalidToken(string token)
159147
[InlineData("valid_token")]
160148
public void TestValidToken(string token)
161149
{
162-
var cc = new CreditCard(token: token);
150+
var cc = new CreditCard { Token = token };
163151
Assert.Equal(token, cc.Token);
164152
}
165153

166154
[Fact]
167155
public void TestWas3DSecureSuccessful()
168156
{
169-
var cc = new CreditCard(was3DSecureSuccessful: true);
157+
var cc = new CreditCard { Was3DSecureSuccessful = true };
170158
Assert.True(cc.Was3DSecureSuccessful);
171159
}
172160
}
173-
}
161+
}

0 commit comments

Comments
 (0)