From f2dc5d35b545b9ee853bf92c825506da38ef58b4 Mon Sep 17 00:00:00 2001 From: Cameron Gatling Date: Sun, 16 Feb 2020 07:25:13 -0700 Subject: [PATCH 1/2] Change logging level to FINE for matching rules --- rules/src/main/java/ch/maxant/rules/Engine.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/rules/src/main/java/ch/maxant/rules/Engine.java b/rules/src/main/java/ch/maxant/rules/Engine.java index 769ebe8..401bf16 100644 --- a/rules/src/main/java/ch/maxant/rules/Engine.java +++ b/rules/src/main/java/ch/maxant/rules/Engine.java @@ -436,12 +436,18 @@ public List getMatchingRules(String nameSpacePattern, Input input) } Object o = MVEL.executeExpression(r.getCompiled(), vars); - String msg = r.getRule().getFullyQualifiedName() + "-{" + r.getRule().getExpression() + "}"; if(String.valueOf(o).equals("true")){ matchingRules.add(r.getRule()); - if(log.isLoggable(Level.INFO)) log.info("matched: " + msg); + if(log.isLoggable(Level.FINE)) { + String msg = r.getRule().getFullyQualifiedName() + "-{" + r.getRule().getExpression() + "}"; + log.fine("matched: " + msg); + } + }else{ - if(log.isLoggable(Level.INFO)) log.info("unmatched: " + msg); + if(log.isLoggable(Level.FINE)) { + String msg = r.getRule().getFullyQualifiedName() + "-{" + r.getRule().getExpression() + "}"; + log.fine("unmatched: " + msg); + } } } From ac2a7a4b57f478165fbe45aa825a7c899988e973 Mon Sep 17 00:00:00 2001 From: Cameron Gatling Date: Sun, 16 Feb 2020 07:38:59 -0700 Subject: [PATCH 2/2] Change private to protected to allow subclassing --- rules/src/main/java/ch/maxant/rules/Engine.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rules/src/main/java/ch/maxant/rules/Engine.java b/rules/src/main/java/ch/maxant/rules/Engine.java index 401bf16..33ff7b7 100644 --- a/rules/src/main/java/ch/maxant/rules/Engine.java +++ b/rules/src/main/java/ch/maxant/rules/Engine.java @@ -93,7 +93,7 @@ public class Engine { /** static variable bindings to be used in addition to the input when executing rules */ protected final Map statics; - private List rules; + protected List rules; protected final Set uniqueOutcomes = new HashSet(); protected List parsedRules; @@ -457,7 +457,7 @@ public List getMatchingRules(String nameSpacePattern, Input input) return matchingRules; } - private static final class CompiledRule { + protected static final class CompiledRule { private Rule rule; private Serializable compiled; private CompiledRule(Rule rule) {