Merge pull request #15 from matestack/20210603_issue_#9_number_input_for_floats

use step, min, max option for all input type, enabling float number …

Author: jonasjabari

docs/api/form/input.md

@@ -15,72 +15,77 @@ Renders a Bootstrap input field.
 * `browse_button_text` - Expects a string and sets the text to be displayed in the "browse" button for the `:file` input
 * `placeholder` - Expects a string to be displayed as a placeholder for whatever the user decides to choose for the `:file` input. Defaults to "Choose file"
 * `variant` - Expects a symbol to change the size of the select menu, you can use either `:sm` or `:lg`
-* `min` - Sets the corresponding HTML attribute for the `:range` input type
-* `max` - Sets the corresponding HTML attribute for the `:range` input type
-* `step` - Sets the corresponding HTML attribute for the `:range` input type
+* `min` - Sets the corresponding HTML attribute
+* `max` - Sets the corresponding HTML attribute
+* `step` - Sets the corresponding HTML attribute
 * `show_value` - Expects a boolean. Defaults to `false`, if set to `true` it displays the current value for the corresponding `:range` input type field
 
 ## Examples
 
-### Example 1: Basic usage
+### Basic usage for text input
 
 ```ruby
 bs_form_input key: :foo, type: :text
 ```
 
-### Example 2: Basic usage with label and form text
+### Basic usage for float number input
+
+```ruby
+bs_form_input key: :foo, type: :number, step: 0.01
+```
+
+### Basic usage with label and form text
 
 ```ruby
 bs_form_input key: :foo, type: :text, label: "Input field", form_text: "some notes"
 ```
 
-### Example 3: Basic usage as disabled input
+### Basic usage as disabled input
 
 ```ruby
 bs_form_input key: :foo, type: :text, disabled: true
 ```
 
 returns
 
-### Example 4: Basic usage with custom class
+### Basic usage with custom class
 
 ```ruby
 bs_form_input key: :foo, type: :text, class: "some-class"
 ```
 
-### Example 5: Basic usage with placeholder
+### Basic usage with placeholder
 
 ```ruby
 bs_form_input key: :foo, type: :text, placeholder: "fill!"
 ```
 
-### Example 6: Basic usage as range input
+### Basic usage as range input
 
 ```ruby
 bs_form_input key: :some_range_input, type: :range, max: 10
 ```
 
-### Example 7: Using range input with show\_value and non-default steps
+### Using range input with show\_value and non-default steps
 
 ```ruby
 bs_form_input key: :some_range_input, type: :range, step: 2, max: 10, show_value: true
 ```
 
-### Example 8: Basic usage as file input
+### Basic usage as file input
 
 ```ruby
 bs_form_input key: :some_single_file_input, type: :file
 ```
 
-### Example 9: File input with non-default size and optional form\_text
+### File input with non-default size and optional form\_text
 
 ```ruby
 bs_form_input variant: :lg, form_text: "just some notes", key: :some_single_file_input, type: :file
 ```
 
-### Example 10: Multi-file input with placeholder and browse\_button\_text
+### Multi-file input with placeholder and browse\_button\_text
 
 ```ruby
 bs_form_input placeholder: "Select a file", browse_button_text: "Click", key: :some_multi_file_input, type: :file, multiple: true
 ```
-

lib/matestack/ui/bootstrap/form/input.rb

@@ -39,7 +39,10 @@ def bootstrap_input_attributes
     {
       id: (options[:id] || attribute_key),
       class: (options[:class] || "") << (" form-control"),
-      disabled: context.disabled
+      disabled: context.disabled,
+      min: context.min,
+      max: context.max,
+      step: context.step
     }
   end
 

spec/test/form/input_spec.rb

@@ -103,6 +103,48 @@
     expect(page).to have_xpath('//form//div[@id="form_text_for_foo" and contains(@class, "form-text") and contains(text(), "some notes")]')
   end
 
+  it 'renders basic bootstrap input field accepting float numbers' do
+    form_config = get_form_config(path: input_success_form_test_path)
+    matestack_render do
+      matestack_form form_config do
+        bs_form_input key: :foo, type: :number, step: 0.01
+        bs_form_submit text: "Submit"
+      end
+    end
+    visit example_path
+    fill_in "foo", with: 1.45
+
+    expect_any_instance_of(FormTestController).to receive(:expect_params)
+      .with(hash_including(wrapper: { foo: 1.45 }))
+
+    click_button "Submit"
+  end
+
+  it 'renders basic bootstrap input field accepting float numbers as text with , delimeter via pattern regex' do
+    form_config = get_form_config(path: input_success_form_test_path)
+    matestack_render do
+      matestack_form form_config do
+        bs_form_input key: :foo, type: :text, pattern: "[0-9]+([,][0-9]+)?"
+        bs_form_submit text: "Submit"
+      end
+    end
+    visit example_path
+
+    fill_in "foo", with: "1.45"
+
+    expect_any_instance_of(FormTestController).not_to receive(:expect_params)
+      .with(hash_including(wrapper: { foo: "1.45" }))
+
+    click_button "Submit"
+
+    fill_in "foo", with: "1,45"
+
+    expect_any_instance_of(FormTestController).to receive(:expect_params)
+      .with(hash_including(wrapper: { foo: "1,45" }))
+
+    click_button "Submit"
+  end
+
   it 'renders basic bootstrap range input' do
     form_config = get_form_config(path: input_success_form_test_path)
     matestack_render do