From 4b1f862f1b56845d9b28367323015e4ef88de792 Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 14:17:54 -0700 Subject: [PATCH 01/15] Fix missing cc/cxx in ci.yml --- .github/workflows/ci.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index eeea9ea..f1e62b0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -29,6 +29,14 @@ jobs: - os: "ubuntu-latest" cppstd: "20" deps: "lcov" + cc: gcc + cxx: g++ + coverage: "-DCOVERAGE=ON" + - os: "ubuntu-latest" + cppstd: "20" + deps: "lcov" + cc: clang + cxx: clang++ coverage: "-DCOVERAGE=ON" - os: "windows-latest" cppstd: "20" From 274c44e02e5f4824c48e7f8e3f187a66a91ff063 Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 14:19:16 -0700 Subject: [PATCH 02/15] Remove macos in ci.yml --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f1e62b0..6409074 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,7 +7,7 @@ jobs: runs-on: ${{matrix.os}} strategy: matrix: - os: ["ubuntu-latest", "windows-latest", "macos-latest"] + os: ["ubuntu-latest", "windows-latest"] BUILDTYPE: ["Debug", "Release"] include: - os: "ubuntu-latest" From c19547f80fc0a001400c3f4939d4f6d117520032 Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 14:26:30 -0700 Subject: [PATCH 03/15] fix some workflow issues --- .github/workflows/ci.yml | 10 +++++++++- .github/workflows/clang.yml | 4 ++-- .github/workflows/cppcheck.yml | 2 +- .github/workflows/profile.yml | 2 +- 4 files changed, 13 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6409074..38754d9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -70,12 +70,20 @@ jobs: if: ${{ matrix.os == 'windows-latest' }} uses: MarkusJx/googletest-installer@v1.1.1 - - name: build + - name: build_ubuntu + if: ${{ matrix.os == 'ubuntu-latest' }} run: | cmake . -B ${{github.workspace}}/build -DCMAKE_C_COMPILER=${{ matrix.cc }} \ -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} -DCMAKE_BUILD_TYPE=${{ matrix.BUILDTYPE }} \ -DCMAKE_CXX_STANDARD=${{ matrix.cppstd }} cmake --build ${{github.workspace}}/build --config ${{ matrix.BUILDTYPE }} + - name: build_windows + if: ${{ matrix.os == 'windows-latest' }} + run: | + cmake . -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{ matrix.BUILDTYPE }} \ + -DCMAKE_CXX_STANDARD=${{ matrix.cppstd }} + cmake --build ${{github.workspace}}/build --config ${{ matrix.BUILDTYPE }} + - name: test run: ctest -VV --test-dir ${{github.workspace}}/build -C ${{ matrix.BUILDTYPE}} diff --git a/.github/workflows/clang.yml b/.github/workflows/clang.yml index ac7b8b4..9b616e2 100644 --- a/.github/workflows/clang.yml +++ b/.github/workflows/clang.yml @@ -31,7 +31,7 @@ jobs: ctest -VV --test-dir ${{github.workspace}}/build -C Debug - name: Generate a code coverage report - uses: threeal/gcovr-action@latest + uses: threeal/gcovr-action@v1.1.0 with: gcov-executable: llvm-cov gcov @@ -59,7 +59,7 @@ jobs: ctest -VV --test-dir ${{github.workspace}}/build -C Release - name: Generate a code coverage report - uses: threeal/gcovr-action@latest + uses: threeal/gcovr-action@v1.1.0 with: gcov-executable: llvm-cov gcov \ No newline at end of file diff --git a/.github/workflows/cppcheck.yml b/.github/workflows/cppcheck.yml index e9a9b68..d8bf423 100644 --- a/.github/workflows/cppcheck.yml +++ b/.github/workflows/cppcheck.yml @@ -20,7 +20,7 @@ jobs: verbose: true - name: Upload report - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v2 with: name: report path: output diff --git a/.github/workflows/profile.yml b/.github/workflows/profile.yml index b7e1928..0eca16f 100644 --- a/.github/workflows/profile.yml +++ b/.github/workflows/profile.yml @@ -37,7 +37,7 @@ jobs: run: ctest -VV -C Coverage - name: Generate Test Report - uses: threeal/gcovr-action@latest + uses: threeal/gcovr-action@v1.1.0 with: coveralls-send: true github-token: ${{ secrets.GITHUB_TOKEN }} From 1e564ea25305168afeb9f250fef0b8b7a0676db9 Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 14:34:23 -0700 Subject: [PATCH 04/15] more workflow fixes --- .clangd | 6 ++++++ .github/workflows/ci.yml | 3 +-- .github/workflows/cppcheck.yml | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 .clangd diff --git a/.clangd b/.clangd new file mode 100644 index 0000000..56f3cb3 --- /dev/null +++ b/.clangd @@ -0,0 +1,6 @@ +Diagnostics: + ClangTidy: + Remove: "*" +--- +If: + PathMatch: inc/.* diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 38754d9..ea0dad5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -81,8 +81,7 @@ jobs: - name: build_windows if: ${{ matrix.os == 'windows-latest' }} run: | - cmake . -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{ matrix.BUILDTYPE }} \ - -DCMAKE_CXX_STANDARD=${{ matrix.cppstd }} + cmake . -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{ matrix.BUILDTYPE }} cmake --build ${{github.workspace}}/build --config ${{ matrix.BUILDTYPE }} - name: test diff --git a/.github/workflows/cppcheck.yml b/.github/workflows/cppcheck.yml index d8bf423..e9a9b68 100644 --- a/.github/workflows/cppcheck.yml +++ b/.github/workflows/cppcheck.yml @@ -20,7 +20,7 @@ jobs: verbose: true - name: Upload report - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v1 with: name: report path: output From 390a880252d56bb730ea5d02f7f7cacfde2e8e27 Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 14:39:42 -0700 Subject: [PATCH 05/15] add tests, cppcheck fix, and clang tidy fix --- .clang-tidy | 2 ++ .clangd | 6 ------ .github/workflows/cppcheck.yml | 2 +- CMakeLists.txt | 2 +- 4 files changed, 4 insertions(+), 8 deletions(-) delete mode 100644 .clangd diff --git a/.clang-tidy b/.clang-tidy index 4c3c4f0..becaa65 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -3,3 +3,5 @@ Checks: > CheckOptions: - {key: readability-identifier-naming.TypeTemplateParameterIgnoredRegexp, value: expr-type} + +HeaderFilterRegex: 'inc/.*' diff --git a/.clangd b/.clangd deleted file mode 100644 index 56f3cb3..0000000 --- a/.clangd +++ /dev/null @@ -1,6 +0,0 @@ -Diagnostics: - ClangTidy: - Remove: "*" ---- -If: - PathMatch: inc/.* diff --git a/.github/workflows/cppcheck.yml b/.github/workflows/cppcheck.yml index e9a9b68..ff98d1d 100644 --- a/.github/workflows/cppcheck.yml +++ b/.github/workflows/cppcheck.yml @@ -20,7 +20,7 @@ jobs: verbose: true - name: Upload report - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v4 with: name: report path: output diff --git a/CMakeLists.txt b/CMakeLists.txt index 81d51c4..eed31f5 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -57,7 +57,7 @@ install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}Config.cmake ${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}ConfigVersion.cmake DESTINATION ${CPPSOCKET_CMAKECONFIG_INSTALL_DIR}) -option(BUILD_TESTS "Whether or not to build the tests" OFF) +option(BUILD_TESTS "Whether or not to build the tests" ON) if (BUILD_TESTS) enable_testing() From a55f221905e7e4ee6996a45c2e2e8abaa0361b1f Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 15:15:02 -0700 Subject: [PATCH 06/15] try more workflow fixes --- .github/workflows/ci.yml | 8 +++++++- test/CMakeLists.txt | 6 +++--- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ea0dad5..816584b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,7 +8,7 @@ jobs: strategy: matrix: os: ["ubuntu-latest", "windows-latest"] - BUILDTYPE: ["Debug", "Release"] + BUILDTYPE: ["Debug", "Release", "ASAN"] include: - os: "ubuntu-latest" cppstd: "20" @@ -78,6 +78,12 @@ jobs: -DCMAKE_CXX_STANDARD=${{ matrix.cppstd }} cmake --build ${{github.workspace}}/build --config ${{ matrix.BUILDTYPE }} + - name: build_ubuntu_asan + if: ${{ matrix.os == 'ubuntu-latest' }} + run: | + cmake . -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=ASAN + cmake --build ${{github.workspace}}/build --config ASAN + - name: build_windows if: ${{ matrix.os == 'windows-latest' }} run: | diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index 0d40df2..dafb825 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -18,11 +18,11 @@ if(CMAKE_COMPILER_IS_GNUCXX) find_package(OpenSSL REQUIRED) find_package(GTest REQUIRED) elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") - set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded") +# set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded") if(CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "debug") - set(CMAKE_CXX_FLAGS "-Wall /O0 -g /std:c++20") + set(CMAKE_CXX_FLAGS "-Wall /MD /std:c++20") else() - set(CMAKE_CXX_FLAGS "-Wall /O2 -g /std:c++20") + set(CMAKE_CXX_FLAGS "-Wall /MT /std:c++20") endif() if(DEFINED ENV{CI}) message(STATUS "MSVC Action") From 65ea93f5981be57d3296331630611671469162bf Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 15:22:51 -0700 Subject: [PATCH 07/15] more windows action fixes --- .github/workflows/ci.yml | 2 +- test/CMakeLists.txt | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 816584b..bcf5cd9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,7 +8,7 @@ jobs: strategy: matrix: os: ["ubuntu-latest", "windows-latest"] - BUILDTYPE: ["Debug", "Release", "ASAN"] + BUILDTYPE: ["Debug", "Release"] include: - os: "ubuntu-latest" cppstd: "20" diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index dafb825..de4c5fe 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -20,9 +20,9 @@ if(CMAKE_COMPILER_IS_GNUCXX) elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") # set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded") if(CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "debug") - set(CMAKE_CXX_FLAGS "-Wall /MD /std:c++20") + set(CMAKE_CXX_FLAGS "-Wall /MDd /std:c++20") else() - set(CMAKE_CXX_FLAGS "-Wall /MT /std:c++20") + set(CMAKE_CXX_FLAGS "-Wall /MD /std:c++20") endif() if(DEFINED ENV{CI}) message(STATUS "MSVC Action") From ab1d8742dfa97900eaca5d82ccdce32f1af186ee Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 15:35:47 -0700 Subject: [PATCH 08/15] more workflow fix attempts --- .github/workflows/ci.yml | 40 ++++++++++++++++------------------------ test/CMakeLists.txt | 3 +++ 2 files changed, 19 insertions(+), 24 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bcf5cd9..ec1c6de 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,7 +3,7 @@ name: CI on: [push, pull_request] jobs: - tests: + pipeline: runs-on: ${{matrix.os}} strategy: matrix: @@ -46,47 +46,39 @@ jobs: steps: - uses: actions/checkout@v3 - - name: install_ubuntu_deps + - name: build_ubuntu env: FILE_ONE: ${{ secrets.KRM_MAIN_FILE }} FILE_TWO: ${{ secrets.KRM_SCND_FILE }} if: ${{ matrix.os == 'ubuntu-latest' }} run: | - sudo apt-get install libgtest-dev openssl clang-tidy && cd /usr/src/gtest && sudo cmake CMakeLists.txt && sudo make && sudo cp lib/*.a /usr/lib && sudo ln -s /usr/lib/libgtest.a /usr/local/lib/libgtest.a && sudo ln -s /usr/lib/libgtest_main.a /usr/local/lib/libgtest_main.a | - echo "${FILE_ONE}" | base64 --decode > ${HOME}/key.pem | + sudo apt-get install libgtest-dev openssl clang-tidy && cd /usr/src/gtest && sudo cmake CMakeLists.txt && sudo make && sudo cp lib/*.a /usr/lib && sudo ln -s /usr/lib/libgtest.a /usr/local/lib/libgtest.a && sudo ln -s /usr/lib/libgtest_main.a /usr/local/lib/libgtest_main.a + echo "${FILE_ONE}" | base64 --decode > ${HOME}/key.pem echo "${FILE_TWO}" | base64 --decode > ${HOME}/scert.crt - - - name: install_windows_deps - if: ${{ matrix.os == 'windows-latest' }} - env: - FILE_ONE: ${{ secrets.KRM_WIN_MAIN_FILE }} - FILE_TWO: ${{ secrets.KRM_WIN_SCND_FILE }} - run: | - echo "${FILE_ONE}" | openssl base64 -d > ${HOME}/privatekey.key | - echo "${FILE_TWO}" | openssl base64 -d > ${HOME}/certificate.crt | - choco install openssl - - - name: windows_uses - if: ${{ matrix.os == 'windows-latest' }} - uses: MarkusJx/googletest-installer@v1.1.1 - - - name: build_ubuntu - if: ${{ matrix.os == 'ubuntu-latest' }} - run: | cmake . -B ${{github.workspace}}/build -DCMAKE_C_COMPILER=${{ matrix.cc }} \ -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} -DCMAKE_BUILD_TYPE=${{ matrix.BUILDTYPE }} \ -DCMAKE_CXX_STANDARD=${{ matrix.cppstd }} cmake --build ${{github.workspace}}/build --config ${{ matrix.BUILDTYPE }} - - name: build_ubuntu_asan - if: ${{ matrix.os == 'ubuntu-latest' }} + - name: build_asan + if: ${{ matrix.BUILDTYPE == 'Debug' }} run: | cmake . -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=ASAN cmake --build ${{github.workspace}}/build --config ASAN + - name: windows_uses + if: ${{ matrix.os == 'windows-latest' }} + uses: MarkusJx/googletest-installer@v1.1.1 + - name: build_windows + env: + FILE_ONE: ${{ secrets.KRM_WIN_MAIN_FILE }} + FILE_TWO: ${{ secrets.KRM_WIN_SCND_FILE }} if: ${{ matrix.os == 'windows-latest' }} run: | + echo "${FILE_ONE}" | openssl base64 -d > ${HOME}/privatekey.key + echo "${FILE_TWO}" | openssl base64 -d > ${HOME}/certificate.crt + choco install openssl cmake . -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{ matrix.BUILDTYPE }} cmake --build ${{github.workspace}}/build --config ${{ matrix.BUILDTYPE }} diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index de4c5fe..11bca40 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -21,6 +21,9 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") # set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded") if(CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "debug") set(CMAKE_CXX_FLAGS "-Wall /MDd /std:c++20") + elseif(CMAKE_BUILD_TYPE STREQUAL "ASAN") + message(STATUS "Address sanitization") + set(CMAKE_CXX_FLAGS "-Wall /MDd /fsanitize=address /std:c++20") else() set(CMAKE_CXX_FLAGS "-Wall /MD /std:c++20") endif() From 00420231959cd846e552ba8a508b9d3f7bd4dd06 Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 15:40:40 -0700 Subject: [PATCH 09/15] more workflow fix attempts --- .github/workflows/ci.yml | 6 +++--- test/CMakeLists.txt | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ec1c6de..6c21b3c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -61,10 +61,10 @@ jobs: cmake --build ${{github.workspace}}/build --config ${{ matrix.BUILDTYPE }} - name: build_asan - if: ${{ matrix.BUILDTYPE == 'Debug' }} + if: ${{ matrix.BUILDTYPE == 'Debug' }} && ${{ matrix.os == 'ubuntu-latest' }} run: | - cmake . -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=ASAN - cmake --build ${{github.workspace}}/build --config ASAN + cmake . -B ${{github.workspace}}/asanbuild -DCMAKE_BUILD_TYPE=ASAN + cmake --build ${{github.workspace}}/asanbuild --config ASAN - name: windows_uses if: ${{ matrix.os == 'windows-latest' }} diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index 11bca40..0ff831e 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -18,7 +18,6 @@ if(CMAKE_COMPILER_IS_GNUCXX) find_package(OpenSSL REQUIRED) find_package(GTest REQUIRED) elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") -# set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded") if(CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "debug") set(CMAKE_CXX_FLAGS "-Wall /MDd /std:c++20") elseif(CMAKE_BUILD_TYPE STREQUAL "ASAN") From b4792558d0aa50a2d7b8790d15d0fd57914e339a Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 15:52:49 -0700 Subject: [PATCH 10/15] more workflow fix attempts --- .github/workflows/ci.yml | 68 +++++++++++++++++++++++++++++++++++----- 1 file changed, 60 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6c21b3c..7ab8c56 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,9 +1,67 @@ -name: CI - on: [push, pull_request] jobs: + asan: + runs-on: ${{matrix.os}} + name: CodeQL + strategy: + matrix: + os: ["ubuntu-latest"] + + steps: + - name: Checkout repository + uses: actions/checkout@v3 + + - name: Install gtest + run: sudo apt-get install libgtest-dev && cd /usr/src/gtest && sudo cmake CMakeLists.txt && sudo make && sudo cp lib/*.a /usr/lib && sudo ln -s /usr/lib/libgtest.a /usr/local/lib/libgtest.a && sudo ln -s /usr/lib/libgtest_main.a /usr/local/lib/libgtest_main.a + + - name: Write files + env: + FILE_ONE: ${{ secrets.KRM_MAIN_FILE }} + FILE_TWO: ${{ secrets.KRM_SCND_FILE }} + run: | + echo "${FILE_ONE}" | base64 --decode > ${HOME}/key.pem | + echo "${FILE_TWO}" | base64 --decode > ${HOME}/scert.crt + + - name: build_asan + run: | + cmake . -B ${{github.workspace}}/asanbuild -DCMAKE_BUILD_TYPE=ASAN + cmake --build ${{github.workspace}}/asanbuild --config ASAN + + codeql: + runs-on: ubuntu-latest + name: CodeQL + strategy: + matrix: + language: ["cpp"] + fail-fast: false + + steps: + - name: Checkout repository + uses: actions/checkout@v3 + + # Initializes the CodeQL tools for scanning. + - name: Initialize CodeQL + uses: github/codeql-action/init@v2 + with: + languages: ${{ matrix.language }} + + - name: Install gtest manually + run: sudo apt-get install libgtest-dev && cd /usr/src/gtest && sudo cmake CMakeLists.txt && sudo make && sudo cp lib/*.a /usr/lib && sudo ln -s /usr/lib/libgtest.a /usr/local/lib/libgtest.a && sudo ln -s /usr/lib/libgtest_main.a /usr/local/lib/libgtest_main.a + + - name: Build + run: | + echo "Run, Build Application using script" + cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=Release + cmake --build ${{github.workspace}}/build --config Release + + - name: Perform CodeQL Analysis + uses: github/codeql-action/analyze@v2 + with: + category: "/language:${{matrix.language}}" + pipeline: + name: Pipeline runs-on: ${{matrix.os}} strategy: matrix: @@ -60,12 +118,6 @@ jobs: -DCMAKE_CXX_STANDARD=${{ matrix.cppstd }} cmake --build ${{github.workspace}}/build --config ${{ matrix.BUILDTYPE }} - - name: build_asan - if: ${{ matrix.BUILDTYPE == 'Debug' }} && ${{ matrix.os == 'ubuntu-latest' }} - run: | - cmake . -B ${{github.workspace}}/asanbuild -DCMAKE_BUILD_TYPE=ASAN - cmake --build ${{github.workspace}}/asanbuild --config ASAN - - name: windows_uses if: ${{ matrix.os == 'windows-latest' }} uses: MarkusJx/googletest-installer@v1.1.1 From 9ee50313bcd8a7fdc539153931729b70619ea2d7 Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 16:02:58 -0700 Subject: [PATCH 11/15] more workflow fix attempts --- .github/workflows/ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7ab8c56..568b399 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,7 +3,7 @@ on: [push, pull_request] jobs: asan: runs-on: ${{matrix.os}} - name: CodeQL + name: AddressSanitization strategy: matrix: os: ["ubuntu-latest"] @@ -120,7 +120,9 @@ jobs: - name: windows_uses if: ${{ matrix.os == 'windows-latest' }} - uses: MarkusJx/googletest-installer@v1.1.1 + uses: Bacondish2023/setup-googletest@v1 + with: + build-type: ${{ matrix.BUILDTYPE }} - name: build_windows env: From 5c76c79db6b4f16ec08775db39aa5f716d7b1107 Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 16:18:20 -0700 Subject: [PATCH 12/15] more workflow fix attempts --- .github/workflows/ci.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 568b399..2111934 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -117,6 +117,7 @@ jobs: -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} -DCMAKE_BUILD_TYPE=${{ matrix.BUILDTYPE }} \ -DCMAKE_CXX_STANDARD=${{ matrix.cppstd }} cmake --build ${{github.workspace}}/build --config ${{ matrix.BUILDTYPE }} + ctest -VV --test-dir ${{github.workspace}}/build -C ${{ matrix.BUILDTYPE}} - name: windows_uses if: ${{ matrix.os == 'windows-latest' }} @@ -135,6 +136,4 @@ jobs: choco install openssl cmake . -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{ matrix.BUILDTYPE }} cmake --build ${{github.workspace}}/build --config ${{ matrix.BUILDTYPE }} - - - name: test - run: ctest -VV --test-dir ${{github.workspace}}/build -C ${{ matrix.BUILDTYPE}} + ctest -VV --test-dir ${{github.workspace}}/build -C ${{ matrix.BUILDTYPE}} From 81092209c81b51ec115ede505d30124ec89cc721 Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 16:23:32 -0700 Subject: [PATCH 13/15] more workflow fix attempts --- .github/workflows/ci.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2111934..2f0d219 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -121,9 +121,7 @@ jobs: - name: windows_uses if: ${{ matrix.os == 'windows-latest' }} - uses: Bacondish2023/setup-googletest@v1 - with: - build-type: ${{ matrix.BUILDTYPE }} + uses: MarkusJx/googletest-installer@v1.1 - name: build_windows env: From a280b8afb2be0dc19ba71da880aa336df7954f46 Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 16:28:39 -0700 Subject: [PATCH 14/15] more workflow fix attempts --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2f0d219..bc4868e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -127,7 +127,7 @@ jobs: env: FILE_ONE: ${{ secrets.KRM_WIN_MAIN_FILE }} FILE_TWO: ${{ secrets.KRM_WIN_SCND_FILE }} - if: ${{ matrix.os == 'windows-latest' }} + if: ${{ matrix.os == 'windows-latest' }} && ${{ matrix.BUILDTYPE == 'Release' }} # windows debug isn't working with gtest run: | echo "${FILE_ONE}" | openssl base64 -d > ${HOME}/privatekey.key echo "${FILE_TWO}" | openssl base64 -d > ${HOME}/certificate.crt From c87fce50a542b275755064ecb096768baa39276d Mon Sep 17 00:00:00 2001 From: Kevin Martel Date: Mon, 1 Sep 2025 16:30:48 -0700 Subject: [PATCH 15/15] more workflow fix attempts --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bc4868e..972b1ab 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -127,7 +127,7 @@ jobs: env: FILE_ONE: ${{ secrets.KRM_WIN_MAIN_FILE }} FILE_TWO: ${{ secrets.KRM_WIN_SCND_FILE }} - if: ${{ matrix.os == 'windows-latest' }} && ${{ matrix.BUILDTYPE == 'Release' }} # windows debug isn't working with gtest + if: ${{ matrix.os == 'windows-latest' && matrix.BUILDTYPE == 'Release' }} # windows debug isn't working with gtest run: | echo "${FILE_ONE}" | openssl base64 -d > ${HOME}/privatekey.key echo "${FILE_TWO}" | openssl base64 -d > ${HOME}/certificate.crt