add a way to get an empty GraphPermissions object via GraphManager.newGraphPermissions()

(cherry picked from commit 931a68b)

Author: sammefford

src/main/java/com/marklogic/client/impl/GraphManagerImpl.java

@@ -417,4 +417,7 @@ private String validateGraphsMimetype(HandleImplementation baseHandle) {
         return mimetype;
     }
 
+    public GraphPermissions newGraphPermissions() {
+        return new GraphPermissionsImpl();
+    }
 }

src/main/java/com/marklogic/client/impl/GraphPermissionsImpl.java

@@ -24,13 +24,6 @@
 import com.marklogic.client.semantics.GraphPermissions;
 
 public class GraphPermissionsImpl extends HashMap<String, Set<Capability>> implements GraphPermissions {
-
-    public GraphPermissionsImpl(String role, Capability... capabilities) {
-        super();
-        if ( capabilities == null ) throw new IllegalArgumentException("capabilities cannot be null");
-        this.put(role, new HashSet<Capability>(Arrays.asList(capabilities)) );
-    }
-
     @Override
     public GraphPermissions permission(String role, Capability... capabilities) {
         if ( capabilities == null ) throw new IllegalArgumentException("capabilities cannot be null");

src/main/java/com/marklogic/client/impl/SPARQLQueryDefinitionImpl.java

@@ -175,7 +175,7 @@ public GraphPermissions getUpdatePermissions() {
     public SPARQLQueryDefinition withUpdatePermission(String role,
             Capability capability) {
         if ( permissions == null ) {
-            permissions = new GraphPermissionsImpl(role, capability);
+            permissions = new GraphPermissionsImpl().permission(role, capability);
         } else {
             permissions = permissions.permission(role, capability);
         }

src/main/java/com/marklogic/client/impl/SPARQLQueryManagerImpl.java

@@ -172,6 +172,6 @@ public void executeUpdate(SPARQLQueryDefinition qdef, Transaction tx) {
 
     @Override
     public GraphPermissions permission(String role, Capability... capabilities) {
-        return new GraphPermissionsImpl(role, capabilities);
+        return new GraphPermissionsImpl().permission(role, capabilities);
     }
 }

src/main/java/com/marklogic/client/semantics/GraphManager.java

@@ -643,5 +643,7 @@ public void deleteGraphs(Transaction transaction)
      * mimetype.
      */
     public void setDefaultMimetype(String mimetype);
-}
 
+    /** Get an empty GraphPermissions instance. */
+    public GraphPermissions newGraphPermissions();
+}

src/test/java/com/marklogic/client/test/SemanticsPermissionsTest.java

@@ -107,7 +107,8 @@ public void C_testGetPermissions() throws Exception {
 
     @Test
     public void D_testWritePermissions() throws Exception {
-        GraphPermissions perms = gmgr.permission("read-privileged", Capability.EXECUTE);
+        GraphPermissions perms = gmgr.newGraphPermissions();
+        perms = perms.permission("read-privileged", Capability.EXECUTE);
         gmgr.writePermissions(graphUri, perms);
         GraphPermissions permissions = gmgr.getPermissions(graphUri);
         assertEquals(3, permissions.size());