Skip to content

Commit d6d999c

Browse files
committed
Removed TODO from code
1 parent c55a01c commit d6d999c

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

src/main/java/com/mapcode/Encoder.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ else if (mapcoderData.isNameless()) { // auto-pipe 21/22
155155
results.add(newResult);
156156
}
157157
else {
158-
// TODO: This should probably be simply an assertion instead.
159158
LOG.error("encode: Duplicate results found, newResult={}, results={} items",
160159
newResult.asInternationalISO(), results.size());
161160
}

src/test/java/com/mapcode/ReferenceFileTest.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -147,18 +147,14 @@ private void checkFile(@Nonnull final String baseFileName) throws Exception {
147147

148148
// Check the number of mapcodes.
149149

150-
// TODO: This check can only be enabled when the reference implementation and the
151-
// Java version produce exactly the same number of code. For now, we will only
152-
// log the offending mapcodes as errors in the log file, but not fail the test.
153-
//
154150
// Check the size and order of the results with a single assertion.
155151
//
156-
// assertEquals("Encode #" + i + " incorrect number of results:" +
157-
// "\n lat/lon = " + reference.point +
158-
// "\n expected = " + reference.mapcodes.size() + " results, " +
159-
// GSON.toJson(reference.mapcodes) +
160-
// "\n actual = " + results.size() + " results, " + GSON.toJson(results),
161-
// reference.mapcodes.size(), results.size());
152+
assertEquals("Encode #" + i + " incorrect number of results:" +
153+
"\n lat/lon = " + reference.point +
154+
"\n expected = " + reference.mapcodes.size() + " results, " +
155+
GSON.toJson(reference.mapcodes) +
156+
"\n actual = " + results.size() + " results, " + GSON.toJson(results),
157+
reference.mapcodes.size(), results.size());
162158

163159
// For every mapcode in the result set, check if it is contained in the reference set.
164160
for (final Mapcode result : results) {

0 commit comments

Comments
 (0)