Skip to content

Commit 1e8aabf

Browse files
2.1.5 minor change - removed unnecessary parameter
1 parent 82a4242 commit 1e8aabf

File tree

2 files changed

+10
-13
lines changed

2 files changed

+10
-13
lines changed

src/main/java/com/mapcode/Encoder.java

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,9 @@ static List<Mapcode> encode(
4242
final double latDeg,
4343
final double lonDeg,
4444
@Nullable final Territory territory,
45-
final boolean isRecursive,
46-
final boolean stopWithOneResult,
47-
final boolean allowWorld) {
45+
final boolean stopWithOneResult) {
4846

49-
return encode(latDeg, lonDeg, territory, stopWithOneResult, allowWorld, null);
47+
return encode(latDeg, lonDeg, territory, stopWithOneResult, null);
5048
}
5149

5250
// ----------------------------------------------------------------------
@@ -59,11 +57,10 @@ static List<Mapcode> encode(
5957
@SuppressWarnings("ConstantConditions")
6058
@Nonnull
6159
private static List<Mapcode> encode(final double argLatDeg, final double argLonDeg,
62-
@Nullable final Territory territory, final boolean limitToOneResult, final boolean allowWorld,
60+
@Nullable final Territory territory, final boolean limitToOneResult,
6361
@Nullable final Territory argStateOverride) {
64-
LOG.trace("encode: latDeg={}, lonDeg={}, territory={}, limitToOneResult={}, allowWorld={}",
65-
argLatDeg, argLonDeg, (territory == null) ? null : territory.name(), limitToOneResult,
66-
allowWorld);
62+
LOG.trace("encode: latDeg={}, lonDeg={}, territory={}, limitToOneResult={}",
63+
argLatDeg, argLonDeg, (territory == null) ? null : territory.name(), limitToOneResult);
6764

6865
final int ccode_earth = Territory.AAA.getNumber();
6966

@@ -74,7 +71,7 @@ private static List<Mapcode> encode(final double argLatDeg, final double argLonD
7471
int lastbasesubareaID = -1;
7572

7673
final int firstNr = (territory != null) ? territory.getNumber() : 0;
77-
final int lastNr = (territory != null) ? territory.getNumber() : (allowWorld ? ccode_earth : (ccode_earth-1) );
74+
final int lastNr = (territory != null) ? territory.getNumber() : ccode_earth;
7875
for (int ccode = firstNr; ccode <= lastNr; ccode++ ) {
7976

8077
final int upto = DataAccess.dataLastRecord(ccode);
@@ -91,9 +88,9 @@ private static List<Mapcode> encode(final double argLatDeg, final double argLonD
9188
mapcode = encodeNameless(pointToEncode, i, from);
9289
} else if (Data.recType(i) > 1) {
9390
mapcode = encodeAutoHeader(pointToEncode, i);
94-
} else if ((i == upto) && Data.isRestricted(i) && (currentEncodeTerritory.getParentTerritory() != null)) {
91+
} else if ((i == upto) && (currentEncodeTerritory.getParentTerritory() != null)) {
9592
results.addAll(encode(argLatDeg, argLonDeg, currentEncodeTerritory.getParentTerritory(), limitToOneResult,
96-
allowWorld, currentEncodeTerritory));
93+
currentEncodeTerritory));
9794
continue;
9895
} else if (!Data.isRestricted(i) || (lastbasesubareaID == from)) {
9996
if (Data.calcCodex(i) < 54) {

src/main/java/com/mapcode/MapcodeCodec.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public static List<Mapcode> encode(@Nonnull final Point point) throws IllegalArg
9393
public static List<Mapcode> encode(final double latDeg, final double lonDeg,
9494
@Nullable final Territory restrictToTerritory) throws IllegalArgumentException {
9595
// Call Mapcode encoder.
96-
final List<Mapcode> results = Encoder.encode(latDeg, lonDeg, restrictToTerritory, false, false, (restrictToTerritory == null));
96+
final List<Mapcode> results = Encoder.encode(latDeg, lonDeg, restrictToTerritory, /*shortest*/false);
9797
assert results != null;
9898
return results;
9999
}
@@ -122,7 +122,7 @@ public static Mapcode encodeToShortest(final double latDeg, final double lonDeg,
122122

123123
// Call mapcode encoder.
124124
@Nonnull final List<Mapcode> results =
125-
Encoder.encode(latDeg, lonDeg, restrictToTerritory, false, true, false);
125+
Encoder.encode(latDeg, lonDeg, restrictToTerritory, /*shortest*/true);
126126
assert results != null;
127127
assert results.size() <= 1;
128128
if (results.isEmpty()) {

0 commit comments

Comments
 (0)