find a solution for "assets" and "eo_bands" kwargs #7
Description
It is confusing and tedious always checking for both in all of these functions requiring it. Do we find a way to combine them into a bands or variables kwarg? The challenge here would be to decide which one (either asset name or eo_band) to use if there is a names collision.
We have to be careful because eo_bands is also a subset of assets, i.e. an eo_band is always (part of) an asset but an asset not necessarily is an eo_band. Also, an eo_band is always exaclty one band (I think) but an asset could contain more than one band. We don't cover the use case with an asset and multiple bands yet because we are using eo_bands when reading from the test PF data.
I suggest combining the two kwargs into one and then looking the eo_band/asset name hierarchically, i.e. first look whether there is an eo_band with that name and then looking at the asset names afterwards. This should cover our current use cases (Sentinel-2 from different archives and the PF use case) well for now.
There is still the question how we would name the new kwarg to replace eo_bands and assets:
bands: because it is a familiar concept with geospatial data; it could be also misleading because we can also add e.g. SCL as a band. Is this even a band?variables: because from thexarraynomenclature and more generic.