diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2ffb3e6f..bd67bcd1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,7 +12,7 @@ jobs: strategy: fail-fast: false matrix: - node-version: ['18.x', '20.x', 'lts/*'] + node-version: ['20.x', 'lts/*'] os: [macos-latest, ubuntu-latest, ubuntu-24.04-arm, windows-latest] runs-on: ${{ matrix.os }} steps: diff --git a/.github/workflows/s3-bucket.yml b/.github/workflows/s3-bucket.yml index 06df7c20..624f43b3 100644 --- a/.github/workflows/s3-bucket.yml +++ b/.github/workflows/s3-bucket.yml @@ -1,7 +1,10 @@ name: S3 Bucket Test on: + pull_request: push: + branches: + - master workflow_dispatch: jobs: @@ -10,7 +13,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, macos-latest, windows-latest] - node: [18, 20, 22] + node: [20, 'lts/*'] env: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} diff --git a/lib/mock/http.js b/lib/mock/http.js index eb2fd09b..b5625d8b 100644 --- a/lib/mock/http.js +++ b/lib/mock/http.js @@ -7,8 +7,7 @@ const path = require('path'); const nock = require('nock'); const os = require('os'); -const log = require('npmlog'); -log.disableProgress(); // disable the display of a progress bar +const log = require('../util/log.js'); log.heading = 'node-pre-gyp'; // differentiate node-pre-gyp's logs from npm's function http_mock() { @@ -17,6 +16,7 @@ function http_mock() { const basePath = `${os.tmpdir()}/mock`; nock(new RegExp('([a-z0-9]+[.])*s3[.]us-east-1[.]amazonaws[.]com')) + .persist() .get(() => true) //a function that always returns true is a catch all for nock .reply( (uri) => { diff --git a/lib/mock/s3.js b/lib/mock/s3.js index 076b995b..e485e3bd 100644 --- a/lib/mock/s3.js +++ b/lib/mock/s3.js @@ -5,8 +5,7 @@ module.exports = exports = s3_mock; const AWSMock = require('mock-aws-s3'); const os = require('os'); -const log = require('npmlog'); -log.disableProgress(); // disable the display of a progress bar +const log = require('../util/log.js'); log.heading = 'node-pre-gyp'; // differentiate node-pre-gyp's logs from npm's function s3_mock() { diff --git a/package-lock.json b/package-lock.json index 6515d46f..43cf6bd8 100644 --- a/package-lock.json +++ b/package-lock.json @@ -32,7 +32,7 @@ "node-addon-api": "^8.1.0", "nyc": "^17.0.0", "tape": "^5.5.2", - "tar-fs": "^3.0.6" + "tar-fs": "^3.0.8" }, "engines": { "node": ">=18"