Skip to content

Commit bbfd7b2

Browse files
committed
Fixing issue 647
- Updated abi_crosswalk.json to include node 18 (current). - Added test coverage for cases of unsupported/unknown targets.
1 parent eb1ec94 commit bbfd7b2

2 files changed

Lines changed: 136 additions & 0 deletions

File tree

lib/util/abi_crosswalk.json

Lines changed: 116 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2231,6 +2231,26 @@
22312231
"node_abi": 72,
22322232
"v8": "7.8"
22332233
},
2234+
"12.22.8": {
2235+
"node_abi": 72,
2236+
"v8": "7.8"
2237+
},
2238+
"12.22.9": {
2239+
"node_abi": 72,
2240+
"v8": "7.8"
2241+
},
2242+
"12.22.10": {
2243+
"node_abi": 72,
2244+
"v8": "7.8"
2245+
},
2246+
"12.22.11": {
2247+
"node_abi": 72,
2248+
"v8": "7.8"
2249+
},
2250+
"12.22.12": {
2251+
"node_abi": 72,
2252+
"v8": "7.8"
2253+
},
22342254
"13.0.0": {
22352255
"node_abi": 79,
22362256
"v8": "7.8"
@@ -2435,6 +2455,26 @@
24352455
"node_abi": 83,
24362456
"v8": "8.4"
24372457
},
2458+
"14.18.2": {
2459+
"node_abi": 83,
2460+
"v8": "8.4"
2461+
},
2462+
"14.18.3": {
2463+
"node_abi": 83,
2464+
"v8": "8.4"
2465+
},
2466+
"14.19.0": {
2467+
"node_abi": 83,
2468+
"v8": "8.4"
2469+
},
2470+
"14.19.1": {
2471+
"node_abi": 83,
2472+
"v8": "8.4"
2473+
},
2474+
"14.19.2": {
2475+
"node_abi": 83,
2476+
"v8": "8.4"
2477+
},
24382478
"15.0.0": {
24392479
"node_abi": 88,
24402480
"v8": "8.6"
@@ -2587,6 +2627,30 @@
25872627
"node_abi": 93,
25882628
"v8": "9.4"
25892629
},
2630+
"16.13.1": {
2631+
"node_abi": 93,
2632+
"v8": "9.4"
2633+
},
2634+
"16.13.2": {
2635+
"node_abi": 93,
2636+
"v8": "9.4"
2637+
},
2638+
"16.14.0": {
2639+
"node_abi": 93,
2640+
"v8": "9.4"
2641+
},
2642+
"16.14.1": {
2643+
"node_abi": 93,
2644+
"v8": "9.4"
2645+
},
2646+
"16.14.2": {
2647+
"node_abi": 93,
2648+
"v8": "9.4"
2649+
},
2650+
"16.15.0": {
2651+
"node_abi": 93,
2652+
"v8": "9.4"
2653+
},
25902654
"17.0.0": {
25912655
"node_abi": 102,
25922656
"v8": "9.5"
@@ -2598,5 +2662,57 @@
25982662
"17.1.0": {
25992663
"node_abi": 102,
26002664
"v8": "9.5"
2665+
},
2666+
"17.2.0": {
2667+
"node_abi": 102,
2668+
"v8": "9.6"
2669+
},
2670+
"17.3.0": {
2671+
"node_abi": 102,
2672+
"v8": "9.6"
2673+
},
2674+
"17.3.1": {
2675+
"node_abi": 102,
2676+
"v8": "9.6"
2677+
},
2678+
"17.4.0": {
2679+
"node_abi": 102,
2680+
"v8": "9.6"
2681+
},
2682+
"17.5.0": {
2683+
"node_abi": 102,
2684+
"v8": "9.6"
2685+
},
2686+
"17.6.0": {
2687+
"node_abi": 102,
2688+
"v8": "9.6"
2689+
},
2690+
"17.7.0": {
2691+
"node_abi": 102,
2692+
"v8": "9.6"
2693+
},
2694+
"17.7.1": {
2695+
"node_abi": 102,
2696+
"v8": "9.6"
2697+
},
2698+
"17.7.2": {
2699+
"node_abi": 102,
2700+
"v8": "9.6"
2701+
},
2702+
"17.8.0": {
2703+
"node_abi": 102,
2704+
"v8": "9.6"
2705+
},
2706+
"17.9.0": {
2707+
"node_abi": 102,
2708+
"v8": "9.6"
2709+
},
2710+
"18.0.0": {
2711+
"node_abi": 108,
2712+
"v8": "10.1"
2713+
},
2714+
"18.1.0": {
2715+
"node_abi": 108,
2716+
"v8": "10.1"
26012717
}
26022718
}

test/versioning.test.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,26 @@ test('should detect abi for node-webkit runtime', (t) => {
9090
t.end();
9191
});
9292

93+
test('should throw when custom node target is not found in abi_crosswalk file', (t) => {
94+
try {
95+
versioning.get_runtime_abi('node', '123456789.0.0');
96+
} catch (e) {
97+
const expectedMessage = 'Unsupported target version: 123456789.0.0';
98+
t.equal(e.message, expectedMessage);
99+
t.end();
100+
}
101+
});
102+
103+
test('should throw when custom node target is not semver', (t) => {
104+
try {
105+
versioning.get_runtime_abi('node', '1.2.3.4');
106+
} catch (e) {
107+
const expectedMessage = 'Unknown target version: 1.2.3.4';
108+
t.equal(e.message, expectedMessage);
109+
t.end();
110+
}
111+
});
112+
93113
test('should detect custom binary host from env', (t) => {
94114
const mock_package_json = {
95115
'name': 'test',

0 commit comments

Comments
 (0)