Fix credo warnings

lib/langfuse/client.ex

@@ -999,9 +999,7 @@ defmodule Langfuse.Client do
   def delete(path) do
     config = Config.get()
 
-    unless Config.configured?() do
-      {:error, :not_configured}
-    else
+    if Config.configured?() do
       url = config.host <> path
 
       case Req.delete(url, auth: {:basic, "#{config.public_key}:#{config.secret_key}"}) do
@@ -1014,6 +1012,8 @@ defmodule Langfuse.Client do
         {:error, reason} ->
           {:error, reason}
       end
+    else
+      {:error, :not_configured}
     end
   end
 
@@ -1030,9 +1030,7 @@ defmodule Langfuse.Client do
   def patch(path, body) do
     config = Config.get()
 
-    unless Config.configured?() do
-      {:error, :not_configured}
-    else
+    if Config.configured?() do
       url = config.host <> path
 
       case Req.patch(url,
@@ -1048,6 +1046,8 @@ defmodule Langfuse.Client do
         {:error, reason} ->
           {:error, reason}
       end
+    else
+      {:error, :not_configured}
     end
   end
 

lib/langfuse/event.ex

@@ -29,7 +29,7 @@ defmodule Langfuse.Event do
 
   """
 
-  alias Langfuse.{Ingestion, Trace, Span}
+  alias Langfuse.{Ingestion, Span, Trace}
 
   @typedoc "Log level for the observation."
   @type level :: :debug | :default | :warning | :error

lib/langfuse/generation.ex

@@ -58,7 +58,7 @@ defmodule Langfuse.Generation do
 
   """
 
-  alias Langfuse.{Ingestion, Trace, Span}
+  alias Langfuse.{Ingestion, Span, Trace}
 
   @typedoc "Log level for the observation."
   @type level :: :debug | :default | :warning | :error

lib/langfuse/http.ex

@@ -112,10 +112,10 @@ defmodule Langfuse.HTTP do
   def get(path, params \\ []) do
     config = Config.get()
 
-    unless Config.configured?() do
-      {:error, :not_configured}
-    else
+    if Config.configured?() do
       request(:get, path, config, params: params)
+    else
+      {:error, :not_configured}
     end
   end
 
@@ -129,10 +129,10 @@ defmodule Langfuse.HTTP do
   def post(path, body) do
     config = Config.get()
 
-    unless Config.configured?() do
-      {:error, :not_configured}
-    else
+    if Config.configured?() do
       request(:post, path, config, json: body)
+    else
+      {:error, :not_configured}
     end
   end
 

lib/langfuse/open_telemetry.ex

@@ -122,7 +122,7 @@ defmodule Langfuse.OpenTelemetry do
 
   """
 
-  alias Langfuse.OpenTelemetry.{AttributeMapper, TraceContext, Setup}
+  alias Langfuse.OpenTelemetry.{AttributeMapper, Setup, TraceContext}
 
   @doc """
   Extracts trace and span IDs from an OpenTelemetry span context.

lib/langfuse/open_telemetry/setup.ex

@@ -206,13 +206,11 @@ defmodule Langfuse.OpenTelemetry.Setup do
   end
 
   defp safe_get_tracer_provider do
-    try do
-      :otel_tracer_provider.resource()
-      true
-    rescue
-      _ -> false
-    catch
-      _, _ -> false
-    end
+    :otel_tracer_provider.resource()
+    true
+  rescue
+    _ -> false
+  catch
+    _, _ -> false
   end
 end

lib/langfuse/open_telemetry/span_processor.ex

@@ -61,8 +61,8 @@ defmodule Langfuse.OpenTelemetry.SpanProcessor do
 
   @behaviour :otel_span_processor
 
-  alias Langfuse.OpenTelemetry.AttributeMapper
   alias Langfuse.Ingestion
+  alias Langfuse.OpenTelemetry.AttributeMapper
 
   @typedoc "Processor configuration options."
   @type config :: %{
@@ -119,7 +119,7 @@ defmodule Langfuse.OpenTelemetry.SpanProcessor do
     parent_span_id_hex = format_span_id(parent_span_id)
 
     mapped_attrs = AttributeMapper.map_attributes(attributes)
-    is_generation = is_generation?(attributes, mapped_attrs)
+    is_generation = generation?(attributes, mapped_attrs)
     is_root = is_nil(parent_span_id) or parent_span_id == 0
 
     if is_root do
@@ -170,7 +170,7 @@ defmodule Langfuse.OpenTelemetry.SpanProcessor do
 
   defp normalize_span(_), do: nil
 
-  defp is_generation?(attributes, mapped_attrs) do
+  defp generation?(attributes, mapped_attrs) do
     Map.has_key?(mapped_attrs, :model) or
       has_genai_attribute?(attributes)
   end

lib/langfuse/prompt.ex

@@ -365,19 +365,15 @@ defmodule Langfuse.Prompt do
   end
 
   defp delete_cache_key(key) do
-    try do
-      :ets.delete(:langfuse_prompt_cache, key)
-    rescue
-      ArgumentError -> :ok
-    end
+    :ets.delete(:langfuse_prompt_cache, key)
+  rescue
+    ArgumentError -> :ok
   end
 
   defp delete_cache_by_name(name) do
-    try do
-      :ets.match_delete(:langfuse_prompt_cache, {{name, :_, :_}, :_, :_})
-    rescue
-      ArgumentError -> :ok
-    end
+    :ets.match_delete(:langfuse_prompt_cache, {{name, :_, :_}, :_, :_})
+  rescue
+    ArgumentError -> :ok
   end
 
   defp get_cached(key) do

lib/langfuse/score.ex

@@ -48,7 +48,7 @@ defmodule Langfuse.Score do
 
   """
 
-  alias Langfuse.{Ingestion, Trace, Span, Generation}
+  alias Langfuse.{Generation, Ingestion, Span, Trace}
 
   @typedoc "Score data type classification."
   @type data_type :: :numeric | :categorical | :boolean

test/langfuse/error_test.exs

@@ -1,7 +1,7 @@
 defmodule Langfuse.ErrorTest do
   use ExUnit.Case, async: true
 
-  alias Langfuse.Error.{ConfigError, APIError, ValidationError, PromptNotFoundError}
+  alias Langfuse.Error.{APIError, ConfigError, PromptNotFoundError, ValidationError}
 
   describe "ConfigError" do
     test "message with key and custom message" do

test/langfuse/event_test.exs

@@ -1,7 +1,7 @@
 defmodule Langfuse.EventTest do
   use ExUnit.Case, async: true
 
-  alias Langfuse.{Event, Trace, Span}
+  alias Langfuse.{Event, Span, Trace}
 
   describe "new/2" do
     test "creates an event from a trace" do

test/langfuse/generation_test.exs

@@ -1,7 +1,8 @@
 defmodule Langfuse.GenerationTest do
   use ExUnit.Case, async: false
 
-  alias Langfuse.{Generation, Trace, Span}
+  alias Langfuse.{Generation, Span, Trace}
+  alias Langfuse.Test.Helpers
 
   describe "new/2" do
     test "creates a generation from a trace" do
@@ -139,7 +140,7 @@ defmodule Langfuse.GenerationTest do
   describe "event capture" do
     test "new/2 sends generation-create event" do
       {_gen, events} =
-        Langfuse.Test.Helpers.capture_events(fn ->
+        Helpers.capture_events(fn ->
           trace = Trace.new(name: "test-trace")
           Generation.new(trace, name: "llm-call", model: "gpt-4")
         end)
@@ -152,7 +153,7 @@ defmodule Langfuse.GenerationTest do
 
     test "update/2 sends generation-update event" do
       {_gen, events} =
-        Langfuse.Test.Helpers.capture_events(fn ->
+        Helpers.capture_events(fn ->
           trace = Trace.new(name: "test-trace")
           gen = Generation.new(trace, name: "llm-call")
           Generation.update(gen, output: %{content: "response"})
@@ -165,7 +166,7 @@ defmodule Langfuse.GenerationTest do
 
     test "end_generation/1 sends generation-update event with end_time" do
       {_gen, events} =
-        Langfuse.Test.Helpers.capture_events(fn ->
+        Helpers.capture_events(fn ->
           trace = Trace.new(name: "test-trace")
           gen = Generation.new(trace, name: "llm-call")
           Generation.end_generation(gen)
@@ -178,7 +179,7 @@ defmodule Langfuse.GenerationTest do
 
     test "events include required fields" do
       {_gen, events} =
-        Langfuse.Test.Helpers.capture_events(fn ->
+        Helpers.capture_events(fn ->
           trace = Trace.new(name: "test-trace")
           Generation.new(trace, name: "llm-call")
         end)

test/langfuse/score_test.exs

@@ -1,7 +1,7 @@
 defmodule Langfuse.ScoreTest do
   use ExUnit.Case, async: false
 
-  alias Langfuse.{Score, Trace, Span, Generation}
+  alias Langfuse.{Generation, Score, Span, Trace}
   import Langfuse.Test.Helpers
 
   describe "create/2" do