build(deps): add wrap files for 'scenefx' and 'wlroots'#948
Open
euletheia wants to merge 1 commit into
Open
Conversation
DreamMaoMao
force-pushed
the
main
branch
2 times, most recently
from
c009ba2 to
f328c27
Compare
euletheia
force-pushed
the
main
branch
3 times, most recently
from
5baa76b to
bde9efc
Compare
Allows meson to fallback on fetching and building these projects in case they are not available/out-of-date on the system (can be avoided by passing '--wrap-mode=nofallback' to 'meson setup').
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This allows meson to automatically fallback on fetching and building these projects in case they are not available/out-of-date on the system.
Fallback can still be avoided by passing
--wrap-mode=nofallbacktomeson setup.Why
I am building Mango on Debian Testing and (in my opinion) the wrap files make the process cleaner and quicker.
The only drawback I can think of is that versions and names of these dependencies now need to be declared in two files and kept in sync (in
meson.buildand in the corresponding*.wrapfile).This is only a simple suggestion (I am not an expert), and I hope I am not creating too much noise.1
Footnotes
edited since I ended up including the
fallbackparameter inmeson.buildfor better clarity. ↩