Enable Roslyn analyzers for OmniSharp in VScode

Author: manandre

.vscode/settings.json

@@ -1,4 +1,5 @@
 {
+    "omnisharp.enableRoslynAnalyzers": true,
     "dotnet-test-explorer.autoExpandTree": true,
     "dotnet-test-explorer.autoWatch": true,
     "dotnet-test-explorer.testProjectPath": "**/*Tests.csproj",

FollowingFileStream.ConsoleTestTool/FollowingFileStream.ConsoleTestTool.csproj

@@ -7,7 +7,7 @@
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFrameworks>netcoreapp3.0;netcoreapp2.2</TargetFrameworks>
-    <LangVersion>7.1</LangVersion>
+    <LangVersion>8.0</LangVersion>
     <IsPackable>false</IsPackable>
     <noWarn>SA0001</noWarn>
   </PropertyGroup>

FollowingFileStream.ConsoleTestTool/Program.cs

@@ -11,11 +11,18 @@ namespace Manandre.IO
     using System.IO;
     using System.Threading.Tasks;
 
+    /// <summary>
+    /// Console test tool.
+    /// </summary>
     internal static class Program
     {
         private const string InputPath = "source.txt";
         private const string OutputPath = "destination.txt";
 
+        /// <summary>
+        /// Main routine.
+        /// </summary>
+        /// <returns>A task representing the main operation.</returns>
         public static async Task Main()
         {
             var input = WriteInput().ConfigureAwait(false);
@@ -25,20 +32,16 @@ public static async Task Main()
 
         private static async Task WriteInput()
         {
-            using (var sw = new StreamWriter(new FileStream(InputPath, FileMode.Create, FileAccess.Write, FileShare.Read)))
-            using (var sr = new StreamReader(Console.OpenStandardInput()))
-            {
-                await sr.CopyToAsync(sw, stopOn: "quit").ConfigureAwait(false);
-            }
+            using var sw = new StreamWriter(new FileStream(InputPath, FileMode.Create, FileAccess.Write, FileShare.Read));
+            using var sr = new StreamReader(Console.OpenStandardInput());
+            await sr.CopyToAsync(sw, stopOn: "quit").ConfigureAwait(false);
         }
 
         private static async Task CopyToOutput()
         {
-            using (var source = new FollowingFileStream(InputPath))
-            using (var destination = new FileStream(OutputPath, FileMode.Create, FileAccess.Write, FileShare.Read))
-            {
-                await source.CopyToAsync(destination).ConfigureAwait(false);
-            }
+            using var source = new FollowingFileStream(InputPath);
+            using var destination = new FileStream(OutputPath, FileMode.Create, FileAccess.Write, FileShare.Read);
+            await source.CopyToAsync(destination).ConfigureAwait(false);
         }
     }
 }

FollowingFileStream.ConsoleTestTool/TextReaderExtensions.cs

@@ -10,11 +10,21 @@ namespace Manandre.IO
     using System.IO;
     using System.Threading.Tasks;
 
+    /// <summary>
+    /// Extension methods for the <see cref="TextReader"/> class.
+    /// </summary>
     internal static class TextReaderExtensions
     {
+        /// <summary>
+        /// Copy lines from reader to writer until a specific string is reached.
+        /// </summary>
+        /// <param name="reader">A text reader to read from.</param>
+        /// <param name="writer">A text writer to write to.</param>
+        /// <param name="stopOn">A string on which to stop copying.</param>
+        /// <returns>A task representing the copy operation.</returns>
         public static async Task CopyToAsync(this TextReader reader, TextWriter writer, string stopOn)
         {
-            string line = string.Empty;
+            string line;
             while ((line = await reader.ReadLineAsync().ConfigureAwait(false)) != stopOn)
             {
                 await writer.WriteLineAsync(line).ConfigureAwait(false);

FollowingFileStream.Tests/AsyncStreamTest.cs

@@ -14,9 +14,15 @@ namespace Manandre.IO
     using Microsoft.VisualStudio.TestTools.UnitTesting;
     using Moq;
 
+    /// <summary>
+    /// Test class for AsyncStream.
+    /// </summary>
     [TestClass]
     public class AsyncStreamTest
     {
+        /// <summary>
+        /// Test AsyncStream read operations.
+        /// </summary>
         [TestMethod]
         public void ASRead()
         {
@@ -31,6 +37,9 @@ public void ASRead()
             Assert.AreEqual(expected, read);
         }
 
+        /// <summary>
+        /// Test AsyncStream write operations.
+        /// </summary>
         [TestMethod]
         public void ASWrite()
         {
@@ -44,6 +53,9 @@ public void ASWrite()
             sut.Verify(x => x.WriteAsync(It.IsAny<byte[]>(), It.IsAny<int>(), It.IsAny<int>(), It.IsAny<CancellationToken>()), Times.Exactly(2));
         }
 
+        /// <summary>
+        /// Test AsyncStream flush operations.
+        /// </summary>
         [TestMethod]
         public void ASFlush()
         {
@@ -53,6 +65,9 @@ public void ASFlush()
             sut.Verify(x => x.FlushAsync(It.IsAny<CancellationToken>()), Times.Once);
         }
 
+        /// <summary>
+        /// Test AsyncStream dispose operations.
+        /// </summary>
         [TestMethod]
         public void ASDispose()
         {
@@ -61,6 +76,9 @@ public void ASDispose()
             sut.Object.Dispose();
         }
 
+        /// <summary>
+        /// Test AsyncStream synchronized operations.
+        /// </summary>
         [TestMethod]
         public void ASSynchronized()
         {

FollowingFileStream.Tests/FollowingFileStream.Tests.csproj

@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFrameworks>netcoreapp3.0;netcoreapp2.2</TargetFrameworks>
+    <LangVersion>8.0</LangVersion>
     <IsPackable>false</IsPackable>
     <noWarn>SA0001</noWarn>
   </PropertyGroup>