tweak memory extraction

Author: makefinks

src/ai/daemon-ai.ts

@@ -21,6 +21,8 @@ import type {
 	ToolApprovalRequest,
 	ToolApprovalResponse,
 	TranscriptionResult,
+	MemoryToastPreview,
+	MemoryToastOperation,
 } from "../types";
 import { debug, toolDebug } from "../utils/debug-logger";
 import { getOpenRouterReportedCost } from "../utils/openrouter-reported-cost";
@@ -332,11 +334,12 @@ async function persistConversationMemory(
 	if (!memoryManager.isAvailable) return null;
 
 	try {
+		const memoryMessages = [
+			{ role: "user", content: `<user>${userTextForMemory}</user>` },
+			{ role: "assistant", content: `<assistant>${assistantTextForMemory}</assistant>` },
+		];
 		const result = await memoryManager.add(
-			[
-				{ role: "user", content: userTextForMemory },
-				{ role: "assistant", content: assistantTextForMemory },
-			],
+			memoryMessages,
 			{
 				timestamp: new Date().toISOString(),
 				source: "conversation",
@@ -353,20 +356,25 @@ async function persistConversationMemory(
 
 function buildMemoryToastPreview(
 	results: Array<{ memory: string; event: "ADD" | "UPDATE" | "DELETE" | "NONE" }>
-): string | null {
+): MemoryToastPreview | null {
 	if (results.length === 0) return null;
 
-	let saved = results.filter((entry) => entry.event === "ADD" || entry.event === "UPDATE");
-	if (saved.length === 0) {
-		saved = results.filter((entry) => entry.memory.trim().length > 0);
-		if (saved.length === 0) return null;
-	}
+	const saved = results.filter((entry) => entry.event === "ADD" || entry.event === "UPDATE");
+	if (saved.length === 0) return null;
 
-	const lines = saved.slice(0, 2).map((entry) => `• ${truncatePreview(entry.memory, 52)}`);
-	if (saved.length > 2) {
-		lines.push(`• +${saved.length - 2} more`);
+	const previewEntries = saved.length > 2 ? saved.slice(-2) : saved;
+	const lines = previewEntries.map((entry) => `• ${truncatePreview(entry.memory, 52)}`);
+	if (saved.length > previewEntries.length) {
+		lines.push(`• +${saved.length - previewEntries.length} more`);
 	}
-	return lines.join("\n");
+
+	const hasUpdate = saved.some((entry) => entry.event === "UPDATE");
+	const operation: MemoryToastOperation = hasUpdate ? "UPDATE" : "ADD";
+
+	return {
+		operation,
+		description: lines.join("\n"),
+	};
 }
 
 function truncatePreview(text: string, maxChars: number): string {

src/ai/memory/memory-manager.ts

@@ -107,18 +107,71 @@ class MemoryManager {
 
 			this.memory = new Memory({
 				version: "v1.1",
-				customPrompt: `You are a minimal memory extractor. You will be given a user message and an assistant message. Only extract durable, user-specific facts that remain true over time for personalization.
+				customPrompt: `You are a Personal Information Organizer, specialized in extracting **enduring** facts, user memories, and preferences.
+Your role is to extract **only** information that would be useful to recall in a conversation two weeks from now.
+
+# [IMPORTANT]: GENERATE FACTS SOLELY BASED ON THE USER'S MESSAGES.
+# [IMPORTANT]: DO NOT INCLUDE INFORMATION FROM ASSISTANT OR SYSTEM MESSAGES.
+
+### WHAT TO STORE (The "Two-Week Test"):
+1. **Biographical Details:** Names, age, job title, company, location.
+2. **Relationships:** Names of partners, family members, pets, or colleagues.
+3. **Enduring Preferences:** Strong likes/dislikes (e.g., food, hobbies, style).
+4. **Long-term Plans:** Upcoming trips, long-term projects, or goals.
+5. **Direct Instructions:** How the user wants to be addressed or formatted (e.g., "Call me X").
+6. **Multi-True Facts:** If multiple preferences or details can all be true (e.g., likes multiple languages, foods, hobbies), store each as a separate fact rather than updating/overwriting an existing one.
+
+### WHAT TO IGNORE (Do NOT store these):
+1. **Transient Commands & Questions:** Do not store that the user asked to "summarize a PDF," "translate a sentence," or "write code."
+2. **Immediate Context:** Do not store "User said 'continue'" or "User said 'yes'."
+3. **General Opinions on News/Politics:** Unless the user explicitly identifies with a stance, avoid summarizing general questions (e.g., ignore "What is the capital of France?").
+4. **Meta-Commentary:** Do not store compliments or insults to the bot (e.g., "You are smart") unless it alters how you should behave.
+
+### Examples:
+
+User: Hi there.
+Assistant: Hello! How can I help you today?
+Output: {{"facts" : []}}
+
+User: Can you summarize this article for me?
+Assistant: Sure, please paste the text.
+Output: {{"facts" : []}}
+(Reasoning: This is a transient task, not a fact about the user.)
+
+User: I am a vegetarian, so please don't suggest any meat dishes.
+Assistant: Noted, I will provide vegetarian options only.
+Output: {{"facts" : ["Is a vegetarian", "Does not eat meat"]}}
+
+User: I'm planning a hiking trip to Patagonia next November.
+Assistant: That sounds amazing!
+Output: {{"facts" : ["Planning a hiking trip to Patagonia in November"]}}
+
+User: Who is the president of the US?
+Assistant: The current president is...
+Output: {{"facts" : []}}
+
+User: My dog's name is Buster. He's a golden retriever.
+Assistant: Buster sounds adorable.
+Output: {{"facts" : ["Has a dog named Buster", "Dog is a golden retriever"]}}
+
+User: Actually, I moved. I live in Chicago now, not New York.
+Assistant: Got it, updated your location.
+Output: {{"facts" : ["Lives in Chicago", "No longer lives in New York"]}}
+
+User: I hate Python, I prefer coding in Rust.
+Assistant: Understood.
+Output: {{"facts" : ["Dislikes Python", "Prefers coding in Rust"]}}
+
+User: test
+Assistant: System operational.
+Output: {{"facts" : []}}
+
+Return the facts in JSON format as shown above.
 
 Rules:
-- Focus on stable preferences, long-term plans, personal details, or recurring constraints.
-- Ignore the assistant's suggestions, analysis, and any transient task details.
-- Do not store one-off requests, instructions about the current task, or tool/implementation details.
-- Do not store anything that is not explicitly stated by the user.
-- Store memories in third person: "The user is.../The User has..."
-- If nothing qualifies, return an empty list.
-- Output must be JSON: {"facts": ["..."]}
-
-Return only JSON with a facts array.`,
+- If no *enduring* facts are found, return an empty list for "facts".
+- Detect the language of the user input and record facts in that same language.
+- Write fully self-contained facts (e.g., "Lives in Chicago" instead of "Lives there").`,
 				embedder: {
 					provider: "openai",
 					config: {

src/ai/model-config.ts

@@ -84,11 +84,11 @@ export function buildOpenRouterChatSettings(
 		},
 		...(currentOpenRouterProviderTag
 			? {
-					provider: {
-						order: [currentOpenRouterProviderTag],
-						allow_fallbacks: false,
-					},
-				}
+				provider: {
+					order: [currentOpenRouterProviderTag],
+					allow_fallbacks: false,
+				},
+			}
 			: {}),
 		...(overrides ?? {}),
 	};
@@ -100,7 +100,7 @@ export function buildOpenRouterChatSettings(
 export const TRANSCRIPTION_MODEL = "gpt-4o-mini-transcribe-2025-12-15";
 
 // Default model for memory operations (cheap & fast)
-export const DEFAULT_MEMORY_MODEL = "deepseek/deepseek-v3.2";
+export const DEFAULT_MEMORY_MODEL = "x-ai/grok-4.1-fast";
 
 /**
  * Get the model ID for memory operations (deduplication, extraction).

src/hooks/daemon-event-handlers.ts

@@ -12,6 +12,7 @@ import { saveSessionSnapshot } from "../state/session-store";
 import type {
 	ContentBlock,
 	ConversationMessage,
+	MemoryToastPreview,
 	ModelMessage,
 	SubagentStep,
 	TokenUsage,
@@ -57,9 +58,10 @@ function clearAvatarToolEffects(avatar: DaemonAvatarRenderable | null): void {
 }
 
 export function createMemorySavedHandler() {
-	return (preview: string) => {
-		if (!preview.trim()) return;
-		toast.success("Memory saved", { description: preview });
+	return (preview: MemoryToastPreview) => {
+		const description = preview.description?.trim();
+		if (!description) return;
+		toast.success(`Memory saved (${preview.operation})`, { description });
 	};
 }
 

src/state/daemon-events.ts

@@ -1,6 +1,7 @@
 import { EventEmitter } from "node:events";
 
 import type {
+	MemoryToastPreview,
 	ModelMessage,
 	TokenUsage,
 	ToolCallStatus,
@@ -32,7 +33,7 @@ export type DaemonStateEvents = {
 	subagentComplete: (toolCallId: string, success: boolean) => void;
 	responseToken: (token: string) => void;
 	stepUsage: (usage: TokenUsage) => void;
-	memorySaved: (preview: string) => void;
+	memorySaved: (preview: MemoryToastPreview) => void;
 	responseComplete: (fullText: string, responseMessages: ModelMessage[], usage?: TokenUsage) => void;
 	userMessage: (text: string) => void;
 	speakingStart: () => void;

src/types/index.ts

@@ -169,7 +169,7 @@ export interface StreamCallbacks {
 	onSubagentToolResult?: (toolCallId: string, toolName: string, success: boolean) => void;
 	onSubagentComplete?: (toolCallId: string, success: boolean) => void;
 	onStepUsage?: (usage: TokenUsage) => void;
-	onMemorySaved?: (preview: string) => void;
+	onMemorySaved?: (preview: MemoryToastPreview) => void;
 	onComplete?: (
 		fullText: string,
 		responseMessages: ModelMessage[],
@@ -180,6 +180,13 @@ export interface StreamCallbacks {
 	onError?: (error: Error) => void;
 }
 
+export type MemoryToastOperation = "ADD" | "UPDATE" | "ADD/UPDATE";
+
+export interface MemoryToastPreview {
+	operation: MemoryToastOperation;
+	description: string;
+}
+
 /**
  * Audio device information
  */