AC-6974::Cloud Native S3 Web API test Failures -2.4-develop - Fixed GraphQL testCacheIdHeaderWithCurrency Test

Author: rimple-saini

app/code/Magento/GraphQlCache/Setup/ConfigOptionsList.php

@@ -20,14 +20,22 @@
  */
 class ConfigOptionsList implements ConfigOptionsListInterface
 {
+    /**
+     * Input key for the option
+     */
+    private const INPUT_KEY_SALT = 'id_salt';
+
+    /**
+     * Path to the value in the deployment config
+     */
+    private const CONFIG_PATH_SALT = 'cache/graphql/id_salt';
+
     /**
      * @var Random
      */
     private $random;
 
     /**
-     * Deployment configuration
-     *
      * @var DeploymentConfig
      */
     private $deploymentConfig;
@@ -51,9 +59,9 @@ public function getOptions(): array
     {
         return [
             new TextConfigOption(
-                ConfigOptionsListConstants::INPUT_KEY_SALT,
+                self::INPUT_KEY_SALT,
                 TextConfigOption::FRONTEND_WIZARD_TEXT,
-                ConfigOptionsListConstants::CONFIG_PATH_SALT,
+                self::CONFIG_PATH_SALT,
                 'GraphQl Salt'
             ),
         ];
@@ -65,17 +73,17 @@ public function getOptions(): array
      */
     public function createConfig(array $data, DeploymentConfig $deploymentConfig)
     {
-        $currentIdSalt = $this->deploymentConfig->get(ConfigOptionsListConstants::CONFIG_PATH_SALT);
+        $currentIdSalt = $this->deploymentConfig->get(self::CONFIG_PATH_SALT);
 
         $configData = new ConfigData(ConfigFilePool::APP_ENV);
 
         // Use given salt if set, else use current
-        $id_salt = $data[ConfigOptionsListConstants::INPUT_KEY_SALT] ?? $currentIdSalt;
+        $id_salt = $data[self::INPUT_KEY_SALT] ?? $currentIdSalt;
 
         // If there is no salt given or currently set, generate a new one
         $id_salt = $id_salt ?? $this->random->getRandomString(ConfigOptionsListConstants::STORE_KEY_RANDOM_STRING_SIZE);
 
-        $configData->set(ConfigOptionsListConstants::CONFIG_PATH_SALT, $id_salt);
+        $configData->set(self::CONFIG_PATH_SALT, $id_salt);
 
         return [$configData];
     }

lib/internal/Magento/Framework/Config/ConfigOptionsListConstants.php

@@ -40,7 +40,6 @@ class ConfigOptionsListConstants
     public const CONFIG_PATH_DB_LOGGER_LOG_EVERYTHING = 'db_logger/log_everything';
     public const CONFIG_PATH_DB_LOGGER_QUERY_TIME_THRESHOLD = 'db_logger/query_time_threshold';
     public const CONFIG_PATH_DB_LOGGER_INCLUDE_STACKTRACE = 'db_logger/include_stacktrace';
-    public const CONFIG_PATH_SALT = 'cache/graphql/id_salt';
     /**#@-*/
 
     /**
@@ -86,7 +85,6 @@ class ConfigOptionsListConstants
     public const INPUT_KEY_RESOURCE = 'resource';
     public const INPUT_KEY_SKIP_DB_VALIDATION = 'skip-db-validation';
     public const INPUT_KEY_CACHE_HOSTS = 'http-cache-hosts';
-    public const INPUT_KEY_SALT = 'id_salt';
     /**#@-*/
 
     /**#@+