MQE-2669: bin/mftf run:failed process used a lot of RAM

- Added simple unit test to test configuration generator

Author: KevinBKozan

dev/tests/unit/Magento/FunctionalTestFramework/Console/GenerateTestFailedCommandTest.php

@@ -0,0 +1,41 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace tests\unit\Magento\FunctionalTestFramework\Console;
+
+use Magento\FunctionalTestingFramework\Console\GenerateTestFailedCommand;
+use Magento\FunctionalTestingFramework\Test\Objects\TestObject;
+use PHPUnit\Framework\MockObject\MockBuilder;
+use PHPUnit\Framework\TestCase;
+use Magento\FunctionalTestingFramework\Exceptions\FastFailException;
+use Magento\FunctionalTestingFramework\Console\GenerateTestsCommand;
+use ReflectionClass;
+
+class GenerateTestFailedCommandTest extends BaseGenerateCommandTest
+{
+    public function testSingleTestNoSuite(): void
+    {
+        $testFileReturn = [
+            "tests/functional/tests/MFTF/_generated/default/SingleTestNoSuiteTest.php:SingleTestNoSuiteTest"
+        ];
+        $expectedConfiguration = '{"tests":["SingleTestNoSuiteTest"],"suites":null}';
+
+        // Create a stub for the SomeClass class.
+        $stub = $this->getMockBuilder(GenerateTestFailedCommand::class)
+            ->onlyMethods(["readFailedTestFile", "writeFailedTestToFile"])
+            ->getMock();
+        // Configure the stub.
+        $stub
+            ->method('readFailedTestFile')
+            ->willReturn($testFileReturn);
+        $stub
+            ->method('writeFailedTestToFile')
+            ->willReturn(null);
+
+        // Run the real code
+        $configuration = $stub->getFailedTestList("", "");
+        $this->assertEquals($expectedConfiguration, $configuration);
+    }
+}

src/Magento/FunctionalTestingFramework/Console/GenerateTestFailedCommand.php

@@ -23,11 +23,6 @@ class GenerateTestFailedCommand extends BaseGenerateCommand
      */
     const DEFAULT_TEST_GROUP = 'default';
 
-    /**
-     * @var string
-     */
-    private $testsReRunFile;
-
     /**
      * Configures the current command.
      *
@@ -54,9 +49,6 @@ protected function configure()
      */
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $this->testsFailedFile = $this->getTestsOutputDir() . self::FAILED_FILE;
-        $this->testsReRunFile = $this->getTestsOutputDir() . "rerun_tests";
-
         $force = $input->getOption('force');
         $debug = $input->getOption('debug') ?? MftfApplicationConfig::LEVEL_DEVELOPER; // for backward compatibility
         $allowSkipped = $input->getOption('allow-skipped');
@@ -71,7 +63,9 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $allowSkipped
         );
 
-        $testConfiguration = $this->getFailedTestList();
+        $testsFailedFile = $this->getTestsOutputDir() . self::FAILED_FILE;
+        $testsReRunFile = $this->getTestsOutputDir() . "rerun_tests";
+        $testConfiguration = $this->getFailedTestList($testsFailedFile, $testsReRunFile);
 
         if ($testConfiguration === null) {
             // No failed tests found, no tests generated
@@ -98,16 +92,16 @@ protected function execute(InputInterface $input, OutputInterface $output): int
      *
      * @return string
      */
-    private function getFailedTestList()
+    public function getFailedTestList($testsFailedFile, $testsReRunFile)
     {
         $failedTestDetails = ['tests' => [], 'suites' => []];
 
-        if (realpath($this->testsFailedFile)) {
-            $testList = $this->readFailedTestFile($this->testsFailedFile);
+        $testList = $this->readFailedTestFile($testsFailedFile);
 
+        if (!empty($testList)) {
             foreach ($testList as $test) {
                 if (!empty($test)) {
-                    $this->writeFailedTestToFile($test, $this->testsReRunFile);
+                    $this->writeFailedTestToFile($test, $testsReRunFile);
                     $testInfo = explode(DIRECTORY_SEPARATOR, $test);
                     $testName = explode(":", $testInfo[count($testInfo) - 1])[1];
                     $suiteName = $testInfo[count($testInfo) - 2];
@@ -160,9 +154,12 @@ private function sanitizeSuiteName($suiteName)
      * @param string $filePath
      * @return array|boolean
      */
-    private function readFailedTestFile($filePath)
+    public function readFailedTestFile($filePath)
     {
-        return file($filePath, FILE_IGNORE_NEW_LINES);
+        if (realpath($filePath)) {
+            return file($filePath, FILE_IGNORE_NEW_LINES);
+        }
+        return "";
     }
 
     /**
@@ -172,7 +169,7 @@ private function readFailedTestFile($filePath)
      * @param string $filePath
      * @return void
      */
-    private function writeFailedTestToFile($test, $filePath)
+    public function writeFailedTestToFile($test, $filePath)
     {
         if (file_exists($filePath)) {
             if (strpos(file_get_contents($filePath), $test) === false) {