ACQE-5089

Fix static issues

Author: KevinBKozan

src/Magento/FunctionalTestingFramework/StaticCheck/TestDependencyCheck.php

@@ -115,11 +115,10 @@ public function execute(InputInterface $input)
 
         // Build array of entities found in allow-list files
         // Expect one entity per file line, no commas or anything else
-        foreach ($allModules as $modulePath)
-        {
+        foreach ($allModules as $modulePath) {
             if (file_exists($modulePath . DIRECTORY_SEPARATOR . self::ALLOW_LIST_FILENAME)) {
                 $contents = file_get_contents($modulePath . DIRECTORY_SEPARATOR . self::ALLOW_LIST_FILENAME);
-                foreach(explode("\n", $contents) as $entity) {
+                foreach (explode("\n", $contents) as $entity) {
                     $this->allowFailureEntities[$entity] = true;
                 }
             }
@@ -150,7 +149,6 @@ public function execute(InputInterface $input)
         $this->errors += $this->findErrorsInFileSet($actionGroupXmlFiles);
         $this->errors += $this->findErrorsInFileSet($dataXmlFiles);
 
-
         // hold on to the output and print any errors to a file
         $this->output = $this->scriptUtil->printErrorsToFile(
             $this->errors,
@@ -159,10 +157,10 @@ public function execute(InputInterface $input)
         );
         if (!empty($this->warnings)) {
             $this->output .= "\n " . $this->scriptUtil->printWarningsToFile(
-                    $this->warnings,
-                    StaticChecksList::getErrorFilesPath() . DIRECTORY_SEPARATOR . self::WARNING_LOG_FILENAME . '.txt',
-                    self::ERROR_LOG_MESSAGE
-                );
+                $this->warnings,
+                StaticChecksList::getErrorFilesPath() . DIRECTORY_SEPARATOR . self::WARNING_LOG_FILENAME . '.txt',
+                self::ERROR_LOG_MESSAGE
+            );
         }
     }
 

src/Magento/FunctionalTestingFramework/Util/Script/ScriptUtil.php

@@ -67,25 +67,38 @@ public function printErrorsToFile(array $errors, string $filePath, string $messa
             return $message . ": No errors found.";
         }
 
-        $this->printTofile($errors, $filePath, $message);
+        $this->printTofile($errors, $filePath);
 
         $errorCount = count($errors);
 
         return $message . ": Errors found across {$errorCount} file(s). Error details output to {$filePath}";
     }
 
+    /**
+     * Prints out given warnings to file, and returns summary result string
+     * @param array  $warnings
+     * @param string $filePath
+     * @param string $message
+     * @return string
+     */
     public function printWarningsToFile(array $warnings, string $filePath, string $message): string
     {
         if (empty($warnings)) {
-            return "" . ": No warnings found.";
+            return $message . ": No warnings found.";
         }
-        $this->printTofile($warnings, $filePath, $message);
+        $this->printTofile($warnings, $filePath);
         $errorCount = count($warnings);
 
         return $message . ": Warnings found across {$errorCount} file(s). Warning details output to {$filePath}";
     }
 
-    private function printTofile($contents, string $filePath, string $message)
+    /**
+     * Writes contents to filePath
+     * @param array  $contents
+     * @param string $filePath
+     * @return void
+     */
+    private function printTofile(array $contents, string $filePath)
     {
         $dirname = dirname($filePath);
         if (!file_exists($dirname)) {