Add auto-open support to program selection#208
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| requester = EndpointRequester( | ||
| self, | ||
| "GET", | ||
| key="OPEN_PROGRAM", | ||
| params=params, |
There was a problem hiding this comment.
Auto-open call blocked by whitelist
The new auto-open flow invokes EndpointRequester(..., key="OPEN_PROGRAM", ...), but DEFAULT_WHITELIST does not contain an OPEN_PROGRAM entry, so _request_lines rejects the request as non-whitelisted. When GHIDRA_BRIDGE_PROGRAM_AUTOOPEN is enabled every auto-open call will therefore return None, and _maybe_autoopen_program will always emit the failure warning instead of actually opening the program.
Useful? React with 👍 / 👎.
…main-file-resolution Add auto-open support to program selection
Summary
Testing
Codex Task