From e54ef4ea961900e5b8da973a6f6bb025036834fa Mon Sep 17 00:00:00 2001 From: Bousmaha Wassel Date: Wed, 30 Nov 2022 10:40:34 +0100 Subject: [PATCH] when receiving id:port on initial connection, use rsplit(':', -1) instead of split (':') so ids with colons won't cause errors --- p2pnetwork/node.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/p2pnetwork/node.py b/p2pnetwork/node.py index ae20192..2e0d144 100644 --- a/p2pnetwork/node.py +++ b/p2pnetwork/node.py @@ -266,7 +266,7 @@ def run(self): connected_node_port = client_address[1] # backward compatibilty connected_node_id = connection.recv(4096).decode('utf-8') if ":" in connected_node_id: - (connected_node_id, connected_node_port) = connected_node_id.split(':') # When a node is connected, it sends it id! + (connected_node_id, connected_node_port) = connected_node_id.rsplit(':', 1) # When a node is connected, it sends it id! connection.send(self.id.encode('utf-8')) # Send my id to the connected node! thread_client = self.create_new_connection(connection, connected_node_id, client_address[0], connected_node_port)