Some optimizations

Author: mZake

include/Apple.hpp

@@ -9,7 +9,7 @@ class Apple
     Apple() : mPosX(0), mPosY(0), mVisible(false) {}
 
     void Reset();
-    void Draw(SDL_Renderer* renderer, const AssetsManager& assetsManager);
+    void Draw(SDL_Renderer* renderer, const AssetsManager& assetsManager) const;
     void SetX(int pos);
     void SetY(int pos);
     void SetVisibility(bool visible);

include/AssetsManager.hpp

@@ -11,8 +11,8 @@ class AssetsManager
 public:
     void LoadAssets(SDL_Renderer* renderer, std::filesystem::path path);
     void UnloadAssets();
-    SDL_Texture* GetTexture(std::string textureId) const;
-    TTF_Font* GetFont(std::string fontId) const;
+    SDL_Texture* GetTexture(const std::string& textureId) const;
+    TTF_Font* GetFont(const std::string& fontId) const;
 
 private:
     std::unordered_map<std::string, SDL_Texture*> mTextures;

include/Snake.hpp

@@ -22,7 +22,7 @@ class Snake
     void Move();
     void Grow();
     void Turn(Direction direction);
-    void Draw(SDL_Renderer* renderer, const AssetsManager& assetsManager);
+    void Draw(SDL_Renderer* renderer, const AssetsManager& assetsManager) const;
     bool IsSelfOrWallColliding() const;
     int PosX() const;
     int PosY() const;

src/Apple.cpp

@@ -8,7 +8,7 @@ void Apple::Reset()
     mVisible = false;
 }
 
-void Apple::Draw(SDL_Renderer* renderer, const AssetsManager& assetsManager)
+void Apple::Draw(SDL_Renderer* renderer, const AssetsManager& assetsManager) const
 {
     if (!mVisible)
         return;

src/AssetsManager.cpp

@@ -18,7 +18,6 @@ void AssetsManager::LoadAssets(SDL_Renderer* renderer, std::filesystem::path dir
         if (extension == ".png")
         {
             SDL_Texture* texture = IMG_LoadTexture(renderer, path.c_str());
-
             if (!texture)
             {
                 std::cerr << "Failed to load texture " << path << ": " << SDL_GetError() << std::endl;
@@ -31,7 +30,6 @@ void AssetsManager::LoadAssets(SDL_Renderer* renderer, std::filesystem::path dir
         if (extension == ".ttf")
         {
             TTF_Font* font = TTF_OpenFont(path.c_str(), 24);
-
             if (!font)
             {
                 std::cerr << "Failed to load font " << path << ": " << SDL_GetError() << std::endl;
@@ -55,10 +53,9 @@ void AssetsManager::UnloadAssets()
     mFonts.clear();
 }
 
-SDL_Texture* AssetsManager::GetTexture(std::string textureId) const
+SDL_Texture* AssetsManager::GetTexture(const std::string& textureId) const
 {
     auto texture = mTextures.find(textureId);
-
     if (texture == mTextures.end())
     {
         std::cerr << textureId << " is an invalid texture identifier!" << std::endl;
@@ -68,10 +65,9 @@ SDL_Texture* AssetsManager::GetTexture(std::string textureId) const
     return texture->second;
 }
 
-TTF_Font* AssetsManager::GetFont(std::string fontId) const
+TTF_Font* AssetsManager::GetFont(const std::string& fontId) const
 {
     auto font = mFonts.find(fontId);
-
     if (font == mFonts.end())
     {
         std::cerr << fontId << " is an invalid font identifier!" << std::endl;

src/Game.cpp

@@ -27,7 +27,6 @@ void Game::Init()
 
     mWindow = SDL_CreateWindow(Config::GameTitle, Config::ScreenX, Config::ScreenY,
                                Config::ScreenWidth, Config::ScreenHeight, Config::WindowFlags);
-
     if (!mWindow)
     {
         std::cerr << "Failed to create window: " << SDL_GetError() << std::endl;
@@ -36,7 +35,6 @@ void Game::Init()
     }
 
     mRenderer = SDL_CreateRenderer(mWindow, -1, Config::RendererFlags);
-
     if (!mRenderer)
     {
         std::cerr << "Failed to create renderer: " << SDL_GetError() << std::endl;
@@ -72,7 +70,6 @@ void Game::Run()
         RenderScene();
 
         frameTime = SDL_GetTicks64() - frameStart;
-
         if (frameTime < FrameDuration)
             SDL_Delay(FrameDuration - frameTime);
     }

src/Main.cpp

@@ -1,4 +1,3 @@
-#include <SDL.h>
 #include "Game.hpp"
 
 int main(int argc, char** argv)

src/Snake.cpp

@@ -82,7 +82,7 @@ void Snake::Turn(Direction direction)
     mNextDirection = direction;
 }
 
-void Snake::Draw(SDL_Renderer* renderer, const AssetsManager& assetsManager)
+void Snake::Draw(SDL_Renderer* renderer, const AssetsManager& assetsManager) const
 {
     SDL_Texture* curveTexture = assetsManager.GetTexture("SnakeCurve");
     SDL_Texture* headTexture = assetsManager.GetTexture("SnakeHead");