Hi PCManFM team,
I've been studying the PCManFM codebase recently and found some areas that could be improved.
Before I start making changes, I'd like to discuss this with you and hear your suggestions.
Issues Found
Security issues:
- Signal handler exits without cleanup (src/pcmanfm.c:140-141)
- Socket file in /tmp may have insufficient permissions (src/single-inst.c:343-349)
- Some places missing NULL checks
- Possible buffer overflow risks (src/single-inst.c:412, 426-430)
Code quality:
- Multiple memory leaks
- Code style is somewhat inconsistent
- Build system is a bit outdated (still using automake 1.10+)
- No static analysis tools integrated
Optimization:
- Performance could be improved (e.g., adding caching, reducing sync operations)
- Consider removing GTK+ 2 support
- Some functions are quite long
Questions I'd like to ask
- Which issues do you think I should start with?
- Would you prefer smaller PRs or larger ones?
- Are there any backward compatibility concerns I should be aware of?
- Should I add test cases?
Things I'd like to help with
- Fix bugs
- Clean up code
- Add tests
- Update documentation
Thank you very much for maintaining this project, I hope I can help!
Hi PCManFM team,
I've been studying the PCManFM codebase recently and found some areas that could be improved.
Before I start making changes, I'd like to discuss this with you and hear your suggestions.
Issues Found
Security issues:
Code quality:
Optimization:
Questions I'd like to ask
Things I'd like to help with
Thank you very much for maintaining this project, I hope I can help!