support scalar fields with args

Author: lukemurray

src/dotnet-gqlgen/SchemaInfo.cs

@@ -172,13 +172,7 @@ public string DotNetTypeSingle
             }
         }
 
-        public bool ShouldBeProperty
-        {
-            get
-            {
-                return (Args.Count == 0 && !schemaInfo.Types.ContainsKey(TypeName) && !schemaInfo.Inputs.ContainsKey(TypeName)) || schemaInfo.Scalars.Contains(TypeName);
-            }
-        }
+        public bool ShouldBeProperty => Args.Count == 0 && IsScalar;
 
         /// <summary>
         /// Outputs the method signature with all arguments and a object selection argument if applicable

src/dotnet-gqlgen/dotnet-gqlgen.csproj

@@ -4,7 +4,7 @@
     <TargetFramework>netstandard2.1</TargetFramework>
     <RootNamespace>dotnet_gqlgen</RootNamespace>
     <PreserveCompilationContext>true</PreserveCompilationContext>
-    <PackageVersion>0.7.5</PackageVersion>
+    <PackageVersion>0.7.6</PackageVersion>
   </PropertyGroup>
 
   <PropertyGroup>

src/tests/DotNetGraphQLQueryGen.Tests/Generated/GeneratedTypes.cs

@@ -231,6 +231,11 @@ public interface Movie
         /// </summary>
         [GqlFieldName("type")]
         int? Type { get; }
+        /// <summary>
+        /// External identifier by name
+        /// </summary>
+        [GqlFieldName("externalId")]
+        string ExternalId(string name);
     }
     public interface Actor
     {

src/tests/DotNetGraphQLQueryGen.Tests/TestMakeQuery.cs

@@ -179,6 +179,22 @@ public void TestComplexValueArg()
 }}", query.Query, ignoreLineEndingDifferences: true);
         }
 
+        [Fact]
+        public void ScalarFieldWithArgOnEntityType()
+        {
+            var client = new TestClient();
+            var query = client.MakeQuery(q => new {
+                Movie = q.Movie(1, m => new {
+                    ExternalId = m.ExternalId("mySystem"),
+                }),
+            });
+            Assert.Equal($@"query TestQuery  {{
+Movie: movie(id: 1) {{
+ExternalId: externalId(name: ""mySystem"")
+}}
+}}", query.Query, ignoreLineEndingDifferences: true);
+        }
+
         [Fact]
         public void TestErrorOnInvalidPropertySelection()
         {

src/tests/DotNetGraphQLQueryGen.Tests/VisitorTests.cs

@@ -75,13 +75,21 @@ public void TestSchemaTypeDef()
 
             var typeDef = results.Types["Movie"];
             Assert.Equal("This is a movie entity", typeDef.Description);
-            Assert.Equal(10, typeDef.Fields.Count);
+            Assert.Equal(11, typeDef.Fields.Count);
             Assert.Equal("id", typeDef.Fields.ElementAt(0).Name);
             Assert.Equal("String", typeDef.Fields.ElementAt(1).TypeName);
             Assert.False(typeDef.Fields.ElementAt(1).IsArray);
             Assert.Equal("actors", typeDef.Fields.ElementAt(4).Name);
             Assert.Equal("Person", typeDef.Fields.ElementAt(4).TypeName);
             Assert.True(typeDef.Fields.ElementAt(4).IsArray);
+
+            var externalIdField = typeDef.Fields.First(f => f.Name == "externalId");
+            Assert.Equal("String", externalIdField.TypeName);
+            Assert.Single(externalIdField.Args);
+            Assert.Equal("name", externalIdField.Args.First().Name);
+            Assert.True(externalIdField.Args.First().Required);
+            Assert.False(externalIdField.ShouldBeProperty);
+            Assert.True(externalIdField.IsScalar);
         }
     }
 }

src/tests/DotNetGraphQLQueryGen.Tests/schema.graphql

@@ -67,6 +67,8 @@ type Movie {
 	rating: Float
 	"Just testing using gql schema keywords here"
 	type: Int
+	"External identifier by name"
+	externalId(name: String!): String
 }
 
 type Actor {