[CHORE]: Merged from upstream

Author: rdrnt

.eslintrc.json

@@ -0,0 +1,47 @@
+{
+  "env": {
+    "node": true,
+    "es6": true
+  },
+
+  "globals": {
+    "fetch": false
+  },
+
+  "parserOptions": {
+    "ecmaVersion": 8,
+    "ecmaFeatures": {
+      "arrowFunctions": true,
+      "blockBindings": true,
+      "classes": true,
+      "defaultParameters": true,
+      "destructuring": true,
+      "forOf": true,
+      "generators": true,
+      "modules": true,
+      "objectLiteralComputedProperties": true,
+      "objectLiteralDuplicateProperties": true,
+      "objectLiteralShorthandMethods": true,
+      "objectLiteralShorthandProperties": true,
+      "regexUFlag": true,
+      "regexYFlag": true,
+      "restParams": true,
+      "spread": true,
+      "superInFunctions": true,
+      "templateStrings": true,
+      "unicodeCodePointEscapes": true,
+      "globalReturn": true
+    },
+    "sourceType": "module"
+  }, 
+
+  "extends": "airbnb",
+
+  "rules": {
+    "arrow-parens": 0,
+    "no-param-reassign": 0,
+    "react/jsx-filename-extension": [1, { "extensions": [".js", ".jsx"] }]
+  }
+}
+
+// https://eslint.org/docs/rules/

.prettierignore

@@ -0,0 +1 @@
+__tests__/data

.prettierrc

@@ -0,0 +1,10 @@
+tabWidth: 2
+useTabs: false
+semi: true
+singleQuote: true
+trailingComma: all
+bracketSpacing: true
+jsxBracketSameLine: false
+arrowParens: avoid
+parser: flow
+printWidth: 80

CONTRIBUTING.md

@@ -0,0 +1,33 @@
+# Contributing
+
+To contribute to hackd, clone/fork the repository, make changes and open a PR with your changes. Any type of change is welcomed, including bug fixes, new features, documentation or tests.
+
+Opening issues for bugs, features or anything else is also welcomed.
+
+If you are implementing a new feature, or modifying styles, please replace/add screenshot(s) to the [README](README.md).
+
+### Prettier
+
+[Prettier](https://github.com/prettier/prettier) is used to keep a consistent code style across the project. Before committing, run `npm run prettier` which will transform your code to fit the projects style.
+
+### ESLint
+
+[ESLint](https://github.com/eslint/eslint) is used for code linting inside your IDE/text editor. If you don't have ESLint installed in your editor, you should install it - [https://eslint.org/docs/user-guide/integrations](https://eslint.org/docs/user-guide/integrations). 
+
+To find any errors or warnings, either view them in your editor once you've installed the right package, or run `npm run eslint`. Not all errors/warnings can be fixed, and some will be picked up by prettier, so don't worry if you can't fix them.
+
+### Lock Files
+
+All lock files (`package-lock.json`, `yarn.lock`) should be committed.
+
+### Dependencies
+
+Try to keep dependencies to a minimum where possible. If you are pulling a whole library for just one function, try to implement that function as a helper method.
+
+### Testing
+
+[Jest](https://github.com/facebook/jest) is used for testing. Once you've made changes, writing a test case helps to catch any bugs. Feel free to open a PR that just includes more tests.
+
+### Setup
+
+Follow the instructions in the [README](README.md) to get setup. Once hackd is running in the iOS simulator, you can enable debugging and view redux-logger logs in the console.

__tests__/tests/actions/auth.js

@@ -7,19 +7,18 @@ import { post } from '../../data/api/post';
 const dispatch = jest.fn();
 
 describe('Auth Actions', () => {
-
   it('should login a user', () => {
     const getState = () => ({});
 
     actions.login(appUser)(dispatch, getState);
     expect(dispatch).toHaveBeenCalledWith({
-      type: 'UPDATE_USER', 
+      type: 'UPDATE_USER',
       user: appUser,
     });
   });
 
   it('should add a post to the upvoted section of a new users account', () => {
-    const getState = () => ({ 
+    const getState = () => ({
       user: appUser,
       accounts: {},
     });
@@ -32,13 +31,13 @@ describe('Auth Actions', () => {
 
     actions.addIdToUserAccount(post.id, 'upvoted')(dispatch, getState);
     expect(dispatch).toHaveBeenCalledWith({
-      type: 'SET_ACCOUNTS_DETAILS', 
+      type: 'SET_ACCOUNTS_DETAILS',
       accounts: expectedAccounts,
     });
   });
 
   it('should add a post to the saved section of a new users account', () => {
-    const getState = () => ({ 
+    const getState = () => ({
       user: appUser,
       accounts: {},
     });
@@ -51,13 +50,13 @@ describe('Auth Actions', () => {
 
     actions.addIdToUserAccount(post.id, 'saved')(dispatch, getState);
     expect(dispatch).toHaveBeenCalledWith({
-      type: 'SET_ACCOUNTS_DETAILS', 
+      type: 'SET_ACCOUNTS_DETAILS',
       accounts: expectedAccounts,
     });
   });
 
   it('should remove a post from the saved section of an existing users account', () => {
-    const getState = () => ({ 
+    const getState = () => ({
       user: appUser,
       accounts: {
         [appUser.username]: {
@@ -74,13 +73,13 @@ describe('Auth Actions', () => {
 
     actions.removeIdFromUserAccount(post.id, 'saved')(dispatch, getState);
     expect(dispatch).toHaveBeenCalledWith({
-      type: 'SET_ACCOUNTS_DETAILS', 
+      type: 'SET_ACCOUNTS_DETAILS',
       accounts: expectedAccounts,
     });
   });
 
   it('should add a post to the upvotedComments section of a new users account', () => {
-    const getState = () => ({ 
+    const getState = () => ({
       user: appUser,
       accounts: {},
     });
@@ -93,13 +92,13 @@ describe('Auth Actions', () => {
 
     actions.addIdToUserAccount(post.id, 'upvotedComments')(dispatch, getState);
     expect(dispatch).toHaveBeenCalledWith({
-      type: 'SET_ACCOUNTS_DETAILS', 
+      type: 'SET_ACCOUNTS_DETAILS',
       accounts: expectedAccounts,
     });
   });
 
   it('should remove a post from the upvotedComments section of an existing users account', () => {
-    const getState = () => ({ 
+    const getState = () => ({
       user: appUser,
       accounts: {
         [appUser.username]: {
@@ -114,11 +113,13 @@ describe('Auth Actions', () => {
       },
     };
 
-    actions.removeIdFromUserAccount(post.id, 'upvotedComments')(dispatch, getState);
+    actions.removeIdFromUserAccount(post.id, 'upvotedComments')(
+      dispatch,
+      getState,
+    );
     expect(dispatch).toHaveBeenCalledWith({
-      type: 'SET_ACCOUNTS_DETAILS', 
+      type: 'SET_ACCOUNTS_DETAILS',
       accounts: expectedAccounts,
     });
   });
-
-});
+});

__tests__/tests/actions/items.js

@@ -4,7 +4,6 @@ import * as actions from '../../../app/actions/items';
 import { posts } from '../../data/api/post';
 
 describe('Items Actions', () => {
-
   it('should set first page posts', () => {
     const getState = () => ({});
 
@@ -15,7 +14,7 @@ describe('Items Actions', () => {
     actions.setPosts(1, posts)(dispatch, getState);
 
     expect(dispatch).toHaveBeenCalledWith({
-      type: 'SET_POSTS', 
+      type: 'SET_POSTS',
       posts,
     });
   });
@@ -24,9 +23,8 @@ describe('Items Actions', () => {
     const storyType = 'top';
 
     expect(actions.setStoryType(storyType)).toEqual({
-      type: 'SET_STORY_TYPE', 
+      type: 'SET_STORY_TYPE',
       storyType,
     });
   });
-
-});
+});

__tests__/tests/utilities/utils.js

@@ -1,4 +1,4 @@
-import { 
+import {
   capitalize,
   truncate,
   addToUserAccount,
@@ -29,7 +29,7 @@ describe('App Utils', () => {
     expect(addToUserAccount(account, appUser, id, type)).toEqual({
       [appUser.username]: {
         upvoted: [id],
-      }
+      },
     });
   });
 
@@ -45,8 +45,7 @@ describe('App Utils', () => {
     expect(removeFromUserAccount(account, appUser, id, type)).toEqual({
       [appUser.username]: {
         upvotedComments: [id2],
-      }
+      },
     });
   });
-
 });

app/actions/auth.js

@@ -1,9 +1,6 @@
 import * as types from './types';
-import { 
-  addToUserAccount, 
-  removeFromUserAccount 
-} from '../helpers/utils';
-import { logout, upvote, } from '../helpers/api';
+import { addToUserAccount, removeFromUserAccount } from '../helpers/utils';
+import { logout, upvote } from '../helpers/api';
 
 const setUser = user => {
   return {
@@ -37,12 +34,11 @@ export const removeIdFromUserAccount = (id, type) => {
   };
 };
 
-export const upvotePost = (id) => {
+export const upvotePost = id => {
   return (dispatch, getState) => {
-
     // Add upvote initially for immediate feedback
     dispatch(addIdToUserAccount(id, 'upvoted'));
-    
+
     upvote(id).then(upvoted => {
       if (!upvoted) {
         dispatch(removeIdFromUserAccount(id, 'upvoted'));
@@ -51,7 +47,7 @@ export const upvotePost = (id) => {
   };
 };
 
-export const savePost = (id) => {
+export const savePost = id => {
   return (dispatch, getState) => {
     dispatch(addIdToUserAccount(id, 'saved'));
   };

app/actions/index.js

@@ -2,7 +2,8 @@ import * as ItemActions from './items';
 import * as AuthActions from './auth';
 import * as SettingActions from './settings';
 
-export const ActionCreators = Object.assign({}, 
+export const ActionCreators = Object.assign(
+  {},
   ItemActions,
   AuthActions,
   SettingActions,

app/actions/types.js

@@ -10,4 +10,4 @@ export const ADD_UPVOTED_POST = 'ADD_UPVOTED_POST';
 export const CHANGE_SAVED_POSTS = 'CHANGE_SAVED_POSTS';
 
 // Settings
-export const SET_SETTINGS = 'SET_SETTINGS';
+export const SET_SETTINGS = 'SET_SETTINGS';