Upgrading to 1.13.1 causes closing issue

[jlewis99]

With my instance settings as:

@INSTANCETABLE_VARLIST=sample_id_reporting_2,cell_type,measurement_1,measurement_2,measurement_3
@INSTANCETABLE-REF=sample_id_instance
@INSTANCETABLE-PREFILL='sample_id_reporting=[sample_id]'
@INSTANCETABLE=sequence

When clicking Add New from my sample instrument, the sequence instrument shows as a new window but when I Save and Exit, it no longer closes the sequence window. It takes me back to record home in most cases not all cases and I have to manually close the window.

These tests are in data entry mode, NOT as a survey.

[indianacraig]

@jlewis99 I too have been experiencing the same issue. It was happening every time I clicked Save & Exit in the popup while using Firefox and Chrome. However, I had sporadic results with Edge. I took a look at the External Modules I have enabled and found that one of them was causing most of the problem: Auto Complete Form Status Based on Required Fields - v1.7. When I disabled it, I stopped having the issue 90% of the time. It still occurs occasionally, but much better than before. Not sure if you have this module enabled or a similar one that might be causing issues.

[jlewisbs]

@indianacraig This is the only module enabled for this project. I might have to revert to the previous version of Instance Table.

[lsgs]

Thanks for reporting the issue @jlewis99, @indianacraig, @jlewisbs. Are you finding that you get this problem across all instance tables in your instnace or only under specific conditions? What are those conditions? Are any of you able to post a simple project XML where you can reliably replicate the problem? It is not something I am able to replicate in my current release v1.13.1 (except in the scenario where the instance is a survey response - see #80 and for which a fix is coming with v1.13.2).

[jlewisbs]

Here is an example project that I've been testing with. Not in survey mode...

TestCombinedProjectI_2026-01-05_1555.REDCap.xml

[lsgs]

Thanks @jlewisbs. Are you finding that the popup not closing is a consistent thing? I'm using REDCap v15.5.23 and v1.13.2 of the EM, and using Firefox and Chrome, and an admin and non-admin user. I have created a project from your XML but am not seeing the non-closing popup window problem...

GIF

[jlewisbs]

I just tried it again under REDCap 16.05, EM version v1.13.1 and chrome.
I consistently does not close the window.

Are there related changes in v1.13.2 that may help?

[indianacraig]

I updated my PHP over the holiday break and took Redcap up a couple version so now here is what I'm on: REDCap 15.7.6 · PHP 8.4.15 (Linux/Unix OS) · MySQL 8.0.42. I'm also using Instance Table 1.13.1. I added some console statements to the InstanceTable.php function redcap_every_page_top($project_id) to see what is going on when I click Add New and also Save & Exit. When I click Add New, I get this:

When I enter information and click Save & Exit, I get this:

It looks like the php program is finding the page and record id, but I'm not sure that it's finding the session information. I will keep digging to see what else I can find. If there is anything you want me to look for or any info that would help, just let me know. Thanks!

[indianacraig]

I found a small bug in line 1021. There is an extra ">" at the end. After I removed it on my instance, the form is now closing on Save & Exit. Hopefully this works for @jlewisbs too! YEAH!!!!

$('#form').append('>');

[indianacraig]

For some reason, the code in my previous comment above got cut off...trying to send it again!

$('#form').append('>');

[indianacraig]

Oh well! Github doesn't like it for some reason...just search on ">>" and you'll find it.

[lsgs]

Thank you @indianacraig! I've removed that stray character and re-done release v1.13.2, which had not yet been approved by VUMC. It should be appearnig in the REDCap Repo soon...