One declaration/statement per-line [Lexical suggestion]

[antmarzam]

Reason: helps with code-annotation when debugging code without having to hack the source directly.

[marnovandermaas]

I like this suggestion, but am worried about the code churn this would require.

[rswarbrick]

I agree with @marnovandermaas.

Is it easy to get a feel for how many violations there are in OpenTitan? I did a really stupid search with

git grep '^[^/]*;\s*[^ /,)\\]' '*.sv' | grep -v 'for\s*(' | grep -v constraint | grep -v bins | grep -v while | grep -v import | grep -v ':\s*`' 

and found 244 lines. (The last grep call drops some macro invocations).

If we wanted to specify something like this, I think we'd need to be a bit more specific about what we're telling people to avoid.

[rswarbrick]

Making sure I understand:

Declarations:

int a, b, c; // Potentially bad!

But this might be better:

int a;
int b;
int c;

Statements:
Two types we can think of. One is control structures. Do we allow these?

if (a)  foo();

if (a)
  foo();

if (a) begin foo(); end

Another is general statements like this:

f(); g(); h(); // Bad?

[rswarbrick]

One reason to avoid multiple declarations on a line might be that it's easy to forget to add comments to some of the variables.

[nbdd0121]

What about _q, _d? I think they should be allowed in the same line.

[antmarzam]

What about _q, _d? I think they should be allowed in the same line.

I think that's fine, this is only targeting DV guidelines