Fluid usage recommendations

[sebastienros]

Here is a snippet of the template rendering

var options = new TemplateOptions();
options.CultureInfo = System.Globalization.CultureInfo.CurrentUICulture;
options.MemberAccessStrategy = new UnsafeMemberAccessStrategy();

var context = new TemplateContext(model, options, allowModelMembers: true);

var template = _fluidParser.Parse(source);
return template.Render(context);

TemplateOptions should be reused. It is expensive to create new instances as caches are not reused. Register this as a singleton.

Template results from Parse should be reused. If the same templates are parsed then it makes sense to create a local cache of the parsed templates. A simple dictionary based on the source, or a key derived from it (filename, timestamp, ...) in a constrained IMemoryCache (time and size bound), would be ideal.

[pwelter34]

@sebastienros does commit 624b158 look better? Thanks for feedback!

[sebastienros]

Looks good! I spent some time thinking about the necessity of hashing the template itself. I think it makes sense if you really don't want to use the source as the key. If you had other thing to vary by it would be required. Here it is questionable, but assuming that the template size can be consequent I assume it's better as it won't be kept indefinitely. It's also assuming that the parsed template itself doesn't keep a reference on it either (using TextSpan for instance).