Skip to content

Fix legacy firmware (2.x) response format in invoke() #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StevenEmelander wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix legacy firmware (2.x) response format in invoke() #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/aiovantage/_object_interfaces/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,11 @@ async def invoke(

# Break the response into tokens
return_line = response[-1]
_command, _vid, result, _method, *args = Converter.tokenize(return_line)
_command, _vid, result, *args = Converter.tokenize(return_line)

# Parse the response
return self._parse_object_response(method, result, *args, as_type=as_type)
# Skip the echoed method name if present; legacy firmware (2.x)
# omits it, while modern firmware includes it as the first arg.
return self._parse_object_response(method, result, *args[1:], as_type=as_type)

def update_properties(self, properties: dict[str, Any]) -> list[str]:
"""Update object properties.
Expand Down