Skip to content

Draft WB py3 migration #16

@luzpaz

Description

@luzpaz

Found this in the Draft WB source. thought you should know since you've been doing a lot of awesome work in migrating to py3

./src/Mod/Draft/Draft.py:
 5990                  plm = obj.Placement
 5991              ff8 = obj.FontFile.encode('utf8')                  # 1947 accents in filepath
 5992:                                                                # TODO: change for Py3?? bytes?
 5993                                                                 # Part.makeWireString uses FontFile as char* string
 5994  #            CharList = Part.makeWireString(obj.String,obj.FontFile,obj.Size,obj.Tracking)

./src/Mod/Draft/DraftGui.py:
 1450  #                    fname = utf8_decode(fname[0])  # 1947: utf8_decode fails ('ascii' codec can't encode character)
 1451                                                      # when fname[0] contains accented chars
 1452:                     fname = fname[0].encode('utf8') #TODO: this needs changing for Py3??
 1453                                                      # accented chars cause "UnicodeEncodeError" failure in DraftGui.todo without 
 1454                                                      # .encode('utf8')

./src/Mod/TechDraw/App/DrawViewClipPyImp.cpp:
   84      for( ; it != strings.end(); it++) {
   85  #if PY_MAJOR_VERSION < 3
   86:         PyObject* pString = PyString_FromString(it->c_str());           //TODO: unicode & py3
   87  #else
   88          PyObject* pString = PyUnicode_FromString(it->c_str());

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions