split out specs to unit and integration

Author: talevy

.travis.yml

@@ -6,4 +6,4 @@ services:
 rvm:
   - jruby-1.7.23
 script: 
-  - bundle exec rspec spec && bundle exec rspec spec --tag redis
+  - bundle exec rspec spec && bundle exec rspec spec --tag integration

spec/outputs/redis_spec.rb spec/integration/outputs/redis_spec.rbspec/outputs/redis_spec.rb renamed to spec/integration/outputs/redis_spec.rb

@@ -6,7 +6,7 @@
 
 describe LogStash::Outputs::Redis do
 
-  context "integration tests", :redis => true do
+  context "integration tests", :integration => true do
     shared_examples_for "writing to redis list" do |extra_config|
       let(:key) { 10.times.collect { rand(10).to_s }.join("") }
       let(:event_count) { Flores::Random.integer(0..10000) }
@@ -73,36 +73,5 @@
       end
     end
   end
-
-  context "Redis#receive in batch mode" do
-    # this is a regression test harness to verify fix for https://github.com/logstash-plugins/logstash-output-redis/issues/26
-    # TODO: refactor specs above and probably rely on a Redis mock to correctly test the code expected behaviour, the actual
-    # tests agains Redis should be moved into integration tests.
-    let(:key) { "thekey" }
-    let(:payload) { "somepayload"}
-    let(:event) { LogStash::Event.new({"message" => "test"}) }
-    let(:config) {
-      {
-        "key" => key,
-        "data_type" => "list",
-        "batch" => true,
-        "batch_events" => 50,
-       }
-    }
-    let(:redis) { described_class.new(config) }
-
-    it "should call buffer_receive" do
-      redis.register
-      expect(redis).to receive(:buffer_receive).exactly(10000).times.and_call_original
-      expect(redis).to receive(:flush).exactly(200).times
-
-      # I was able to reproduce the LocalJumpError: unexpected next exception at around 50
-      # consicutive invocations. setting to 10000 should reproduce it for any environment
-      # I have no clue at this point why this problem does not happen at every invocation
-      1.upto(10000) do
-        expect{redis.receive(event)}.to_not raise_error
-      end
-    end
-  end
 end
 

spec/unit/outputs/redis_spec.rb

@@ -0,0 +1,40 @@
+require "logstash/devutils/rspec/spec_helper"
+require "logstash/outputs/redis"
+require "logstash/json"
+require "redis"
+require "flores/random"
+
+describe LogStash::Outputs::Redis do
+
+  context "Redis#receive in batch mode" do
+    # this is a regression test harness to verify fix for https://github.com/logstash-plugins/logstash-output-redis/issues/26
+    # TODO: refactor specs above and probably rely on a Redis mock to correctly test the code expected behaviour, the actual
+    # tests agains Redis should be moved into integration tests.
+    let(:key) { "thekey" }
+    let(:payload) { "somepayload"}
+    let(:event) { LogStash::Event.new({"message" => "test"}) }
+    let(:config) {
+      {
+        "key" => key,
+        "data_type" => "list",
+        "batch" => true,
+        "batch_events" => 50,
+       }
+    }
+    let(:redis) { described_class.new(config) }
+
+    it "should call buffer_receive" do
+      redis.register
+      expect(redis).to receive(:buffer_receive).exactly(10000).times.and_call_original
+      expect(redis).to receive(:flush).exactly(200).times
+
+      # I was able to reproduce the LocalJumpError: unexpected next exception at around 50
+      # consicutive invocations. setting to 10000 should reproduce it for any environment
+      # I have no clue at this point why this problem does not happen at every invocation
+      1.upto(10000) do
+        expect{redis.receive(event)}.to_not raise_error
+      end
+    end
+  end
+end
+