Scene Select: Polish Needed

[logokas]

@wingedterra This one's for you, if you got the time.

The changed scene select has been accepted, however it needs some serious visual changes in order to be more suitable with the selection screen in mind.

I'm thinking we should move the text to beneath the thumbnail, move the scrollbar further to the right, and perhaps fit 2 skits side by side, to make better use of the available space.

I also think this shouldn't go back to main menu when a skit is finished playing from this menu, it should return to it.

If anyone has any other ideas on how to improve this feature, in terms of visuals, I am all ears.

[logokas]

Also noticed that thumbnail scaling is behaving strangely even though files are the exact same size.

I think it is better if we just assume that the images will always be a certain size, and to adjust all scaling accordingly.

Currently Flightless Comedy shows massively oversized despite being a standard 640x360 file like normal. I do not understand why that is, currentyly, but I'm assuming it might be fixed if the same scaling bugfix that was used for pun club, was applied. Problem is, we shouldn't have to do that, as long as we ensure that all thumbnail files are the correct resolution.

[logokas]

Also noticed that right or middle clicking turns the screen blank. We should disable that feature while in this menu to avoid confusing anyone.

[logokas]

One more thing, I don't see a back button anywhere, even though i recall a back button being spoke about in the PR for this feature.

[wingedterra]

I just created a PR with the requested changes. Here's what I did:

I'm thinking we should move the text to beneath the thumbnail, move the scrollbar further to the right, and perhaps fit 2 skits side by side, to make better use of the available space.

Done. vbox'd the imagebutton and the caption together and explicitly set the xpos of the scrollbar. Now both columns are used for images and buttons.

I also think this shouldn't go back to main menu when a skit is finished playing from this menu, it should return to it.

Easy enough fix, changed the return at the end of label choose: to "jump choose" so it just keeps looping.

Currently Flightless Comedy shows massively oversized despite being a standard 640x360 file like normal.

I didn't see this skit in there at all. The length of the skits list was 16 and I had 16 buttons on the scene select. It's past midnight so I might've just missed it.

Also noticed that right or middle clicking turns the screen blank. We should disable that feature while in this menu to avoid confusing anyone.

Done, set the middle/right mouse buttons to NullAction within the screen. Currently pressing these buttons still resets the music though. Not sure why. Minor annoyance.

One more thing, I don't see a back button anywhere, even though i recall a back button being spoke about in the PR for this feature.

Added one in the top right. I kept the font the same (Monika's handwriting), though against the brown background it's a little hard to read. Might be worth changing.