You are currently in no arena

[VityaSchel]

Describe the bug
Web server does detect that I'm online but does not detect the arena

To Reproduce
Set use web songs to true
Enable webserver
Go to it

Expected behavior
Should play songs. It did work but for some reason stopped?

Screenshots
/Musicplayer

Despite me being in arena and plugin working and even game starting

Environment:

• Server version: Paper v.1.21.4
• BlockParty version 2.0.5-RELEASE
• Additional Plugins: multiverse, protect

Additional context
Add any other context about the problem here.

[VityaSchel]

This is likely related to UUID check here:

BlockParty/core/src/main/java/de/leonkoth/blockparty/player/PlayerInfo.java

Line 124 in 851ebd8

public static PlayerInfo getFromPlayer(Player player) {

So it does not work with offline mode=true

[VityaSchel]

I confirmed that this only happens when server is in offline mode i.e. online-mode=false in server.properties
I'm examining source code but I can't find the root of this issue
The problem is obviously that in MusicPlayerServlet class when it gets user from username decrypted from session:

BlockParty/core/src/main/java/de/leonkoth/blockparty/web/server/handler/MusicPlayerServlet.java

Line 32 in 851ebd8

if ((playerInfo = PlayerInfo.getFromPlayer(playerName)) != null) {

The player's instance arena is null

BlockParty/core/src/main/java/de/leonkoth/blockparty/web/server/handler/MusicPlayerServlet.java

Line 33 in 851ebd8

Arena arena = playerInfo.getCurrentArena();

getCurrentArena seems to be just a property, that is assigned in PlayerJoinArenaListener event with setCurrentArena call:

BlockParty/core/src/main/java/de/leonkoth/blockparty/listener/PlayerJoinArenaListener.java

Line 79 in 851ebd8

playerInfo.setCurrentArena(arena);

But I don't have a clue why

PlayerInfo.getFromPlayer("VityaSchel")

is not equal to

PlayerInfo.getFromPlayer(player)

in offline mode, where player is org.​bukkit.​entity class

[VityaSchel]

My suggested fix is

public static PlayerInfo getFromPlayer(Player player) {
    for (PlayerInfo playerInfo : BlockParty.getInstance().getPlayers()) {
//      if (playerInfo.getUuid().equals(player.getUniqueId())) {
// change to
        if (playerInfo.getName().equalsIgnoreCase(player.getName())) {
            return playerInfo;
        }
    }

    return null;
}

I have to compile this plugin and test it to see if it works