From 1a363942047fd230c7ae25c6ebbf3c4c212a6b5e Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Tue, 2 Dec 2025 13:59:30 -0800 Subject: [PATCH 1/3] Fix more Clang 21.1 lint warnings --- lib/API/DX/Device.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/API/DX/Device.cpp b/lib/API/DX/Device.cpp index 4e8fde82..d1ab6281 100644 --- a/lib/API/DX/Device.cpp +++ b/lib/API/DX/Device.cpp @@ -1022,7 +1022,8 @@ class DXDevice : public offloadtest::Device { HR::toError(IS.CmdList->Close(), "Failed to close command list.")) return Err; - ID3D12CommandList *CmdLists[] = {IS.CmdList.Get()}; + ID3D12CommandList *CmdLists[] = { + IS.CmdList.Get()}; // NOLINT(misc-const-correctness) IS.Queue->ExecuteCommandLists(1, CmdLists); return waitForSignal(IS); @@ -1213,13 +1214,13 @@ class DXDevice : public offloadtest::Device { static_cast(B.getElementSize() * B.OutputProps.Width); const uint32_t Height = static_cast(B.OutputProps.Height); - uint8_t *SrcBase = reinterpret_cast(Mapped); + const uint8_t *SrcBase = reinterpret_cast(Mapped); uint8_t *DstBase = reinterpret_cast(P.Bindings.RTargetBufferPtr->Data[0].get()); // Copy rows in reverse order. for (uint32_t Y = 0; Y < Height; ++Y) { - uint8_t *SrcRow = SrcBase + static_cast(Y) * RowPitch; + const uint8_t *SrcRow = SrcBase + static_cast(Y) * RowPitch; uint8_t *DstRow = DstBase + static_cast(Height - 1 - Y) * RowBytes; memcpy(DstRow, SrcRow, RowBytes); From f1f6b42b271ee2ad4c82e6a78df0e9bcb2e3b275 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Fri, 5 Dec 2025 11:54:31 -0800 Subject: [PATCH 2/3] code review feedback - add const --- lib/API/DX/Device.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/API/DX/Device.cpp b/lib/API/DX/Device.cpp index d1ab6281..6a2d099a 100644 --- a/lib/API/DX/Device.cpp +++ b/lib/API/DX/Device.cpp @@ -1022,8 +1022,7 @@ class DXDevice : public offloadtest::Device { HR::toError(IS.CmdList->Close(), "Failed to close command list.")) return Err; - ID3D12CommandList *CmdLists[] = { - IS.CmdList.Get()}; // NOLINT(misc-const-correctness) + ID3D12CommandList * const CmdLists[] = {IS.CmdList.Get()}; IS.Queue->ExecuteCommandLists(1, CmdLists); return waitForSignal(IS); From f8241b10fff03bbe618fa66d655da654908b36ec Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Mon, 8 Dec 2025 12:23:08 -0800 Subject: [PATCH 3/3] clang-format --- lib/API/DX/Device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/API/DX/Device.cpp b/lib/API/DX/Device.cpp index 6a2d099a..d44f2f15 100644 --- a/lib/API/DX/Device.cpp +++ b/lib/API/DX/Device.cpp @@ -1022,7 +1022,7 @@ class DXDevice : public offloadtest::Device { HR::toError(IS.CmdList->Close(), "Failed to close command list.")) return Err; - ID3D12CommandList * const CmdLists[] = {IS.CmdList.Get()}; + ID3D12CommandList *const CmdLists[] = {IS.CmdList.Get()}; IS.Queue->ExecuteCommandLists(1, CmdLists); return waitForSignal(IS);