From ad131e69ca2ba57307cc2ed64ebc73e7a8a96535 Mon Sep 17 00:00:00 2001 From: Cole Kendrick Date: Thu, 29 Aug 2024 07:43:58 -0700 Subject: [PATCH 1/2] Add valgrind to CI for poisson example --- .github/workflows/ci.yml | 4 ++-- .github/workflows/run_tests/action.yml | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1e1f763ea..df643699c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -53,8 +53,8 @@ jobs: cd ${GITHUB_WORKSPACE}/build cmake .. -DCMAKE_TOOLCHAIN_FILE=${TOOLCHAIN_FILE} -DCMAKE_BUILD_TYPE=Debug -DUSE_MFEM=${USE_MFEM} -DMFEM_USE_GSLIB=${MFEM_USE_GSLIB} -DENABLE_TESTS=ON -DMPIEXEC_PREFLAGS="--oversubscribe" -DMPIEXEC_MAX_NUMPROCS=4 make -j 4 - cmake .. -DCMAKE_TOOLCHAIN_FILE=${TOOLCHAIN_FILE} -DCMAKE_BUILD_TYPE=Optimized -DUSE_MFEM=${USE_MFEM} -DMFEM_USE_GSLIB=${MFEM_USE_GSLIB} -DENABLE_TESTS=ON -DMPIEXEC_PREFLAGS="--oversubscribe" -DMPIEXEC_MAX_NUMPROCS=4 - make -j 4 +# cmake .. -DCMAKE_TOOLCHAIN_FILE=${TOOLCHAIN_FILE} -DCMAKE_BUILD_TYPE=Optimized -DUSE_MFEM=${USE_MFEM} -DMFEM_USE_GSLIB=${MFEM_USE_GSLIB} -DENABLE_TESTS=ON -DMPIEXEC_PREFLAGS="--oversubscribe" -DMPIEXEC_MAX_NUMPROCS=4 +# make -j 4 - name: Build baseline libROM if: ${{ github.event.label.name == 'LGTM' || contains(github.event.pull_request.labels.*.name, 'LGTM') }} run: | diff --git a/.github/workflows/run_tests/action.yml b/.github/workflows/run_tests/action.yml index e86f04c48..da83b8588 100644 --- a/.github/workflows/run_tests/action.yml +++ b/.github/workflows/run_tests/action.yml @@ -7,6 +7,12 @@ runs: ctest --output-on-failure shell: bash + - name: Run valgrind test + run: | + cd ${GITHUB_WORKSPACE}/build/examples/prom + valgrind --leak-check=full --track-origins=yes ./poisson_global_rom -offline -f 1.0 -id 0 + shell: bash + - name: Run regression tests if: ${{ github.event.label.name == 'LGTM' || contains(github.event.pull_request.labels.*.name, 'LGTM') }} run: | From 49742ddb4b0eff5df3e50084c54af5a2ae1ab477 Mon Sep 17 00:00:00 2001 From: Cole Kendrick Date: Thu, 29 Aug 2024 11:07:43 -0700 Subject: [PATCH 2/2] Add groups and online stage to valgrind example --- .github/workflows/run_tests/action.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/run_tests/action.yml b/.github/workflows/run_tests/action.yml index da83b8588..29f586b0a 100644 --- a/.github/workflows/run_tests/action.yml +++ b/.github/workflows/run_tests/action.yml @@ -10,7 +10,15 @@ runs: - name: Run valgrind test run: | cd ${GITHUB_WORKSPACE}/build/examples/prom + echo "::group::Valgrind - Poisson Global PROM - Offline" valgrind --leak-check=full --track-origins=yes ./poisson_global_rom -offline -f 1.0 -id 0 + echo "::endgroup::" + ./poisson_global_rom -offline -f 1.1 -id 1 + ./poisson_global_rom -offline -f 1.2 -id 2 + ./poisson_global_rom -merge -ns 3 + echo "::group::Valgrind - Poisson Global PROM - Online" + valgrind --leak-check=full --track-origins=yes ./poisson_global_rom -online -f 1.15 + echo "::endgroup::" shell: bash - name: Run regression tests