Skip to content

Commit d141abb

Browse files
Fix one introduce another
1 parent 526cb71 commit d141abb

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

bridge/src/bridge_audio_track.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,11 @@ BridgeAudioTrack::BridgeAudioTrack(
3838
: name_(std::move(name)), sample_rate_(sample_rate),
3939
num_channels_(num_channels), source_(std::move(source)),
4040
track_(std::move(track)), publication_(std::move(publication)),
41-
participant_(participant) {}
41+
participant_(participant) {
42+
std::cout << "Bad name use: " << name << "\n"; // Should invoke clang-tidy warning
43+
44+
while(true); // should invoke another warning
45+
}
4246

4347
BridgeAudioTrack::~BridgeAudioTrack() { release(); }
4448

src/ffi_client.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ void FfiClient::PushEvent(const proto::FfiEvent &event) const {
244244

245245
void LivekitFfiCallback(const uint8_t *buf, size_t len) {
246246
proto::FfiEvent event;
247-
event.ParseFromArray(buf, len);
247+
event.ParseFromArray(buf, static_cast<int>(len)); // TODO: this fixes for now, what if len exceeds int?
248248

249249
FfiClient::instance().PushEvent(event);
250250
}

0 commit comments

Comments
 (0)