Skip to content

Commit 4d7b21e

Browse files
committed
AST Simplified toString
1 parent 62a28a3 commit 4d7b21e

File tree

9 files changed

+10
-53
lines changed

9 files changed

+10
-53
lines changed

liquidjava-verifier/src/main/java/liquidjava/diagnostics/errors/StateConflictError.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public StateConflictError(SourcePosition position, Expression state, Translation
1717
super("State Conflict Error",
1818
"Found multiple disjoint states in state transition: state transition can only go to one state of each state set",
1919
position, translationTable);
20-
this.state = state.toSimplifiedString();
20+
this.state = state.toString();
2121
}
2222

2323
public String getState() {

liquidjava-verifier/src/main/java/liquidjava/diagnostics/errors/StateRefinementError.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ public class StateRefinementError extends LJError {
1616

1717
public StateRefinementError(SourcePosition position, Expression expected, Expression found,
1818
TranslationTable translationTable, String customMessage) {
19-
super("State Refinement Error", String.format("Expected state %s but found %s", expected.toSimplifiedString(),
20-
found.toSimplifiedString()), position, translationTable, customMessage);
21-
this.expected = expected.toSimplifiedString();
22-
this.found = found.toSimplifiedString();
19+
super("State Refinement Error", String.format("Expected state %s but found %s", expected.toString(),
20+
found.toString()), position, translationTable, customMessage);
21+
this.expected = expected.toString();
22+
this.found = found.toString();
2323
}
2424

2525
public String getExpected() {

liquidjava-verifier/src/main/java/liquidjava/rj_language/ast/AliasInvocation.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,7 @@ public <T> T accept(ExpressionVisitor<T> visitor) throws LJError {
3131

3232
@Override
3333
public String toString() {
34-
return name + "(" + getArgs().stream().map(Expression::toString).collect(Collectors.joining(", ")) + ")";
35-
}
36-
37-
@Override
38-
public String toSimplifiedString() {
39-
return name + "(" + getArgs().stream().map(Expression::toSimplifiedString).collect(Collectors.joining(", "))
34+
return name + "(" + getArgs().stream().map(Expression::toString).collect(Collectors.joining(", "))
4035
+ ")";
4136
}
4237

liquidjava-verifier/src/main/java/liquidjava/rj_language/ast/BinaryExpression.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,6 @@ public String toString() {
5050
return getFirstOperand().toString() + " " + op + " " + getSecondOperand().toString();
5151
}
5252

53-
@Override
54-
public String toSimplifiedString() {
55-
return getFirstOperand().toSimplifiedString() + " " + op + " " + getSecondOperand().toSimplifiedString();
56-
}
57-
5853
@Override
5954
public void getVariableNames(List<String> toAdd) {
6055
getFirstOperand().getVariableNames(toAdd);

liquidjava-verifier/src/main/java/liquidjava/rj_language/ast/Expression.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,6 @@ public abstract class Expression {
3636

3737
public abstract String toString();
3838

39-
/**
40-
* Returns a simplified string representation of this expression with unqualified names (e.g.,
41-
* com.example.State.open => open Default implementation delegates to toString() Subclasses that contain qualified
42-
* names should override this method
43-
*
44-
* @return simplified string representation
45-
*/
46-
public String toSimplifiedString() {
47-
return toString();
48-
}
49-
5039
List<Expression> children = new ArrayList<>();
5140

5241
public void addChild(Expression e) {

liquidjava-verifier/src/main/java/liquidjava/rj_language/ast/FunctionInvocation.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,8 @@ public <T> T accept(ExpressionVisitor<T> visitor) throws LJError {
3737

3838
@Override
3939
public String toString() {
40-
return name + "(" + getArgs().stream().map(Expression::toString).collect(Collectors.joining(",")) + ")";
41-
}
42-
43-
@Override
44-
public String toSimplifiedString() {
45-
String simpleName = Utils.getSimpleName(name);
46-
return simpleName + "("
47-
+ getArgs().stream().map(Expression::toSimplifiedString).collect(Collectors.joining(",")) + ")";
40+
return Utils.getSimpleName(name) + "("
41+
+ getArgs().stream().map(Expression::toString).collect(Collectors.joining(",")) + ")";
4842
}
4943

5044
@Override

liquidjava-verifier/src/main/java/liquidjava/rj_language/ast/GroupExpression.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,7 @@ public <T> T accept(ExpressionVisitor<T> visitor) throws LJError {
2121
}
2222

2323
public String toString() {
24-
return "(" + getExpression().toString() + ")";
25-
}
26-
27-
@Override
28-
public String toSimplifiedString() {
29-
return getExpression().toSimplifiedString();
24+
return getExpression().toString();
3025
}
3126

3227
@Override

liquidjava-verifier/src/main/java/liquidjava/rj_language/ast/Ite.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,7 @@ public <T> T accept(ExpressionVisitor<T> visitor) throws LJError {
3232

3333
@Override
3434
public String toString() {
35-
return getCondition().toString() + "?" + getThen().toString() + ":" + getElse().toString();
36-
}
37-
38-
@Override
39-
public String toSimplifiedString() {
40-
return getCondition().toSimplifiedString() + "?" + getThen().toSimplifiedString() + ":"
41-
+ getElse().toSimplifiedString();
35+
return getCondition().toString() + " ? " + getThen().toString() + " : " + getElse().toString();
4236
}
4337

4438
@Override

liquidjava-verifier/src/main/java/liquidjava/rj_language/ast/UnaryExpression.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@ public String toString() {
3232
return op + getExpression().toString();
3333
}
3434

35-
@Override
36-
public String toSimplifiedString() {
37-
return op + getExpression().toSimplifiedString();
38-
}
39-
4035
@Override
4136
public void getVariableNames(List<String> toAdd) {
4237
getExpression().getVariableNames(toAdd);

0 commit comments

Comments
 (0)