Is this a new feature request?
Wanted change
Docker compose example should include a stop_grace_period
and docker commandline example should include a --stop-timeout parameter
, both with a reasonable default time and explanation for what it does.
Reason for change
See also #321 for a similar suggestion, making a new issue because it was locked due to inactivity.
The default of 10 seconds may not be enough time for qbittorrent to gracefully shut down and send a "stop" signal to all trackers, causing trackers to list inactive connections as active, at least for a while before it decides the last connection was too long ago. This can for example cause a tracker to list several connections on the same torrent for a short while after restarting the qbittorrent container. I'd also say it would be best practice to allow qbittorrent to gracefully shut down whenever possible either way to avoid any potential issues by forcibly shutting it down before it's ready.
These options are also included in the official qbittorrent-nox sample compose and docker command. (see here and here).
For reference it takes my container about 20 seconds to gracefully shut down with just over 500 torrents and 99 concurrent HTTP announces. The qbittorrent-nox container lists the example with a timer of 1800s.
Proposed code change
Documentation only.
Is this a new feature request?
Wanted change
Docker compose example should include a
stop_grace_periodand docker commandline example should include a
--stop-timeoutparameter, both with a reasonable default time and explanation for what it does.
Reason for change
See also #321 for a similar suggestion, making a new issue because it was locked due to inactivity.
The default of 10 seconds may not be enough time for qbittorrent to gracefully shut down and send a "stop" signal to all trackers, causing trackers to list inactive connections as active, at least for a while before it decides the last connection was too long ago. This can for example cause a tracker to list several connections on the same torrent for a short while after restarting the qbittorrent container. I'd also say it would be best practice to allow qbittorrent to gracefully shut down whenever possible either way to avoid any potential issues by forcibly shutting it down before it's ready.
These options are also included in the official
qbittorrent-noxsample compose and docker command. (see here and here).For reference it takes my container about 20 seconds to gracefully shut down with just over 500 torrents and 99 concurrent HTTP announces. The qbittorrent-nox container lists the example with a timer of 1800s.
Proposed code change
Documentation only.