Commit 8dfd1fd
You name
fix: plug several memory leaks across Nemo
Fix 7 memory leaks found via static analysis of the source code:
1. src/nemo-mime-actions.c (activate_activation_uris_ready_callback):
g_file_get_path() result for admin URI construction was never freed.
2. src/nemo-mime-actions.c (open_with_dialog_response_cb):
NemoFile from nemo_file_get_by_uri() was never unref'd after
launching the application.
3. src/nemo-mime-actions.c (run_open_with_dialog):
uri and mime_type strings were never freed after constructing
the application chooser widget.
4. src/nemo-open-with-main.c (on_dialog_response):
NemoFile from nemo_file_get_by_uri() was never unref'd after
launching the application.
5. src/nemo-window.c (nemo_window_show):
sidebar_id was overwritten by g_settings_get_string() without
freeing the previous value, leaking on every window show.
6. libnemo-private/nemo-file-conflict-dialog.c (file_list_ready_cb):
dest_name and dest_dir_name from nemo_file_get_display_name()
were never freed. Converted to g_autofree.
7. src/nemo-properties-window.c (create_volume_usage_widget):
uri from nemo_file_get_activation_uri() was never freed after
creating the GFile location.1 parent 0ba73e5 commit 8dfd1fd
5 files changed
Lines changed: 11 additions & 3 deletions
File tree
- libnemo-private
- src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
| 109 | + | |
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
130 | | - | |
131 | | - | |
| 130 | + | |
| 131 | + | |
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1149 | 1149 | | |
1150 | 1150 | | |
1151 | 1151 | | |
| 1152 | + | |
1152 | 1153 | | |
1153 | 1154 | | |
1154 | 1155 | | |
| |||
1179 | 1180 | | |
1180 | 1181 | | |
1181 | 1182 | | |
| 1183 | + | |
| 1184 | + | |
| 1185 | + | |
1182 | 1186 | | |
1183 | 1187 | | |
1184 | 1188 | | |
| |||
1713 | 1717 | | |
1714 | 1718 | | |
1715 | 1719 | | |
| 1720 | + | |
1716 | 1721 | | |
1717 | 1722 | | |
1718 | 1723 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| 83 | + | |
83 | 84 | | |
84 | 85 | | |
85 | 86 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3052 | 3052 | | |
3053 | 3053 | | |
3054 | 3054 | | |
| 3055 | + | |
3055 | 3056 | | |
3056 | 3057 | | |
3057 | 3058 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1623 | 1623 | | |
1624 | 1624 | | |
1625 | 1625 | | |
| 1626 | + | |
1626 | 1627 | | |
1627 | 1628 | | |
1628 | 1629 | | |
| |||
0 commit comments