Use only static binaries in AppImage

Author: TheAssassin

ci/build-static-binutils.sh

@@ -0,0 +1,59 @@
+#! /bin/bash
+
+set -e
+set -x
+
+INSTALL_DESTDIR="$1"
+
+if [[ "$INSTALL_DESTDIR" == "" ]]; then
+    echo "Error: build dir $BUILD_DIR does not exist" 1>&2
+    exit 1
+fi
+
+# support cross-compilation for 32-bit ISAs
+case "$ARCH" in
+    "x86_64"|"amd64")
+        ;;
+    "i386"|"i586"|"i686")
+        export CFLAGS="-m32"
+        export CXXFLAGS="-m32"
+        ;;
+    *)
+        echo "Error: unsupported architecture: $ARCH"
+        exit 1
+        ;;
+esac
+
+# use RAM disk if possible
+if [ "$CI" == "" ] && [ -d /dev/shm ]; then
+    TEMP_BASE=/dev/shm
+else
+    TEMP_BASE=/tmp
+fi
+
+cleanup () {
+    if [ -d "$BUILD_DIR" ]; then
+        rm -rf "$BUILD_DIR"
+    fi
+}
+
+trap cleanup EXIT
+
+BUILD_DIR=$(mktemp -d -p "$TEMP_BASE" linuxdeploy-build-XXXXXX)
+
+pushd "$BUILD_DIR"
+
+# fetch source code
+wget https://ftp.gnu.org/gnu/binutils/binutils-2.35.tar.xz -O- | tar xJ --strip-components=1
+
+# configure static build
+# inspired by https://github.com/andrew-d/static-binaries/blob/master/binutils/build.sh
+./configure --prefix=/usr --disable-nls --enable-static-link --disable-shared-plugins --disable-dynamicplugin --disable-tls --disable-pie
+
+# citing the script linked above: "This strange dance is required to get things to be statically linked."
+make -j "$(nproc)"
+make clean
+make -j "$(nproc)" LDFLAGS="-all-static"
+
+# install into user-specified destdir
+make install DESTDIR="$(readlink -f "$INSTALL_DESTDIR")"

ci/build-static-patchelf.sh

@@ -0,0 +1,62 @@
+#! /bin/bash
+
+set -e
+set -x
+
+INSTALL_DESTDIR="$1"
+
+if [[ "$INSTALL_DESTDIR" == "" ]]; then
+    echo "Error: build dir $BUILD_DIR does not exist" 1>&2
+    exit 1
+fi
+
+# support cross-compilation for 32-bit ISAs
+case "$ARCH" in
+    "x86_64"|"amd64")
+        ;;
+    "i386"|"i586"|"i686")
+        export CFLAGS="-m32"
+        export CXXFLAGS="-m32"
+        ;;
+    *)
+        echo "Error: unsupported architecture: $ARCH"
+        exit 1
+        ;;
+esac
+
+# use RAM disk if possible
+if [ "$CI" == "" ] && [ -d /dev/shm ]; then
+    TEMP_BASE=/dev/shm
+else
+    TEMP_BASE=/tmp
+fi
+
+cleanup () {
+    if [ -d "$BUILD_DIR" ]; then
+        rm -rf "$BUILD_DIR"
+    fi
+}
+
+trap cleanup EXIT
+
+BUILD_DIR=$(mktemp -d -p "$TEMP_BASE" linuxdeploy-build-XXXXXX)
+
+pushd "$BUILD_DIR"
+
+# fetch source code
+git clone https://github.com/NixOS/patchelf.git .
+
+# cannot use -b since it's not supported in really old versions of git
+git checkout 0.8
+
+# prepare configure script
+./bootstrap.sh
+
+# configure static build
+env LDFLAGS="-static -static-libgcc -static-libstdc++" ./configure --prefix=/usr
+
+# build binary
+make -j "$(nproc)"
+
+# install into user-specified destdir
+make install DESTDIR="$INSTALL_DESTDIR"

ci/build.sh

@@ -43,21 +43,13 @@ ctest -V --no-tests=error
 
 make install DESTDIR=AppDir
 
-strip_path=$(which strip)
+# build patchelf
+"$REPO_ROOT"/ci/build-static-patchelf.sh "$(readlink -f out/)"
+patchelf_path="$(readlink -f out/usr/bin/patchelf)"
 
-if [ "$ARCH" == "i386" ]; then
-    # download i386 strip for i386 AppImage
-    # https://github.com/linuxdeploy/linuxdeploy/issues/59
-    wget http://security.ubuntu.com/ubuntu/pool/main/b/binutils/binutils-multiarch_2.24-5ubuntu14.2_i386.deb
-    echo "0106f170cebf5800e863a558cad039e4f16a76d3424ae943209c3f6b0cacd511  binutils-multiarch_2.24-5ubuntu14.2_i386.deb" | sha256sum -c
-    wget http://security.ubuntu.com/ubuntu/pool/main/b/binutils/binutils-multiarch-dev_2.24-5ubuntu14.2_i386.deb
-    echo "ed9ca4fbbf492233228f79fae6b349a2ed2ee3e0927bdc795425fccf5fae648e  binutils-multiarch-dev_2.24-5ubuntu14.2_i386.deb" | sha256sum -c
-    dpkg -x binutils-multiarch_2.24-5ubuntu14.2_i386.deb out/
-    dpkg -x binutils-multiarch-dev_2.24-5ubuntu14.2_i386.deb out/
-    rm binutils-multiarch*.deb
-    strip_path=$(readlink -f out/usr/bin/strip)
-    export LD_LIBRARY_PATH=$(readlink -f out/usr/lib)
-fi
+# build custom strip
+"$REPO_ROOT"/ci/build-static-binutils.sh "$(readlink -f out/)"
+strip_path="$(readlink -f out/usr/bin/strip)"
 
 export UPD_INFO="gh-releases-zsync|linuxdeploy|linuxdeploy-plugin-qt|continuous|linuxdeploy-plugin-qt-$ARCH.AppImage"
 
@@ -66,7 +58,7 @@ chmod +x linuxdeploy*.AppImage
 ./linuxdeploy-"$ARCH".AppImage --appdir AppDir \
     -d "$REPO_ROOT"/resources/linuxdeploy-plugin-qt.desktop \
     -i "$REPO_ROOT"/resources/linuxdeploy-plugin-qt.svg \
-    -e $(which patchelf) \
+    -e "$patchelf_path" \
     -e "$strip_path" \
     --output appimage