Skip to content

Commit f884b0e

Browse files
committed
Remove some redundancies in test code
1 parent 31718ac commit f884b0e

File tree

1 file changed

+3
-43
lines changed

1 file changed

+3
-43
lines changed

tests/test_desktopfilereader.cpp

Lines changed: 3 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -415,51 +415,11 @@ TEST_F(DesktopFileReaderTest, testReadLocalizedEntriesWithoutProperLocalizationS
415415
}
416416

417417
TEST_F(DesktopFileReaderTest, testBrokenLocalizedKeys) {
418-
{
419-
std::stringstream ins;
420-
ins << "[Desktop Entry]" << std::endl
421-
<< "test]de[=test" << std::endl;
422-
423-
EXPECT_THROW(DesktopFileReader reader(ins), ParseError);
424-
}
425-
426-
{
418+
for (std::string key : {"test]de[", "test[de]]", "test[[de]", "test[]de", "test[de", "testde]"}) {
427419
std::stringstream ins;
428420
ins << "[Desktop Entry]" << std::endl
429-
<< "test[de]]=test" << std::endl;
421+
<< key << "=test" << std::endl;
430422

431-
EXPECT_THROW(DesktopFileReader reader(ins), ParseError);
432-
}
433-
434-
{
435-
std::stringstream ins;
436-
ins << "[Desktop Entry]" << std::endl
437-
<< "test[[de]=test" << std::endl;
438-
439-
EXPECT_THROW(DesktopFileReader reader(ins), ParseError);
440-
}
441-
442-
{
443-
std::stringstream ins;
444-
ins << "[Desktop Entry]" << std::endl
445-
<< "test[]de=test" << std::endl;
446-
447-
EXPECT_THROW(DesktopFileReader reader(ins), ParseError);
448-
}
449-
450-
{
451-
std::stringstream ins;
452-
ins << "[Desktop Entry]" << std::endl
453-
<< "test[de=test" << std::endl;
454-
455-
EXPECT_THROW(DesktopFileReader reader(ins), ParseError);
456-
}
457-
458-
{
459-
std::stringstream ins;
460-
ins << "[Desktop Entry]" << std::endl
461-
<< "testde]=test" << std::endl;
462-
463-
EXPECT_THROW(DesktopFileReader reader(ins), ParseError);
423+
EXPECT_THROW(DesktopFileReader reader(ins), ParseError) << "key: " << key;
464424
}
465425
}

0 commit comments

Comments
 (0)