test_rgw_admin_meta.cc: init non-static members in ctor

dalgaaf · dalgaaf · commit 4e0ea7588d51 · 2015-07-17T10:50:45.000+02:00
Fix for: CID 1054872 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR) uninit_member: Non-static class member curl_inst is not initialized in this constructor nor in any functions that it calls. uninit_member: Non-static class member resp_code is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
diff --git a/src/test/test_rgw_admin_meta.cc b/src/test/test_rgw_admin_meta.cc
@@ -82,7 +82,7 @@ class test_helper {
     string *resp_data;
     unsigned resp_code;
   public:
-    test_helper() : resp_data(NULL){
+    test_helper() : curl_inst(0), resp_data(NULL), resp_code(0) {
       curl_global_init(CURL_GLOBAL_ALL);
     }
     ~test_helper(){

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ class test_helper {`
`82`	`82`	`string *resp_data;`
`83`	`83`	`unsigned resp_code;`
`84`	`84`	`public:`
`85`		`- test_helper() : resp_data(NULL){`
	`85`	`+ test_helper() : curl_inst(0), resp_data(NULL), resp_code(0) {`
`86`	`86`	`curl_global_init(CURL_GLOBAL_ALL);`
`87`	`87`	`}`
`88`	`88`	`~test_helper(){`