Add interfaces argument to instance_create

Author: lgarber-akamai

linode_api4/groups/linode.py

@@ -1,7 +1,7 @@
 import base64
 import os
 from collections.abc import Iterable
-from typing import Any, Dict, Optional, Union
+from typing import Any, Dict, List, Optional, Union
 
 from linode_api4.common import load_and_validate_keys
 from linode_api4.errors import UnexpectedResponseError
@@ -13,6 +13,8 @@
     InstanceDiskEncryptionType,
     InterfaceGeneration,
     Kernel,
+    LinodeInterface,
+    NetworkInterface,
     PlacementGroup,
     StackScript,
     Type,
@@ -154,6 +156,9 @@ def instance_create(
                 int,
             ]
         ] = None,
+        interfaces: Optional[
+            List[Union[LinodeInterface, NetworkInterface, Dict[str, Any]],]
+        ] = None,
         interface_generation: Optional[Union[InterfaceGeneration, str]] = None,
         network_helper: Optional[bool] = None,
         **kwargs,
@@ -299,6 +304,8 @@ def instance_create(
         :type interfaces: list[ConfigInterface] or list[dict[str, Any]]
         :param placement_group: A Placement Group to create this Linode under.
         :type placement_group: Union[InstancePlacementGroupAssignment, PlacementGroup, Dict[str, Any], int]
+        :param interfaces: The interfaces to create this Linode with.
+        :type interfaces: List of LinodeInterface, NetworkInterface (deprecated), or Dict[str, Any]
         :param interface_generation: The generation of network interfaces this Linode uses.
         :type interface_generation: InterfaceGeneration or str
         :param network_helper: Whether this instance should have Network Helper enabled.
@@ -343,6 +350,7 @@ def instance_create(
                 if placement_group
                 else None
             ),
+            "interfaces": interfaces,
             "interface_generation": interface_generation,
             "network_helper": network_helper,
         }

test/unit/objects/linode_interface_test.py

@@ -1,7 +1,6 @@
 from datetime import datetime
 from test.unit.base import ClientBaseCase
 
-
 from linode_api4 import (
     LinodeInterface,
     LinodeInterfacePublicIPv4AddressUpdateOptions,
@@ -201,7 +200,6 @@ def test_update_vpc(self):
 
             assert m.called
 
-            print(m.call_data)
             assert m.call_data == {
                 "default_route": {
                     "ipv4": False,
@@ -220,3 +218,23 @@ def test_update_vpc(self):
                     },
                 },
             }
+
+    def test_update_vlan(self):
+        iface = LinodeInterface(self.client, 789, 124)
+
+        self.assert_linode_124_interface_789(iface)
+
+        iface.vlan.ipam_address = "10.0.0.2/24"
+        iface.vlan.vlan_label = "my_vlan_updated"
+
+        with self.mock_put("/linode/instances/124/interfaces/789") as m:
+            iface.save()
+
+            assert m.called
+
+            assert m.call_data == {
+                "vlan": {
+                    "vlan_label": "my_vlan_updated",
+                    "ipam_address": "10.0.0.1/24",
+                },
+            }