Merge branch 'proj/rdma-interfaces' into feature/TPT-4462-add-int-tests-for-rdma-interfaces

Author: mawilk90

linode_api4/objects/linode.py

@@ -2124,6 +2124,13 @@ def interface_create(
         :rtype: LinodeInterface
         """
 
+        if kwargs.get("rdma_vpc") is not None:
+            raise ValueError(
+                "RDMA VPC interfaces (rdma_vpc) cannot be added via "
+                "interface_create(). They may only be specified at instance "
+                "creation time via LinodeGroup.instance_create()."
+            )
+
         params = {
             "firewall_id": firewall,
             "default_route": default_route,

test/unit/groups/linode_test.py

@@ -154,7 +154,7 @@ def test_instance_create_with_interfaces_linode_rdma(self):
             }
 
             assert m.call_data["interfaces"][0] == {
-                "firewall_id": -1,
+                "firewall_id": None,
                 "rdma_vpc": {
                     "subnet_id": 1234,
                     "ipv4": {

test/unit/objects/linode_interface_test.py

@@ -82,7 +82,7 @@ def build_interface_options_vlan():
 
 def build_interface_options_rdma_vpc():
     return LinodeInterfaceOptions(
-        firewall_id=-1,
+        firewall_id=None,
         rdma_vpc=LinodeInterfaceRDMAVPCOptions(
             subnet_id=1234,
             ipv4=LinodeInterfaceRDMAVPCIPv4Options(

test/unit/objects/linode_test.py

@@ -3,6 +3,7 @@
 from test.unit.objects.linode_interface_test import (
     LinodeInterfaceTest,
     build_interface_options_public,
+    build_interface_options_rdma_vpc,
     build_interface_options_vlan,
     build_interface_options_vpc,
 )
@@ -756,6 +757,21 @@ def test_create_interface_vlan(self):
 
         LinodeInterfaceTest.assert_linode_124_interface_789(result)
 
+    def test_create_interface_rdma_vpc_rejected(self):
+        """
+        Tests that attempting to create an RDMA VPC interface via
+        interface_create() raises a clear ValueError instead of sending an
+        invalid request to the API.
+        """
+        instance = Instance(self.client, 124)
+
+        iface = build_interface_options_rdma_vpc()
+
+        with self.assertRaises(ValueError) as ctx:
+            instance.interface_create(**vars(iface))
+
+        assert "rdma_vpc" in str(ctx.exception)
+
 
 class DiskTest(ClientBaseCase):
     """