Skip to content

Commit 42bd110

Browse files
committed
Address Copilot remarks
1 parent 155d377 commit 42bd110

2 files changed

Lines changed: 10 additions & 5 deletions

File tree

test/integration/conftest.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,11 @@ def test_monitor_client(get_monitor_token_for_db_entities):
733733
@pytest.fixture
734734
def create_reserved_ip(test_linode_client):
735735
client = test_linode_client
736-
region = get_region(client, {"Linodes", "Cloud Firewall"}, site_type="core")
736+
region = get_region(
737+
client,
738+
{"Linodes", "Cloud Firewall", "Nodebalancers"},
739+
site_type="core"
740+
)
737741
reserved_ip = client.networking.reserved_ip_create(
738742
region=region, tags=["test"]
739743
)

test/integration/models/networking/test_networking.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -444,9 +444,6 @@ def test_create_reserved_ip_assigned(
444444
verify_reserved_ip_assigned(reserved_ip, linode)
445445
assert sorted(reserved_ip.tags) == ["assigned", "test"]
446446

447-
# ips_list = client.networking.ips()
448-
# assert reserved_ip.address in [ip.address for ip in ips_list]
449-
450447
reserved_ips_list = client.networking.reserved_ips()
451448
assert reserved_ip.address in [ip.address for ip in reserved_ips_list]
452449

@@ -470,7 +467,7 @@ def test_create_reserved_ip_assigned(
470467
assert not any([ip.tags for ip in linode_ips]) # Tags should be removed
471468

472469

473-
def test_get_reserved_ip_types(test_linode_client, create_reserved_ip):
470+
def test_get_reserved_ip_types(test_linode_client):
474471
client = test_linode_client
475472
endpoint = client.base_url + "/networking/reserved/ips/types"
476473
types = requests.get(endpoint).json()[
@@ -513,6 +510,10 @@ def test_create_reserved_ip_with_allocate(
513510

514511
assert reserved_ip.tags == []
515512

513+
# clean-up
514+
reserved_ip = client.load(ReservedIPAddress, reserved_ip.address)
515+
reserved_ip.delete()
516+
516517

517518
def test_reserve_ephemeral_ip(test_linode_client, create_linode):
518519
client = test_linode_client

0 commit comments

Comments
 (0)