From cf09bca4b7364bbed906ef4fc5d6428ee06c56b8 Mon Sep 17 00:00:00 2001 From: Linlin Sun Date: Sun, 8 Oct 2023 22:28:25 -0700 Subject: [PATCH 1/3] Casue regression to test the github workflow. --- .../workflows/ion-java-performance-regression-detector.yml | 6 ++++-- .../amazon/ion/impl/_Private_IonBinaryWriterBuilder.java | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ion-java-performance-regression-detector.yml b/.github/workflows/ion-java-performance-regression-detector.yml index fd7f3a2e54..8980181d1a 100644 --- a/.github/workflows/ion-java-performance-regression-detector.yml +++ b/.github/workflows/ion-java-performance-regression-detector.yml @@ -113,8 +113,10 @@ jobs: working-directory: ion-java-benchmark-cli run: a=$(java -jar target/ion-java-benchmark-cli-0.0.1-SNAPSHOT-jar-with-dependencies.jar compare --benchmark-result-previous /home/runner/work/ion-java/ion-java/benchmarkresults/before.ion --benchmark-result-new /home/runner/work/ion-java/ion-java/benchmarkresults/after.ion) - echo ${a} >> $GITHUB_STEP_SUMMARY - + if [ ! -z "$a" ]; then + echo "${a}" >> $GITHUB_STEP_SUMMARY + exit 1 + fi diff --git a/src/com/amazon/ion/impl/_Private_IonBinaryWriterBuilder.java b/src/com/amazon/ion/impl/_Private_IonBinaryWriterBuilder.java index 80f9d8d1dd..85e4714fef 100644 --- a/src/com/amazon/ion/impl/_Private_IonBinaryWriterBuilder.java +++ b/src/com/amazon/ion/impl/_Private_IonBinaryWriterBuilder.java @@ -53,7 +53,7 @@ private _Private_IonBinaryWriterBuilder() myBinaryWriterBuilder = _Private_IonManagedBinaryWriterBuilder .create(AllocatorMode.POOLED) - .withPaddedLengthPreallocation(1) + .withPaddedLengthPreallocation(0) ; } From 3027c373639101bf45a35f1926c28ad158217cfa Mon Sep 17 00:00:00 2001 From: linlin-s Date: Sun, 8 Oct 2023 23:03:34 -0700 Subject: [PATCH 2/3] Update ion-java-performance-regression-detector.yml --- .../ion-java-performance-regression-detector.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ion-java-performance-regression-detector.yml b/.github/workflows/ion-java-performance-regression-detector.yml index 8980181d1a..d04623ab63 100644 --- a/.github/workflows/ion-java-performance-regression-detector.yml +++ b/.github/workflows/ion-java-performance-regression-detector.yml @@ -111,12 +111,10 @@ jobs: #Detect regression - name: Detect regression working-directory: ion-java-benchmark-cli - run: + run: | a=$(java -jar target/ion-java-benchmark-cli-0.0.1-SNAPSHOT-jar-with-dependencies.jar compare --benchmark-result-previous /home/runner/work/ion-java/ion-java/benchmarkresults/before.ion --benchmark-result-new /home/runner/work/ion-java/ion-java/benchmarkresults/after.ion) - if [ ! -z "$a" ]; then - echo "${a}" >> $GITHUB_STEP_SUMMARY - exit 1 - fi + if [ ! -z "$a" ]; then echo "${a}" >> $GITHUB_STEP_SUMMARY; fi + exit 1 From 84305ef79005b4240739b46e19db31d8368aa27e Mon Sep 17 00:00:00 2001 From: linlin-s Date: Wed, 11 Oct 2023 10:29:33 -0700 Subject: [PATCH 3/3] Update ion-java-performance-regression-detector.yml --- .github/workflows/ion-java-performance-regression-detector.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ion-java-performance-regression-detector.yml b/.github/workflows/ion-java-performance-regression-detector.yml index d04623ab63..2a40a473b4 100644 --- a/.github/workflows/ion-java-performance-regression-detector.yml +++ b/.github/workflows/ion-java-performance-regression-detector.yml @@ -113,8 +113,7 @@ jobs: working-directory: ion-java-benchmark-cli run: | a=$(java -jar target/ion-java-benchmark-cli-0.0.1-SNAPSHOT-jar-with-dependencies.jar compare --benchmark-result-previous /home/runner/work/ion-java/ion-java/benchmarkresults/before.ion --benchmark-result-new /home/runner/work/ion-java/ion-java/benchmarkresults/after.ion) - if [ ! -z "$a" ]; then echo "${a}" >> $GITHUB_STEP_SUMMARY; fi - exit 1 + if [ ! -z "$a" ]; then echo "${a}" >> $GITHUB_STEP_SUMMARY; exit 1; fi