From 267cf79abaef93ef121994ba44ca21ef1b2d924c Mon Sep 17 00:00:00 2001 From: Linlin Sun Date: Thu, 12 Jan 2023 15:06:11 -0800 Subject: [PATCH 01/10] Add extra step to check if there is any source code changed in the incoming pull request. Signed-off-by: Linlin Sun --- ...n-java-performance-regression-detector.yml | 31 ++++++++++++++++--- 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ion-java-performance-regression-detector.yml b/.github/workflows/ion-java-performance-regression-detector.yml index 277ccff505..de943f25ee 100644 --- a/.github/workflows/ion-java-performance-regression-detector.yml +++ b/.github/workflows/ion-java-performance-regression-detector.yml @@ -6,9 +6,32 @@ name: Ion Java performance regression detector on: [pull_request] jobs: + check-PR-content: + name: Check PR Content + + runs-on: ubuntu-latest + + outputs: + output1: ${{ steps.check-content.outputs.result }} + + steps: + - name: Checkout the incoming pull request + uses: actions/checkout@v3 + with: + ref: ${{ github.event.pull_request.head.sha }} + fetch-depth: 0 + path: ion-java-new + + - name: Check the content of the last commit + id: check-content + run: | + cd ion-java-new + if [[ $(git log -1 --name-only) == *"src/"* ]]; then echo "result=pass" >> $GITHUB_OUTPUT; else echo "result=fail" >> $GITHUB_OUTPUT; fi + detect-regression: name: Detect Regression - + needs: check-PR-content + if: ${{ needs.check-PR-content.outputs.output1 == 'pass' }} runs-on: ubuntu-latest steps: @@ -18,7 +41,7 @@ jobs: java-version: 1.8 - name: Checkout ion-java from the new commit. - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ github.event.pull_request.head.sha }} path: ion-java-new @@ -27,7 +50,7 @@ jobs: run: cd ion-java-new && git submodule init && git submodule update && ./gradlew clean publishToMavenLocal - name: Checkout ion-java-benchmark-cli - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: repository: amzn/ion-java-benchmark-cli ref: master @@ -70,7 +93,7 @@ jobs: run : rm -r /home/runner/.m2 - name: Checkout the current commit - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: repository: amzn/ion-java ref: master From 1424c5cf8be1308b30641874fc1b3de34cfbbe23 Mon Sep 17 00:00:00 2001 From: Linlin Sun Date: Tue, 17 Jan 2023 10:43:38 -0800 Subject: [PATCH 02/10] Apply PR-content-check to ion-test-driver workflow. --- .github/workflows/PR-content-check.yml | 26 ++++++++++++++++ ...n-java-performance-regression-detector.yml | 30 ++++--------------- .github/workflows/ion-test-driver.yml | 7 ++++- 3 files changed, 38 insertions(+), 25 deletions(-) create mode 100644 .github/workflows/PR-content-check.yml diff --git a/.github/workflows/PR-content-check.yml b/.github/workflows/PR-content-check.yml new file mode 100644 index 0000000000..382d48850d --- /dev/null +++ b/.github/workflows/PR-content-check.yml @@ -0,0 +1,26 @@ +# This workflow will build a Java project with Maven +# For more information see: https://help.github.com/actions/language-and-framework-guides/building-and-testing-java-with-maven + +name: PR Content Check + +on: [pull_request] + +jobs: + check-PR-content: + name: Check PR Content + + runs-on: ubuntu-latest + + steps: + - name: Checkout the incoming pull request + uses: actions/checkout@v3 + with: + ref: ${{ github.event.pull_request.head.sha }} + fetch-depth: 0 + path: ion-java-new + + - name: Check the content of the last commit + id: check-content + run: | + cd ion-java-new + if [[ $(git log -1 --name-only) == *"src/"* ]]; then echo "result=pass"; else exit 1; fi \ No newline at end of file diff --git a/.github/workflows/ion-java-performance-regression-detector.yml b/.github/workflows/ion-java-performance-regression-detector.yml index de943f25ee..bf5d1acada 100644 --- a/.github/workflows/ion-java-performance-regression-detector.yml +++ b/.github/workflows/ion-java-performance-regression-detector.yml @@ -3,35 +3,17 @@ name: Ion Java performance regression detector -on: [pull_request] +on: + workflow_run: + workflows: [ PR Content Check ] + types: + - completed jobs: - check-PR-content: - name: Check PR Content - - runs-on: ubuntu-latest - - outputs: - output1: ${{ steps.check-content.outputs.result }} - - steps: - - name: Checkout the incoming pull request - uses: actions/checkout@v3 - with: - ref: ${{ github.event.pull_request.head.sha }} - fetch-depth: 0 - path: ion-java-new - - - name: Check the content of the last commit - id: check-content - run: | - cd ion-java-new - if [[ $(git log -1 --name-only) == *"src/"* ]]; then echo "result=pass" >> $GITHUB_OUTPUT; else echo "result=fail" >> $GITHUB_OUTPUT; fi - detect-regression: name: Detect Regression needs: check-PR-content - if: ${{ needs.check-PR-content.outputs.output1 == 'pass' }} + if: ${{ github.event.workflow_run.conclusion == 'success' }} runs-on: ubuntu-latest steps: diff --git a/.github/workflows/ion-test-driver.yml b/.github/workflows/ion-test-driver.yml index e39846aed3..0bb13f438b 100644 --- a/.github/workflows/ion-test-driver.yml +++ b/.github/workflows/ion-test-driver.yml @@ -1,10 +1,15 @@ name: ion-test-driver -on: [pull_request] +on: + workflow_run: + workflows: [ PR Content Check ] + types: + - completed jobs: ion-test-driver: runs-on: macos-10.15 + if: ${{ github.event.workflow_run.conclusion == 'success' }} steps: - name: Checkout ion-java uses: actions/checkout@master From 86e207acebaf1ea2a1430b05656613aec190fbed Mon Sep 17 00:00:00 2001 From: Linlin Sun Date: Wed, 18 Jan 2023 16:57:21 -0800 Subject: [PATCH 03/10] Update the if condition. --- .github/workflows/PR-content-check.yml | 2 +- .github/workflows/ion-java-performance-regression-detector.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/PR-content-check.yml b/.github/workflows/PR-content-check.yml index 382d48850d..5416be53e2 100644 --- a/.github/workflows/PR-content-check.yml +++ b/.github/workflows/PR-content-check.yml @@ -23,4 +23,4 @@ jobs: id: check-content run: | cd ion-java-new - if [[ $(git log -1 --name-only) == *"src/"* ]]; then echo "result=pass"; else exit 1; fi \ No newline at end of file + if [[ $(git log -1 --name-only) == *"src/"* ]]; then echo "result=pass" >> $GITHUB_ENV; else echo "result=fail" >> $GITHUB_ENV; fi \ No newline at end of file diff --git a/.github/workflows/ion-java-performance-regression-detector.yml b/.github/workflows/ion-java-performance-regression-detector.yml index bf5d1acada..cf83a55b35 100644 --- a/.github/workflows/ion-java-performance-regression-detector.yml +++ b/.github/workflows/ion-java-performance-regression-detector.yml @@ -13,7 +13,7 @@ jobs: detect-regression: name: Detect Regression needs: check-PR-content - if: ${{ github.event.workflow_run.conclusion == 'success' }} + if: ${{ jobs.check-PR-content.steps.result == 'pass' }} runs-on: ubuntu-latest steps: From a970a0f79599d58c76b23362056920040b97be80 Mon Sep 17 00:00:00 2001 From: Linlin Sun Date: Thu, 19 Jan 2023 13:12:43 -0800 Subject: [PATCH 04/10] update --- .github/workflows/PR-content-check.yml | 5 ++--- .../workflows/ion-java-performance-regression-detector.yml | 3 ++- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/PR-content-check.yml b/.github/workflows/PR-content-check.yml index 5416be53e2..a3ac1a1212 100644 --- a/.github/workflows/PR-content-check.yml +++ b/.github/workflows/PR-content-check.yml @@ -8,9 +8,8 @@ on: [pull_request] jobs: check-PR-content: name: Check PR Content - runs-on: ubuntu-latest - + continue-on-error: true steps: - name: Checkout the incoming pull request uses: actions/checkout@v3 @@ -23,4 +22,4 @@ jobs: id: check-content run: | cd ion-java-new - if [[ $(git log -1 --name-only) == *"src/"* ]]; then echo "result=pass" >> $GITHUB_ENV; else echo "result=fail" >> $GITHUB_ENV; fi \ No newline at end of file + if [[ $(git log -1 --name-only) == *"src/"* ]]; then echo "result=pass"; else exit 1; fi \ No newline at end of file diff --git a/.github/workflows/ion-java-performance-regression-detector.yml b/.github/workflows/ion-java-performance-regression-detector.yml index cf83a55b35..a5ff80fd52 100644 --- a/.github/workflows/ion-java-performance-regression-detector.yml +++ b/.github/workflows/ion-java-performance-regression-detector.yml @@ -13,7 +13,8 @@ jobs: detect-regression: name: Detect Regression needs: check-PR-content - if: ${{ jobs.check-PR-content.steps.result == 'pass' }} + if: ${{ github.event.workflow_run.conclusion == 'success' }} + runs-on: ubuntu-latest steps: From 4c518c2a491c2a7ac2c6fb92037832815866db3c Mon Sep 17 00:00:00 2001 From: linlin-s Date: Thu, 19 Jan 2023 14:08:13 -0800 Subject: [PATCH 05/10] Update on PR-content-check --- .github/workflows/PR-content-check.yml | 4 ++-- .../workflows/ion-java-performance-regression-detector.yml | 1 - .github/workflows/ion-test-driver.yml | 1 + 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/PR-content-check.yml b/.github/workflows/PR-content-check.yml index a3ac1a1212..490c549311 100644 --- a/.github/workflows/PR-content-check.yml +++ b/.github/workflows/PR-content-check.yml @@ -9,7 +9,6 @@ jobs: check-PR-content: name: Check PR Content runs-on: ubuntu-latest - continue-on-error: true steps: - name: Checkout the incoming pull request uses: actions/checkout@v3 @@ -22,4 +21,5 @@ jobs: id: check-content run: | cd ion-java-new - if [[ $(git log -1 --name-only) == *"src/"* ]]; then echo "result=pass"; else exit 1; fi \ No newline at end of file + if [[ $(git log -1 --name-only) == *"src/"* ]]; then echo "result=pass"; else exit 1; fi + continue-on-error: true \ No newline at end of file diff --git a/.github/workflows/ion-java-performance-regression-detector.yml b/.github/workflows/ion-java-performance-regression-detector.yml index a5ff80fd52..bf5d1acada 100644 --- a/.github/workflows/ion-java-performance-regression-detector.yml +++ b/.github/workflows/ion-java-performance-regression-detector.yml @@ -14,7 +14,6 @@ jobs: name: Detect Regression needs: check-PR-content if: ${{ github.event.workflow_run.conclusion == 'success' }} - runs-on: ubuntu-latest steps: diff --git a/.github/workflows/ion-test-driver.yml b/.github/workflows/ion-test-driver.yml index 0bb13f438b..537b46da21 100644 --- a/.github/workflows/ion-test-driver.yml +++ b/.github/workflows/ion-test-driver.yml @@ -18,6 +18,7 @@ jobs: ref: master path: ion-java + - name: Checkout ion-test-driver uses: actions/checkout@master with: From 356e729fb5895699074766a9c995cb703cd8f918 Mon Sep 17 00:00:00 2001 From: Linlin Sun Date: Thu, 19 Jan 2023 14:12:42 -0800 Subject: [PATCH 06/10] Source code changes. --- ...n-java-performance-regression-detector.yml | 24 ++++++++++++------- src/com/amazon/ion/apps/EncodeApp.java | 1 - 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ion-java-performance-regression-detector.yml b/.github/workflows/ion-java-performance-regression-detector.yml index bf5d1acada..746232c2e6 100644 --- a/.github/workflows/ion-java-performance-regression-detector.yml +++ b/.github/workflows/ion-java-performance-regression-detector.yml @@ -14,6 +14,8 @@ jobs: name: Detect Regression needs: check-PR-content if: ${{ github.event.workflow_run.conclusion == 'success' }} + outputs: + output1: ${{ steps.regression_result.outputs.result }} runs-on: ubuntu-latest steps: @@ -121,7 +123,7 @@ jobs: run: | result=true cd benchmarkResults && for FILE in *; do message=$(java -jar /home/runner/work/ion-java/ion-java/ion-java-benchmark-cli/target/ion-java-benchmark-cli-0.0.1-SNAPSHOT-jar-with-dependencies.jar compare --benchmark-result-previous $FILE/previous.ion --benchmark-result-new $FILE/new.ion $FILE/report.ion | tee /dev/stderr) && if [ "$message" != "no regression detected" ]; then result=false; fi; done - echo "::set-output name=regression-result::$result" + echo "regression-result=$result" >> $GITHUB_OUTPUT if [ "$result" = "true" ]; then echo "No regression detected!" >> $GITHUB_STEP_SUMMARY; fi - name: Upload comparison reports to the benchmark results directory @@ -130,10 +132,16 @@ jobs: name: Benchmark result path: benchmarkResults - - name: Fail the workflow if regression happened - env: - regression_detect: ${{steps.regression_result.outputs.regression-result}} - if: ${{ env.regression_detect == 'false' }} - run: | - cd benchmarkResults && echo "| Benchmark command | GC Allocation Rate | Heap Usage | Speed |" >> $GITHUB_STEP_SUMMARY && echo "| ----------- | ----------- |----------- | ----------- |" >> $GITHUB_STEP_SUMMARY && for FILE in *; do regressionDetection=$(java -jar /home/runner/work/ion-java/ion-java/ion-java-benchmark-cli/target/ion-java-benchmark-cli-0.0.1-SNAPSHOT-jar-with-dependencies.jar compare --benchmark-result-previous $FILE/previous.ion --benchmark-result-new $FILE/new.ion $FILE/report.ion) && if [ "$regressionDetection" != "no regression detected" ]; then command=$(echo $FILE | sed "s/_/ /g") && read gc heapUsage speed <<< $( echo ${regressionDetection} | awk -F", " '{print $1" "$2" "$3}' ) && echo "|$command|$gc|$heapUsage|$speed|" >> $GITHUB_STEP_SUMMARY; fi; done - exit 1 \ No newline at end of file + output-result: + name: Output Results + needs: detect-regression + runs-on: ubuntu-latest + + steps: + - name: Fail the workflow if regression happened + env: + regression_detect: ${{needs.detect-regression.outputs.output1}} + if: ${{ env.regression_detect == 'false' }} + run: | + cd benchmarkResults && echo "| Benchmark command | GC Allocation Rate | Heap Usage | Speed |" >> $GITHUB_STEP_SUMMARY && echo "| ----------- | ----------- |----------- | ----------- |" >> $GITHUB_STEP_SUMMARY && for FILE in *; do regressionDetection=$(java -jar /home/runner/work/ion-java/ion-java/ion-java-benchmark-cli/target/ion-java-benchmark-cli-0.0.1-SNAPSHOT-jar-with-dependencies.jar compare --benchmark-result-previous $FILE/previous.ion --benchmark-result-new $FILE/new.ion $FILE/report.ion) && if [ "$regressionDetection" != "no regression detected" ]; then command=$(echo $FILE | sed "s/_/ /g") && read gc heapUsage speed <<< $( echo ${regressionDetection} | awk -F", " '{print $1" "$2" "$3}' ) && echo "|$command|$gc|$heapUsage|$speed|" >> $GITHUB_STEP_SUMMARY; fi; done + exit 1 \ No newline at end of file diff --git a/src/com/amazon/ion/apps/EncodeApp.java b/src/com/amazon/ion/apps/EncodeApp.java index 40045b6d43..4c7c0d06d9 100644 --- a/src/com/amazon/ion/apps/EncodeApp.java +++ b/src/com/amazon/ion/apps/EncodeApp.java @@ -24,7 +24,6 @@ import java.io.IOException; import java.util.ArrayList; - public class EncodeApp extends BaseApp { From 736e5e941e1ab0aa051e9e9667206f10b1f6aa9d Mon Sep 17 00:00:00 2001 From: Linlin Sun Date: Thu, 19 Jan 2023 15:18:15 -0800 Subject: [PATCH 07/10] update regression-detection --- .github/workflows/PR-content-check.yml | 13 +++++++--- ...n-java-performance-regression-detector.yml | 26 +++++++++---------- 2 files changed, 22 insertions(+), 17 deletions(-) diff --git a/.github/workflows/PR-content-check.yml b/.github/workflows/PR-content-check.yml index 490c549311..2ff672b738 100644 --- a/.github/workflows/PR-content-check.yml +++ b/.github/workflows/PR-content-check.yml @@ -3,12 +3,19 @@ name: PR Content Check -on: [pull_request] +on: + workflow_call: + outputs: + result: + description: "The first output string" + value: ${{ jobs.check-PR-content.outputs.output1 }} jobs: check-PR-content: name: Check PR Content runs-on: ubuntu-latest + outputs: + output1: ${{ steps.check-content.outputs.result }} steps: - name: Checkout the incoming pull request uses: actions/checkout@v3 @@ -21,5 +28,5 @@ jobs: id: check-content run: | cd ion-java-new - if [[ $(git log -1 --name-only) == *"src/"* ]]; then echo "result=pass"; else exit 1; fi - continue-on-error: true \ No newline at end of file + if [[ $(git log -1 --name-only) == *"src/"* ]]; then echo "result=pass" >> $GITHUB_OUTPUT; else echo "result=fail" >> $GITHUB_OUTPUT; fi + - name : \ No newline at end of file diff --git a/.github/workflows/ion-java-performance-regression-detector.yml b/.github/workflows/ion-java-performance-regression-detector.yml index 746232c2e6..90fa6972b2 100644 --- a/.github/workflows/ion-java-performance-regression-detector.yml +++ b/.github/workflows/ion-java-performance-regression-detector.yml @@ -4,16 +4,14 @@ name: Ion Java performance regression detector on: - workflow_run: - workflows: [ PR Content Check ] - types: - - completed - + pull_request jobs: + PR-Content-Check: + uses: linlin-s/ion-java/.github/workflows/PR-content-check.yml@master detect-regression: name: Detect Regression - needs: check-PR-content - if: ${{ github.event.workflow_run.conclusion == 'success' }} + needs: PR-Content-Check + if: ${{ needs.PR-Content-Check.outputs.result == 'pass' }} outputs: output1: ${{ steps.regression_result.outputs.result }} runs-on: ubuntu-latest @@ -138,10 +136,10 @@ jobs: runs-on: ubuntu-latest steps: - - name: Fail the workflow if regression happened - env: - regression_detect: ${{needs.detect-regression.outputs.output1}} - if: ${{ env.regression_detect == 'false' }} - run: | - cd benchmarkResults && echo "| Benchmark command | GC Allocation Rate | Heap Usage | Speed |" >> $GITHUB_STEP_SUMMARY && echo "| ----------- | ----------- |----------- | ----------- |" >> $GITHUB_STEP_SUMMARY && for FILE in *; do regressionDetection=$(java -jar /home/runner/work/ion-java/ion-java/ion-java-benchmark-cli/target/ion-java-benchmark-cli-0.0.1-SNAPSHOT-jar-with-dependencies.jar compare --benchmark-result-previous $FILE/previous.ion --benchmark-result-new $FILE/new.ion $FILE/report.ion) && if [ "$regressionDetection" != "no regression detected" ]; then command=$(echo $FILE | sed "s/_/ /g") && read gc heapUsage speed <<< $( echo ${regressionDetection} | awk -F", " '{print $1" "$2" "$3}' ) && echo "|$command|$gc|$heapUsage|$speed|" >> $GITHUB_STEP_SUMMARY; fi; done - exit 1 \ No newline at end of file + - name: Fail the workflow if regression happened + env: + regression_detect: ${{needs.detect-regression.outputs.output1}} + if: ${{ env.regression_detect == 'false' }} + run: | + cd benchmarkResults && echo "| Benchmark command | GC Allocation Rate | Heap Usage | Speed |" >> $GITHUB_STEP_SUMMARY && echo "| ----------- | ----------- |----------- | ----------- |" >> $GITHUB_STEP_SUMMARY && for FILE in *; do regressionDetection=$(java -jar /home/runner/work/ion-java/ion-java/ion-java-benchmark-cli/target/ion-java-benchmark-cli-0.0.1-SNAPSHOT-jar-with-dependencies.jar compare --benchmark-result-previous $FILE/previous.ion --benchmark-result-new $FILE/new.ion $FILE/report.ion) && if [ "$regressionDetection" != "no regression detected" ]; then command=$(echo $FILE | sed "s/_/ /g") && read gc heapUsage speed <<< $( echo ${regressionDetection} | awk -F", " '{print $1" "$2" "$3}' ) && echo "|$command|$gc|$heapUsage|$speed|" >> $GITHUB_STEP_SUMMARY; fi; done + exit 1 \ No newline at end of file From 1f00eaa6e227061c5d49f0c278df13baa4ab846b Mon Sep 17 00:00:00 2001 From: linlin-s Date: Thu, 19 Jan 2023 20:39:43 -0800 Subject: [PATCH 08/10] Source code change. (#38) --- .github/workflows/PR-content-check.yml | 1 - src/com/amazon/ion/apps/BaseApp.java | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/PR-content-check.yml b/.github/workflows/PR-content-check.yml index 2ff672b738..a4e8fe0e0c 100644 --- a/.github/workflows/PR-content-check.yml +++ b/.github/workflows/PR-content-check.yml @@ -29,4 +29,3 @@ jobs: run: | cd ion-java-new if [[ $(git log -1 --name-only) == *"src/"* ]]; then echo "result=pass" >> $GITHUB_OUTPUT; else echo "result=fail" >> $GITHUB_OUTPUT; fi - - name : \ No newline at end of file diff --git a/src/com/amazon/ion/apps/BaseApp.java b/src/com/amazon/ion/apps/BaseApp.java index d5890bb5ae..55ba5f2c2e 100644 --- a/src/com/amazon/ion/apps/BaseApp.java +++ b/src/com/amazon/ion/apps/BaseApp.java @@ -29,7 +29,7 @@ import java.io.FileNotFoundException; import java.io.IOException; import java.io.InputStream; - +//test only /** * ion_encode ion_print */ From 65f9eabd8d6b3cc93ffd03c6cda34b76c4208db6 Mon Sep 17 00:00:00 2001 From: linlin-s Date: Thu, 19 Jan 2023 21:14:09 -0800 Subject: [PATCH 09/10] Source code change (#39) --- .../ion-java-performance-regression-detector.yml | 10 ++-------- .github/workflows/ion-test-driver.yml | 10 +++++----- src/com/amazon/ion/apps/BaseApp.java | 2 +- 3 files changed, 8 insertions(+), 14 deletions(-) diff --git a/.github/workflows/ion-java-performance-regression-detector.yml b/.github/workflows/ion-java-performance-regression-detector.yml index 90fa6972b2..bec5d65488 100644 --- a/.github/workflows/ion-java-performance-regression-detector.yml +++ b/.github/workflows/ion-java-performance-regression-detector.yml @@ -130,16 +130,10 @@ jobs: name: Benchmark result path: benchmarkResults - output-result: - name: Output Results - needs: detect-regression - runs-on: ubuntu-latest - - steps: - name: Fail the workflow if regression happened env: - regression_detect: ${{needs.detect-regression.outputs.output1}} + regression_detect: ${{steps.regression_result.outputs.regression-result}} if: ${{ env.regression_detect == 'false' }} run: | cd benchmarkResults && echo "| Benchmark command | GC Allocation Rate | Heap Usage | Speed |" >> $GITHUB_STEP_SUMMARY && echo "| ----------- | ----------- |----------- | ----------- |" >> $GITHUB_STEP_SUMMARY && for FILE in *; do regressionDetection=$(java -jar /home/runner/work/ion-java/ion-java/ion-java-benchmark-cli/target/ion-java-benchmark-cli-0.0.1-SNAPSHOT-jar-with-dependencies.jar compare --benchmark-result-previous $FILE/previous.ion --benchmark-result-new $FILE/new.ion $FILE/report.ion) && if [ "$regressionDetection" != "no regression detected" ]; then command=$(echo $FILE | sed "s/_/ /g") && read gc heapUsage speed <<< $( echo ${regressionDetection} | awk -F", " '{print $1" "$2" "$3}' ) && echo "|$command|$gc|$heapUsage|$speed|" >> $GITHUB_STEP_SUMMARY; fi; done - exit 1 \ No newline at end of file + exit 1 diff --git a/.github/workflows/ion-test-driver.yml b/.github/workflows/ion-test-driver.yml index 537b46da21..002902356b 100644 --- a/.github/workflows/ion-test-driver.yml +++ b/.github/workflows/ion-test-driver.yml @@ -1,15 +1,15 @@ name: ion-test-driver on: - workflow_run: - workflows: [ PR Content Check ] - types: - - completed + pull_request jobs: + PR-Content-Check: + uses: linlin-s/ion-java/.github/workflows/PR-content-check.yml@master ion-test-driver: runs-on: macos-10.15 - if: ${{ github.event.workflow_run.conclusion == 'success' }} + needs: PR-Content-Check + if: ${{ needs.PR-Content-Check.outputs.result == 'pass' }} steps: - name: Checkout ion-java uses: actions/checkout@master diff --git a/src/com/amazon/ion/apps/BaseApp.java b/src/com/amazon/ion/apps/BaseApp.java index 55ba5f2c2e..d5890bb5ae 100644 --- a/src/com/amazon/ion/apps/BaseApp.java +++ b/src/com/amazon/ion/apps/BaseApp.java @@ -29,7 +29,7 @@ import java.io.FileNotFoundException; import java.io.IOException; import java.io.InputStream; -//test only + /** * ion_encode ion_print */ From 7dea269f705312e109ddfc65cf0d51be905db50c Mon Sep 17 00:00:00 2001 From: Linlin Sun Date: Thu, 19 Jan 2023 21:16:26 -0800 Subject: [PATCH 10/10] No source code change. --- .github/workflows/ion-java-performance-regression-detector.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ion-java-performance-regression-detector.yml b/.github/workflows/ion-java-performance-regression-detector.yml index bec5d65488..469d9c09b7 100644 --- a/.github/workflows/ion-java-performance-regression-detector.yml +++ b/.github/workflows/ion-java-performance-regression-detector.yml @@ -5,6 +5,7 @@ name: Ion Java performance regression detector on: pull_request + jobs: PR-Content-Check: uses: linlin-s/ion-java/.github/workflows/PR-content-check.yml@master