From b373e14ca3ac8936131a0dd88ba959da3f980f23 Mon Sep 17 00:00:00 2001 From: immanuwell Date: Mon, 1 Jun 2026 08:52:31 +0400 Subject: [PATCH] fix: use sass-embedded in local setup Problem The local setup docs and build hint still point contributors at plain sass. That is easy to hit in practice, and with the current Hugo Dart Sass path it can make a local linkerd.io build fail. Solution Update the local setup instructions and the Makefile hint to recommend sass-embedded, which matches the working local build path. Fixes #2121 Signed-off-by: immanuwell --- Makefile | 2 +- linkerd.io/README.md | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 678f6db6b2..53607edc36 100644 --- a/Makefile +++ b/Makefile @@ -118,7 +118,7 @@ ifndef HAS_HUGO @printf "Install hugo first. For OSX: brew install hugo\n"; exit 1 endif ifndef HAS_SASS - @printf "Install Dart Sass first: npm install sass\n"; exit 1 + @printf "Install Dart Sass Embedded first: npm install -g sass-embedded\n"; exit 1 endif cd tmp/linkerd.io && ./build diff --git a/linkerd.io/README.md b/linkerd.io/README.md index 870086fa8d..cff74846fd 100644 --- a/linkerd.io/README.md +++ b/linkerd.io/README.md @@ -12,12 +12,14 @@ docker run \ ### Install Hugo to develop locally -Install Dart Sass first: +Install Dart Sass Embedded first: ```bash -brew install sass/sass/sass +npm install -g sass-embedded ``` +This installs the `sass` executable that Hugo expects when building the site. + Then install Hugo: ```bash