[controller] Refactor push job details handling into PushJobDetailsMa…#2824
Open
eldernewborn wants to merge 1 commit into
Open
[controller] Refactor push job details handling into PushJobDetailsMa…#2824eldernewborn wants to merge 1 commit into
eldernewborn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
This PR extracts push-job-details read/write responsibilities from
VeniceHelixAdmininto a dedicatedPushJobDetailsManagerclass to improve separation of concerns and maintainability.Before this change,
VeniceHelixAdminowned:After this change, those responsibilities are encapsulated in
PushJobDetailsManager, whileVeniceHelixAdmindelegates to it.How this is implemented
services/venice-controller/src/main/java/com/linkedin/venice/controller/PushJobDetailsManager.javaservices/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceHelixAdmin.javaPushJobDetailsManager.VeniceHelixAdminbefore delegating write.services/venice-controller/src/test/java/com/linkedin/venice/controller/PushJobDetailsManagerTest.javaBehavior/compatibility notes
Testing performed
./gradlew :services:venice-controller:test --tests com.linkedin.venice.controller.PushJobDetailsManagerTest./gradlew :services:venice-controller:jacocoTestCoverageVerificationBoth commands passed locally.
Checklist
Resolves #<issue_number>