Merge pull request #11 from lightspeedwp/feature/block-bindings

Fix dynamic block render callbacks and PHP function names

Author: krugazul

.github/agents/generate-plugin.agent.md

@@ -1,7 +1,10 @@
+# SCF-Driven Content Model
+
+All post types, taxonomies, and field groups are now output as individual JSON files in `scf-json/` and registered by Secure Custom Fields (SCF). No PHP registration code is generated for post types or taxonomies.
 ---
 name: "Plugin Generator Agent"
 description: Interactive agent that collects comprehensive requirements and generates a WordPress multi-block plugin with CPT, taxonomies, and SCF fields
-tools: ["semantic_search", "read_file", "grep_search", "file_search", "run_in_terminal", "create_file", "update_file", "delete_file", "move_file"]
+tools: ['vscode', 'execute', 'read', 'edit', 'search', 'web', 'github/delete_file', 'agent', 'ms-vscode.vscode-websearchforcopilot/websearch', 'todo']
 permissions: ["read", "write", "execute", "shell", "filesystem"]
 ---
 
@@ -202,9 +205,35 @@ I will ask you about each taxonomy you want to create one by one.
 
 ### Stage 4: Custom Fields (SCF)
 
-I'll help you design field groups. I can work from a simple list or an interactive process.
+I'll help you design field groups. The generator will create SCF JSON files that Secure Custom Fields automatically loads from the `scf-json/` directory.
+
 For each field, please provide the **field label** (e.g., "Start Date") and the **field type** (e.g., `date_picker`). I will generate the field name automatically (e.g., `start_date`).
 
+**How It Works:**
+- Fields from `plugin-config.json` are converted to SCF JSON format
+- Generated files are saved to `scf-json/group_{slug}_fields.json`
+- SCF automatically loads and registers these field groups from JSON files
+- No PHP code required - pure JSON configuration
+
+**Configuration Options:**
+All fields support these common properties:
+- `name` — Field slug (lowercase with underscores)
+- `label` — Display label in admin
+- `type` — Field type (see below)
+- `instructions` — Help text shown below the field
+- `required` — Whether the field is required (true/false)
+- `default_value` — Default value for the field
+- `placeholder` — Placeholder text for text-based fields
+- `choices` — Options for select/radio/checkbox fields (object with key:value pairs)
+- `return_format` — Return format for certain field types (value, label, array, url, id, object)
+- `multiple` — Allow multiple selections (for select/post_object/user fields)
+- `allow_null` — Allow null/empty value
+
+**Number Field Options:**
+- `min` — Minimum value
+- `max` — Maximum value
+- `step` — Step increment (default: 1)
+
 **Example Field Request:**
 > "Add a 'Subtitle' text field, a 'Price' number field, and a 'Featured' true/false toggle."
 
@@ -275,31 +304,15 @@ itinerary (repeater)
 
 ### Stage 6: Blocks Configuration
 
-| Block | Purpose | Included |
-|-------|---------|----------|
-| `{{slug}}-card` | Single post card display | ✓ Default |
-| `{{slug}}-collection` | Query-based post grid | ✓ Default |
-| `{{slug}}-slider` | Carousel display | ✓ Default |
-| `{{slug}}-single` | Full post display | ✓ Default |
-| `{{slug}}-featured` | Featured posts section | ✓ Default |
-
-**Block Configuration Options:**
-
-For each block:
-- Category (common, text, media, design, widgets)
-- Icon (dashicon name)
-- Supports (align, anchor, className, color, spacing)
-- Variations (grid, list, slider layouts)
+**Note**: Block templates have been removed from the scaffold. Blocks should be implemented as patterns or custom code.
 
 ### Stage 7: Templates & Patterns
 
 | Item | File | Include? |
 |------|------|----------|
 | Single template | `templates/single-{{slug}}.html` | ✓ Default |
 | Archive template | `templates/archive-{{slug}}.html` | ✓ Default |
-| Card pattern | `patterns/{{slug}}-card.php` | ✓ Default |
 | Grid pattern | `patterns/{{slug}}-grid.php` | ✓ Default |
-| Featured pattern | `patterns/{{slug}}-featured.php` | ✓ Default |
 
 ### Stage 8: Additional Features
 
@@ -460,9 +473,9 @@ Which blocks do you want?
 
 ### Final Configuration
 
-**User**: "All defaults plus the search block"
+**User**: "All defaults"
 
-**Me**: "Adding search block.
+**Me**: "Using all defaults.
 
 **Final Configuration Summary:**
 
@@ -491,21 +504,14 @@ Fields:
   Repeater: features (feature_name, feature_icon)
 
 Blocks:
-  - real-estate-pro-card
-  - real-estate-pro-collection
-  - real-estate-pro-slider
-  - real-estate-pro-single
-  - real-estate-pro-featured
-  - real-estate-pro-search
+  - None (block templates removed - implement as patterns or custom code)
 
 Templates:
   - single-real-estate-pro.html
   - archive-real-estate-pro.html
 
 Patterns:
-  - real-estate-pro-card.php
   - real-estate-pro-grid.php
-  - real-estate-pro-featured.php
 ```
 
 **Ready to generate?** (yes/no/modify)"
@@ -517,25 +523,74 @@ Patterns:
 After generation, I can help with:
 
 ### 1. SCF Field Configuration
+
+Field groups are automatically generated as JSON files:
+
 ```bash
-# Field groups will be in:
+# Field group JSON files:
 scf-json/group_{{slug}}_fields.json
+
+# Schema for validation:
+.github/schemas/scf-field-group.schema.json
+```
+
+**SCF Local JSON Benefits:**
+- Version control friendly
+- No database queries for field definitions
+- Easy to backup and sync across environments
+- Can be edited directly or via WordPress admin
+
+The SCF_JSON class automatically configures the save/load paths so any field groups created in WordPress admin are saved to `scf-json/` and version controlled.
+
+### 2. Post Types & Taxonomies via SCF Local JSON
+
+Post types and taxonomies are defined using Secure Custom Fields' Local JSON format in the `scf-json/` directory:
+
+```bash
+# Post type JSON configuration:
+scf-json/post-type-{{slug}}.json
+
+# Taxonomy JSON configuration:
+scf-json/taxonomy-{{slug}}.json
+```
+
+**SCF Post Type JSON Example:**
+```json
+{
+  "key": "post_type_product",
+  "title": "Product",
+  "post_type": "product",
+  "active": true,
+  "labels": {
+    "name": "Products",
+    "singular_name": "Product"
+  }
+}
 ```
 
-### 2. Block Customisation
+**SCF Local JSON Benefits:**
+- Native SCF format for post types, taxonomies, and fields
+- Automatic loading via SCF's Local JSON system
+- Version control friendly
+- No separate Content_Model_Manager needed
+- Edit in WordPress admin, saved automatically to JSON
+
+The SCF_JSON class configures SCF to load post types, taxonomies, and field groups from `scf-json/` directory.
+
+### 3. Block Customisation
 ```bash
 # Edit block attributes and supports:
 src/blocks/{{slug}}-*/block.json
 ```
 
-### 3. Template Setup
+### 4. Template Setup
 ```bash
 # Customise templates with block bindings:
 templates/single-{{slug}}.html
 templates/archive-{{slug}}.html
 ```
 
-### 4. Development Start
+### 5. Development Start
 ```bash
 cd output-plugin
 composer install

.github/copilot-tasks.md

@@ -32,11 +32,11 @@ date: 2025-12-01
 **Status**: ✅ COMPLETED
 
 - [x] **Custom Post Types**
-  - Location: [inc/class-post-types.php](../inc/class-post-types.php)
+  - Location: JSON files in [/scf-json/](../scf-json/) (post-type-{slug}.json)
   - Registers: {{slug}} post type with block editor support
 
 - [x] **Custom Taxonomies**
-  - Location: [inc/class-taxonomies.php](../inc/class-taxonomies.php)
+  - Location: JSON files in [/scf-json/](../scf-json/) (taxonomy-{slug}.json)
   - Registers: {{slug}}_category taxonomy
 
 ---
@@ -46,7 +46,7 @@ date: 2025-12-01
 **Status**: ✅ COMPLETED
 
 - [x] **SCF Field Registration**
-  - Location: [inc/class-fields.php](../inc/class-fields.php)
+  - Location: JSON files in [/scf-json/](../scf-json/) (group_{name}.json)
   - Features: Subtitle, featured flag, gallery, related posts
 
 - [x] **Repeater Fields**
@@ -75,23 +75,11 @@ date: 2025-12-01
 
 ## 5. Block Development
 
-**Status**: 📋 TODO
-
-- [ ] **Card Block** - Single post card display
-  - Location: `src/blocks/{{slug}}-card/`
-  - Features: Post preview with featured image, title, excerpt
-
-- [ ] **Collection Block** - Post query/collection
-  - Location: `src/blocks/{{slug}}-collection/`
-  - Features: Grid/list/slider layouts, taxonomy filtering
+**Status**: ❌ REMOVED
 
-- [ ] **Slider Block** - Carousel/slider display
-  - Location: `src/blocks/{{slug}}-slider/`
-  - Features: ACF repeater integration, navigation, autoplay
+**Note**: Block templates have been removed from the scaffold. Implement blocks as patterns or custom code as needed.
 
-- [ ] **Featured Block** - Featured posts display
-  - Location: `src/blocks/{{slug}}-featured/`
-  - Features: Highlight featured {{name_plural_lower}}
+**Note**: Card and Featured blocks are implemented as patterns using the Collection block.
 
 ---
 
@@ -127,7 +115,8 @@ date: 2025-12-01
 
 - [ ] **Block Patterns**
   - Location: `patterns/`
-  - Files: {{slug}}-archive.php, {{slug}}-card.php, {{slug}}-grid.php
+  - Files: {{slug}}-archive.php, {{slug}}-grid.php
+  - Note: Implement card and featured displays as patterns
 
 ---
 

.github/custom-instructions.md

@@ -101,11 +101,6 @@ You are an expert WordPress multi-block plugin developer working on {{name}}, a
 ```
 {{slug}}/
 ├── src/
-│   ├── blocks/
-│   │   ├── {{slug}}-card/
-│   │   ├── {{slug}}-collection/
-│   │   ├── {{slug}}-slider/
-│   │   └── {{slug}}-featured/
 │   ├── components/
 │   │   ├── Slider/
 │   │   ├── PostSelector/
@@ -114,9 +109,7 @@ You are an expert WordPress multi-block plugin developer working on {{name}}, a
 │   ├── utils/
 │   └── scss/
 ├── inc/
-│   ├── class-post-types.php
-│   ├── class-taxonomies.php
-│   ├── class-fields.php
+│   ├── class-content-model-manager.php
 │   ├── class-repeater-fields.php
 │   ├── class-block-templates.php
 │   ├── class-block-bindings.php
@@ -181,14 +174,14 @@ You are an expert WordPress multi-block plugin developer working on {{name}}, a
 
 ### Custom Post Types
 
-- Register in `inc/class-post-types.php`
+- Register via JSON files in `/scf-json/` using SCF Local JSON format (handled by `inc/class-scf-json.php`)
 - Enable block editor support (`show_in_rest`)
 - Define block templates for consistent editing
 
 ### Custom Fields
 
 - Use Secure Custom Fields (SCF) API
-- Register fields in `inc/class-fields.php`
+- Register fields via JSON files in `/scf-json/` using SCF field group format (handled by `inc/class-scf-json.php`)
 - Implement repeater fields for complex data
 - Use Block Bindings for field display
 
@@ -254,7 +247,7 @@ Use these variables in templates and configuration files:
 
 **Adding Custom Fields**
 
-1. Register field group in `inc/class-fields.php`
+1. Register field group via JSON files in `/scf-json/` using SCF format (handled by `inc/class-scf-json.php`)
 2. Use `acf_add_local_field_group()` API
 3. Implement block binding if needed
 4. Test field functionality

.github/instructions/block-json.instructions.md

@@ -334,7 +334,7 @@ $alignment = $attributes['alignment'] ?? 'left';
 $post_id = $block->context['postId'] ?? get_the_ID();
 
 ?>
-<div class="wp-block-{{namespace}}-{{slug}}-card align<?php echo esc_attr( $alignment ); ?>">
+<div class="wp-block-{{namespace}}-custom-block align<?php echo esc_attr( $alignment ); ?>">
     <?php echo wp_kses_post( $content ); ?>
 </div>
 ```

.github/instructions/folder-structure.instructions.md

@@ -188,9 +188,9 @@ Use this guide when creating, moving, or auditing files. It covers where to plac
 
 **Block**:
 
-- **Location**: `src/blocks/{{slug}}-{block-name}/`
+- **Location**: `src/blocks/{block-name}/` (custom blocks only, no templates provided)
 - **Files**: `block.json`, `edit.js`, `save.js`, `render.php`, `style.scss`, `editor.scss`
-- **Example**: `src/blocks/{{slug}}-card/`
+- **Example**: `src/blocks/custom-block/`
 
 **Test File**:
 
@@ -496,8 +496,8 @@ fs.rmSync(tmpDir, { recursive: true, force: true });
 ### 2. Mirror Test Structure
 
 ```text
-src/blocks/{{slug}}-card/edit.js
-tests/js/blocks/{{slug}}-card.test.js
+src/blocks/custom-block/edit.js
+tests/js/blocks/custom-block.test.js
 ```
 
 ### 3. Namespace Everything

.github/instructions/generate-plugin.instructions.md

@@ -1,6 +1,6 @@
 # ⚠️ WARNING: Strict Mustache Placeholder Enforcement
 
-All contributors must use the correct mustache placeholders in all template files, folders, and code. Do not use generic placeholders (like `{{slug}}`) where a more specific one is required (e.g., `{{cpt1_slug}}`, `{{taxonomy1_slug}}`).
+All contributors must use the correct mustache placeholders in all template files, folders, and code. Do not use generic placeholders (like `{{slug}}`) where a more specific one is required (e.g., `{{cpt_slug}}`, `{{taxonomy1_slug}}`).
 
 **Never hard-code plugin-specific values** in the scaffold. All identifiers, class names, translation domains, and meta keys must use the appropriate placeholder as defined in `scripts/mustache-variables-registry.json`.
 
@@ -179,7 +179,7 @@ When generating taxonomy functionality:
 ```php
 // Use UPPERCASE namespace
 define( '{{namespace|upper}}_VERSION', '{{version}}' );
-define( '{{namespace|upper}}_PLUGIN_DIR', plugin_dir_path( __FILE__ ) );
+define( '{{namespace|upper}}_DIR', plugin_dir_path( __FILE__ ) );
 ```
 
 **Classes:**